* [PATCH] xenbus: don't look up transaction IDs for ordinary writes
@ 2016-08-15 15:02 Jan Beulich
2016-08-24 17:43 ` [Xen-devel] " David Vrabel
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2016-08-15 15:02 UTC (permalink / raw)
To: david.vrabel, boris.ostrovsky, Juergen Gross; +Cc: xen-devel, linux-kernel
This should really only be done for XS_TRANSACTION_END messages, or
else at least some of the xenstore-* tools don't work anymore.
Fixes: 0beef634b8 ("xenbus: don't BUG() on user mode induced condition")
Reported-by: Richard Schütz <rschuetz@uni-koblenz.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Richard Schütz <rschuetz@uni-koblenz.de>
---
drivers/xen/xenbus/xenbus_dev_frontend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 4.8-rc2/drivers/xen/xenbus/xenbus_dev_frontend.c
+++ 4.8-rc2-xen-xenbus-dev-write-oridinary/drivers/xen/xenbus/xenbus_dev_frontend.c
@@ -316,7 +316,7 @@ static int xenbus_write_transaction(unsi
rc = -ENOMEM;
goto out;
}
- } else {
+ } else if (msg_type == XS_TRANSACTION_END) {
list_for_each_entry(trans, &u->transactions, list)
if (trans->handle.id == u->u.msg.tx_id)
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Xen-devel] [PATCH] xenbus: don't look up transaction IDs for ordinary writes
2016-08-15 15:02 [PATCH] xenbus: don't look up transaction IDs for ordinary writes Jan Beulich
@ 2016-08-24 17:43 ` David Vrabel
0 siblings, 0 replies; 2+ messages in thread
From: David Vrabel @ 2016-08-24 17:43 UTC (permalink / raw)
To: Jan Beulich, david.vrabel, boris.ostrovsky, Juergen Gross
Cc: xen-devel, linux-kernel
On 15/08/16 16:02, Jan Beulich wrote:
> This should really only be done for XS_TRANSACTION_END messages, or
> else at least some of the xenstore-* tools don't work anymore.
Applied to for-linus-4.8b, thanks.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-24 17:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-15 15:02 [PATCH] xenbus: don't look up transaction IDs for ordinary writes Jan Beulich
2016-08-24 17:43 ` [Xen-devel] " David Vrabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).