linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: hi6220: add sd-uhs- properties into dwmmc_1
@ 2016-08-31 13:10 Guodong Xu
  2016-09-02 10:21 ` Wei Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Guodong Xu @ 2016-08-31 13:10 UTC (permalink / raw)
  To: xuwei5, robh+dt, mark.rutland, catalin.marinas, will.deacon
  Cc: devicetree, linux-arm-kernel, linux-kernel, Guodong Xu,
	Ulf Hansson, Jaehoon Chung, Jinguojun

With these properties added, sd cards inserted into hikey can work at UHS
mode if they have such capability.

Note, this depends on HiKey UHS-SD support patch [1] to work properly.
If you didn't add this patch, but added sd-uhs- properties into dwmmc_1,
then sd cards cannot work. As of this post, patch [1] has been integrated
into maintainer's next branch [2].

[1]: [V4] mmc: dw_mmc-k3: UHS-SD card for Hisilicon Hikey,
 https://patchwork.kernel.org/patch/9262515/
[2]: https://git.linaro.org/people/ulf.hansson/mmc.git next
 commit a8a5b2909cfc ("mmc: dw_mmc: k3: UHS-SD card for Hisilicon Hikey")

cc: Ulf Hansson <ulf.hansson@linaro.org>
cc: Jaehoon Chung <jh80.chung@samsung.com>
cc: Jinguojun <kid.jin@hisilicon.com>
Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
---
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 63608e9..17839db 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -785,6 +785,9 @@
 			card-detect-delay = <200>;
 			hisilicon,peripheral-syscon = <&ao_ctrl>;
 			cap-sd-highspeed;
+			sd-uhs-sdr12;
+			sd-uhs-sdr25;
+			sd-uhs-sdr50;
 			reg = <0x0 0xf723e000 0x0 0x1000>;
 			interrupts = <0x0 0x49 0x4>;
 			#address-cells = <0x1>;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: hi6220: add sd-uhs- properties into dwmmc_1
  2016-08-31 13:10 [PATCH] arm64: dts: hi6220: add sd-uhs- properties into dwmmc_1 Guodong Xu
@ 2016-09-02 10:21 ` Wei Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Wei Xu @ 2016-09-02 10:21 UTC (permalink / raw)
  To: Guodong Xu, robh+dt, mark.rutland, catalin.marinas, will.deacon
  Cc: devicetree, linux-arm-kernel, linux-kernel, Ulf Hansson,
	Jaehoon Chung, Jinguojun

Hi Guodong,

On 31/08/2016 14:10, Guodong Xu wrote:
> With these properties added, sd cards inserted into hikey can work at UHS
> mode if they have such capability.
> 
> Note, this depends on HiKey UHS-SD support patch [1] to work properly.
> If you didn't add this patch, but added sd-uhs- properties into dwmmc_1,
> then sd cards cannot work. As of this post, patch [1] has been integrated
> into maintainer's next branch [2].
> 
> [1]: [V4] mmc: dw_mmc-k3: UHS-SD card for Hisilicon Hikey,
>  https://patchwork.kernel.org/patch/9262515/
> [2]: https://git.linaro.org/people/ulf.hansson/mmc.git next
>  commit a8a5b2909cfc ("mmc: dw_mmc: k3: UHS-SD card for Hisilicon Hikey")
> 
> cc: Ulf Hansson <ulf.hansson@linaro.org>
> cc: Jaehoon Chung <jh80.chung@samsung.com>
> cc: Jinguojun <kid.jin@hisilicon.com>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>

Applied to the hisi-dt-4.9 branch.
Thanks!

Best Regards,
Wei

> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 63608e9..17839db 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -785,6 +785,9 @@
>  			card-detect-delay = <200>;
>  			hisilicon,peripheral-syscon = <&ao_ctrl>;
>  			cap-sd-highspeed;
> +			sd-uhs-sdr12;
> +			sd-uhs-sdr25;
> +			sd-uhs-sdr50;
>  			reg = <0x0 0xf723e000 0x0 0x1000>;
>  			interrupts = <0x0 0x49 0x4>;
>  			#address-cells = <0x1>;
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-02 10:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-31 13:10 [PATCH] arm64: dts: hi6220: add sd-uhs- properties into dwmmc_1 Guodong Xu
2016-09-02 10:21 ` Wei Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).