* [PATCH] perf/powerpc: Fix build-test failure
@ 2016-08-31 8:03 Ravi Bangoria
2016-09-07 15:37 ` Ravi Bangoria
2016-09-09 5:54 ` [tip:perf/core] perf powerpc: " tip-bot for Ravi Bangoria
0 siblings, 2 replies; 4+ messages in thread
From: Ravi Bangoria @ 2016-08-31 8:03 UTC (permalink / raw)
To: linux-kernel, acme; +Cc: peterz, mingo, alexander.shishkin, Ravi Bangoria
'make -C tools/perf build-test' is failing with below log for poewrpc.
In file included from /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf.h:15:0,
from util/cpumap.h:8,
from util/env.c:1:
/tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf-sys.h:23:56:
fatal error: ../../arch/powerpc/include/uapi/asm/unistd.h: No such file or directory
compilation terminated.
I bisected it and found it's failing from commit ad430729ae00 ("Remove:
kernel unistd*h files from perf's MANIFEST, not used").
Header file '../../arch/powerpc/include/uapi/asm/unistd.h' is included
only for powerpc in tools/perf/perf-sys.h.
By looking closly at commit history, I found little weird thing:
Commit f2d9cae9ea9e ("perf powerpc: Use uapi/unistd.h to fix build
error") replaced 'asm/unistd.h' with 'uapi/asm/unistd.h'
Commit d2709c7ce4c5 ("perf: Make perf build for x86 with UAPI
disintegration applied") removes all arch specific 'uapi/asm/unistd.h'
for all archs and adds generic <asm/unistd.h>.
Commit f0b9abfb0446 ("Merge branch 'linus' into perf/core") again
includes 'uapi/asm/unistd.h' for powerpc. Don't know how exactly this
happened as this change is not part of commit also.
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
---
tools/perf/perf-sys.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/perf-sys.h b/tools/perf/perf-sys.h
index 7ed72a4..e4b717e 100644
--- a/tools/perf/perf-sys.h
+++ b/tools/perf/perf-sys.h
@@ -20,7 +20,6 @@
#endif
#ifdef __powerpc__
-#include "../../arch/powerpc/include/uapi/asm/unistd.h"
#define CPUINFO_PROC {"cpu"}
#endif
--
2.4.11
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] perf/powerpc: Fix build-test failure
2016-08-31 8:03 [PATCH] perf/powerpc: Fix build-test failure Ravi Bangoria
@ 2016-09-07 15:37 ` Ravi Bangoria
2016-09-08 16:30 ` Arnaldo Carvalho de Melo
2016-09-09 5:54 ` [tip:perf/core] perf powerpc: " tip-bot for Ravi Bangoria
1 sibling, 1 reply; 4+ messages in thread
From: Ravi Bangoria @ 2016-09-07 15:37 UTC (permalink / raw)
To: acme; +Cc: linux-kernel, peterz, mingo, alexander.shishkin, Ravi Bangoria
Hi Arnaldo,
Can you please pick up this.
-Ravi
On Wednesday 31 August 2016 01:33 PM, Ravi Bangoria wrote:
> 'make -C tools/perf build-test' is failing with below log for poewrpc.
>
> In file included from /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf.h:15:0,
> from util/cpumap.h:8,
> from util/env.c:1:
> /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf-sys.h:23:56:
> fatal error: ../../arch/powerpc/include/uapi/asm/unistd.h: No such file or directory
> compilation terminated.
>
> I bisected it and found it's failing from commit ad430729ae00 ("Remove:
> kernel unistd*h files from perf's MANIFEST, not used").
>
> Header file '../../arch/powerpc/include/uapi/asm/unistd.h' is included
> only for powerpc in tools/perf/perf-sys.h.
>
> By looking closly at commit history, I found little weird thing:
>
> Commit f2d9cae9ea9e ("perf powerpc: Use uapi/unistd.h to fix build
> error") replaced 'asm/unistd.h' with 'uapi/asm/unistd.h'
>
> Commit d2709c7ce4c5 ("perf: Make perf build for x86 with UAPI
> disintegration applied") removes all arch specific 'uapi/asm/unistd.h'
> for all archs and adds generic <asm/unistd.h>.
>
> Commit f0b9abfb0446 ("Merge branch 'linus' into perf/core") again
> includes 'uapi/asm/unistd.h' for powerpc. Don't know how exactly this
> happened as this change is not part of commit also.
>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> ---
> tools/perf/perf-sys.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/perf-sys.h b/tools/perf/perf-sys.h
> index 7ed72a4..e4b717e 100644
> --- a/tools/perf/perf-sys.h
> +++ b/tools/perf/perf-sys.h
> @@ -20,7 +20,6 @@
> #endif
>
> #ifdef __powerpc__
> -#include "../../arch/powerpc/include/uapi/asm/unistd.h"
> #define CPUINFO_PROC {"cpu"}
> #endif
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf/powerpc: Fix build-test failure
2016-09-07 15:37 ` Ravi Bangoria
@ 2016-09-08 16:30 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-09-08 16:30 UTC (permalink / raw)
To: Ravi Bangoria; +Cc: linux-kernel, peterz, mingo, alexander.shishkin
Em Wed, Sep 07, 2016 at 09:07:54PM +0530, Ravi Bangoria escreveu:
> Hi Arnaldo,
>
> Can you please pick up this.
>
> -Ravi
>
> On Wednesday 31 August 2016 01:33 PM, Ravi Bangoria wrote:
> > 'make -C tools/perf build-test' is failing with below log for poewrpc.
> >
> > In file included from /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf.h:15:0,
> > from util/cpumap.h:8,
> > from util/env.c:1:
> > /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf-sys.h:23:56:
> > fatal error: ../../arch/powerpc/include/uapi/asm/unistd.h: No such file or directory
> > compilation terminated.
> >
> > I bisected it and found it's failing from commit ad430729ae00 ("Remove:
> > kernel unistd*h files from perf's MANIFEST, not used").
The above commit ad430729ae00 is broken for ppc, as we were still
referencing that kernel file, thanks for spotting this, adding your
patch with a Fixes ad430729ae00.
- Arnaldo
> > Header file '../../arch/powerpc/include/uapi/asm/unistd.h' is included
> > only for powerpc in tools/perf/perf-sys.h.
> >
> > By looking closly at commit history, I found little weird thing:
> >
> > Commit f2d9cae9ea9e ("perf powerpc: Use uapi/unistd.h to fix build
> > error") replaced 'asm/unistd.h' with 'uapi/asm/unistd.h'
> >
> > Commit d2709c7ce4c5 ("perf: Make perf build for x86 with UAPI
> > disintegration applied") removes all arch specific 'uapi/asm/unistd.h'
> > for all archs and adds generic <asm/unistd.h>.
> >
> > Commit f0b9abfb0446 ("Merge branch 'linus' into perf/core") again
> > includes 'uapi/asm/unistd.h' for powerpc. Don't know how exactly this
> > happened as this change is not part of commit also.
> >
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> > ---
> > tools/perf/perf-sys.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/perf/perf-sys.h b/tools/perf/perf-sys.h
> > index 7ed72a4..e4b717e 100644
> > --- a/tools/perf/perf-sys.h
> > +++ b/tools/perf/perf-sys.h
> > @@ -20,7 +20,6 @@
> > #endif
> >
> > #ifdef __powerpc__
> > -#include "../../arch/powerpc/include/uapi/asm/unistd.h"
> > #define CPUINFO_PROC {"cpu"}
> > #endif
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perf/core] perf powerpc: Fix build-test failure
2016-08-31 8:03 [PATCH] perf/powerpc: Fix build-test failure Ravi Bangoria
2016-09-07 15:37 ` Ravi Bangoria
@ 2016-09-09 5:54 ` tip-bot for Ravi Bangoria
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Ravi Bangoria @ 2016-09-09 5:54 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, peterz, acme, ravi.bangoria, alexander.shishkin, hpa,
tglx, linux-kernel
Commit-ID: 25b8592e912f085ce2ff736a2927584ddeab238c
Gitweb: http://git.kernel.org/tip/25b8592e912f085ce2ff736a2927584ddeab238c
Author: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
AuthorDate: Wed, 31 Aug 2016 13:33:11 +0530
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 8 Sep 2016 13:44:07 -0300
perf powerpc: Fix build-test failure
'make -C tools/perf build-test' is failing with below log for poewrpc.
In file included from /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf.h:15:0,
from util/cpumap.h:8,
from util/env.c:1:
/tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf-sys.h:23:56:
fatal error: ../../arch/powerpc/include/uapi/asm/unistd.h: No such file or directory
compilation terminated.
I bisected it and found it's failing from commit ad430729ae00 ("Remove:
kernel unistd*h files from perf's MANIFEST, not used").
Header file '../../arch/powerpc/include/uapi/asm/unistd.h' is included
only for powerpc in tools/perf/perf-sys.h.
By looking closly at commit history, I found little weird thing:
Commit f2d9cae9ea9e ("perf powerpc: Use uapi/unistd.h to fix build
error") replaced 'asm/unistd.h' with 'uapi/asm/unistd.h'
Commit d2709c7ce4c5 ("perf: Make perf build for x86 with UAPI
disintegration applied") removes all arch specific 'uapi/asm/unistd.h'
for all archs and adds generic <asm/unistd.h>.
Commit f0b9abfb0446 ("Merge branch 'linus' into perf/core") again
includes 'uapi/asm/unistd.h' for powerpc. Don't know how exactly this
happened as this change is not part of commit also.
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1472630591-5089-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com
Fixes: ad430729ae00 ("Remove: kernel unistd*h files from perf's MANIFEST, not used")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/perf-sys.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/perf-sys.h b/tools/perf/perf-sys.h
index 7ed72a4..e4b717e 100644
--- a/tools/perf/perf-sys.h
+++ b/tools/perf/perf-sys.h
@@ -20,7 +20,6 @@
#endif
#ifdef __powerpc__
-#include "../../arch/powerpc/include/uapi/asm/unistd.h"
#define CPUINFO_PROC {"cpu"}
#endif
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-09 5:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-31 8:03 [PATCH] perf/powerpc: Fix build-test failure Ravi Bangoria
2016-09-07 15:37 ` Ravi Bangoria
2016-09-08 16:30 ` Arnaldo Carvalho de Melo
2016-09-09 5:54 ` [tip:perf/core] perf powerpc: " tip-bot for Ravi Bangoria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).