* [PATCH] phy: sun4i-usb: Fix build dependency
@ 2016-09-16 2:15 Axel Lin
2016-09-16 8:37 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2016-09-16 2:15 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Hans de Goede, Maxime Ripard, linux-kernel, Axel Lin
of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
build error.
ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-sun4i-usb.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/phy/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index cc27c12..b65aba0 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -258,6 +258,8 @@ config PHY_SUN4I_USB
depends on RESET_CONTROLLER
depends on EXTCON
depends on POWER_SUPPLY
+ depends on USB_SUPPORT
+ select USB_COMMON
select GENERIC_PHY
help
Enable this to support the transceiver that is part of Allwinner
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: sun4i-usb: Fix build dependency
2016-09-16 2:15 [PATCH] phy: sun4i-usb: Fix build dependency Axel Lin
@ 2016-09-16 8:37 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2016-09-16 8:37 UTC (permalink / raw)
To: Axel Lin; +Cc: Hans de Goede, Maxime Ripard, linux-kernel, arnd
+Arnd
Hi,
On Friday 16 September 2016 07:45 AM, Axel Lin wrote:
> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
> build error.
>
> ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-sun4i-usb.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
Arnd was trying to solve the same issue.
Thanks
Kishon
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/phy/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index cc27c12..b65aba0 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -258,6 +258,8 @@ config PHY_SUN4I_USB
> depends on RESET_CONTROLLER
> depends on EXTCON
> depends on POWER_SUPPLY
> + depends on USB_SUPPORT
> + select USB_COMMON
> select GENERIC_PHY
> help
> Enable this to support the transceiver that is part of Allwinner
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-16 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 2:15 [PATCH] phy: sun4i-usb: Fix build dependency Axel Lin
2016-09-16 8:37 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).