linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] exynos-drm: Fix error messages to print flags and size
@ 2016-08-10 17:30 Shuah Khan
  2016-08-10 17:39 ` Javier Martinez Canillas
  2016-10-06 13:09 ` Tobias Jakobi
  0 siblings, 2 replies; 4+ messages in thread
From: Shuah Khan @ 2016-08-10 17:30 UTC (permalink / raw)
  To: inki.dae, jy0922.shim, sw0312.kim, kyungmin.park, airlied, kgene,
	k.kozlowski
  Cc: Shuah Khan, dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel

Fix exynos_drm_gem_create() error messages to include flags and size when
flags and size are invalid.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index cdf9f1a..4c4cb0e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -231,12 +231,12 @@ struct exynos_drm_gem *exynos_drm_gem_create(struct drm_device *dev,
 	int ret;
 
 	if (flags & ~(EXYNOS_BO_MASK)) {
-		DRM_ERROR("invalid flags.\n");
+		DRM_ERROR("invalid GEM buffer flags: %u\n", flags);
 		return ERR_PTR(-EINVAL);
 	}
 
 	if (!size) {
-		DRM_ERROR("invalid size.\n");
+		DRM_ERROR("invalid GEM buffer size: %lu\n", size);
 		return ERR_PTR(-EINVAL);
 	}
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] exynos-drm: Fix error messages to print flags and size
  2016-08-10 17:30 [PATCH] exynos-drm: Fix error messages to print flags and size Shuah Khan
@ 2016-08-10 17:39 ` Javier Martinez Canillas
  2016-10-06 13:09 ` Tobias Jakobi
  1 sibling, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-08-10 17:39 UTC (permalink / raw)
  To: Shuah Khan
  Cc: InKi Dae, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park,
	David Airlie, Kukjin Kim, Krzysztof Kozłowski,
	linux-arm-kernel, linux-samsung-soc, dri-devel, Linux Kernel

Hello Shuah,

On Wed, Aug 10, 2016 at 1:30 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> Fix exynos_drm_gem_create() error messages to include flags and size when
> flags and size are invalid.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
Javier

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] exynos-drm: Fix error messages to print flags and size
  2016-08-10 17:30 [PATCH] exynos-drm: Fix error messages to print flags and size Shuah Khan
  2016-08-10 17:39 ` Javier Martinez Canillas
@ 2016-10-06 13:09 ` Tobias Jakobi
  2016-10-19 13:28   ` Inki Dae
  1 sibling, 1 reply; 4+ messages in thread
From: Tobias Jakobi @ 2016-10-06 13:09 UTC (permalink / raw)
  To: Shuah Khan, inki.dae, jy0922.shim, sw0312.kim, kyungmin.park,
	airlied, kgene, k.kozlowski
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel

Hello,

I think this patch was never picked up. So just a short 'ping' from my side.

With best wishes,
Tobias


Shuah Khan wrote:
> Fix exynos_drm_gem_create() error messages to include flags and size when
> flags and size are invalid.
> 
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
> index cdf9f1a..4c4cb0e 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
> @@ -231,12 +231,12 @@ struct exynos_drm_gem *exynos_drm_gem_create(struct drm_device *dev,
>  	int ret;
>  
>  	if (flags & ~(EXYNOS_BO_MASK)) {
> -		DRM_ERROR("invalid flags.\n");
> +		DRM_ERROR("invalid GEM buffer flags: %u\n", flags);
>  		return ERR_PTR(-EINVAL);
>  	}
>  
>  	if (!size) {
> -		DRM_ERROR("invalid size.\n");
> +		DRM_ERROR("invalid GEM buffer size: %lu\n", size);
>  		return ERR_PTR(-EINVAL);
>  	}
>  
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] exynos-drm: Fix error messages to print flags and size
  2016-10-06 13:09 ` Tobias Jakobi
@ 2016-10-19 13:28   ` Inki Dae
  0 siblings, 0 replies; 4+ messages in thread
From: Inki Dae @ 2016-10-19 13:28 UTC (permalink / raw)
  To: Tobias Jakobi
  Cc: Shuah Khan, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park,
	Dave Airlie, Kukjin Kim, Krzysztof Kozlowski, linux-samsung-soc,
	linux-arm-kernel, DRI mailing list, linux-kernel

2016-10-06 22:09 GMT+09:00 Tobias Jakobi <tjakobi@math.uni-bielefeld.de>:
> Hello,
>
> I think this patch was never picked up. So just a short 'ping' from my side.
>

Oops. one I missed. Will pick it up soon.

Thanks,
Inki Dae

> With best wishes,
> Tobias
>
>
> Shuah Khan wrote:
>> Fix exynos_drm_gem_create() error messages to include flags and size when
>> flags and size are invalid.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
>> index cdf9f1a..4c4cb0e 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
>> @@ -231,12 +231,12 @@ struct exynos_drm_gem *exynos_drm_gem_create(struct drm_device *dev,
>>       int ret;
>>
>>       if (flags & ~(EXYNOS_BO_MASK)) {
>> -             DRM_ERROR("invalid flags.\n");
>> +             DRM_ERROR("invalid GEM buffer flags: %u\n", flags);
>>               return ERR_PTR(-EINVAL);
>>       }
>>
>>       if (!size) {
>> -             DRM_ERROR("invalid size.\n");
>> +             DRM_ERROR("invalid GEM buffer size: %lu\n", size);
>>               return ERR_PTR(-EINVAL);
>>       }
>>
>>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-19 14:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-10 17:30 [PATCH] exynos-drm: Fix error messages to print flags and size Shuah Khan
2016-08-10 17:39 ` Javier Martinez Canillas
2016-10-06 13:09 ` Tobias Jakobi
2016-10-19 13:28   ` Inki Dae

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).