* [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM
@ 2016-10-06 14:44 Geert Uytterhoeven
2016-10-06 14:48 ` Timur Tabi
2016-10-07 1:13 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2016-10-06 14:44 UTC (permalink / raw)
To: David S. Miller, Timur Tabi; +Cc: netdev, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
drivers/built-in.o: In function `emac_probe':
emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops'
emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops'
emac.c:(.text+0x378112): undefined reference to `bad_dma_ops'
emac.c:(.text+0x378146): undefined reference to `bad_dma_ops'
emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops'
drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow
If NO_IOMEM=y:
drivers/net/ethernet/qualcomm/emac/emac.c: In function ‘emac_remove’:
drivers/net/ethernet/qualcomm/emac/emac.c:736:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
iounmap(adpt->phy.digital);
^
Add dependencies on HAS_DMA and HAS_IOMEM to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v2:
- Add dependency on HAS_IOMEM for UML.
---
drivers/net/ethernet/qualcomm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig
index 9ba568db576fb0e6..d7720bf92d49658a 100644
--- a/drivers/net/ethernet/qualcomm/Kconfig
+++ b/drivers/net/ethernet/qualcomm/Kconfig
@@ -26,6 +26,7 @@ config QCA7000
config QCOM_EMAC
tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support"
+ depends on HAS_DMA && HAS_IOMEM
select CRC32
select PHYLIB
---help---
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM
2016-10-06 14:44 [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM Geert Uytterhoeven
@ 2016-10-06 14:48 ` Timur Tabi
2016-10-07 1:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Timur Tabi @ 2016-10-06 14:48 UTC (permalink / raw)
To: Geert Uytterhoeven, David S. Miller; +Cc: netdev, linux-kernel
Geert Uytterhoeven wrote:
> Add dependencies on HAS_DMA and HAS_IOMEM to fix this.
>
> Signed-off-by: Geert Uytterhoeven<geert@linux-m68k.org>
Acked-by: Timur Tabi <timur@codeaurora.org>
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM
2016-10-06 14:44 [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM Geert Uytterhoeven
2016-10-06 14:48 ` Timur Tabi
@ 2016-10-07 1:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-10-07 1:13 UTC (permalink / raw)
To: geert; +Cc: timur, netdev, linux-kernel
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 6 Oct 2016 16:44:53 +0200
> If NO_DMA=y:
>
> drivers/built-in.o: In function `emac_probe':
> emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x378112): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x378146): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops'
> drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow
>
> If NO_IOMEM=y:
>
> drivers/net/ethernet/qualcomm/emac/emac.c: In function ‘emac_remove’:
> drivers/net/ethernet/qualcomm/emac/emac.c:736:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(adpt->phy.digital);
> ^
>
> Add dependencies on HAS_DMA and HAS_IOMEM to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-07 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-06 14:44 [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM Geert Uytterhoeven
2016-10-06 14:48 ` Timur Tabi
2016-10-07 1:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).