* [PATCH -next] irqchip/brcmstb-l2: Make two init functions static
@ 2019-03-20 14:22 Yue Haibing
2019-03-20 16:14 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yue Haibing @ 2019-03-20 14:22 UTC (permalink / raw)
To: cernekee, f.fainelli, tglx, jason, marc.zyngier,
computersforpeace, gregory.0xf0, bcm-kernel-feedback-list
Cc: linux-kernel, linux-arm-kernel, linux-mips, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warnings:
drivers/irqchip/irq-brcmstb-l2.c:278:12: warning:
symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static?
drivers/irqchip/irq-brcmstb-l2.c:285:12: warning:
symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
index 83364fe..5e4ca13 100644
--- a/drivers/irqchip/irq-brcmstb-l2.c
+++ b/drivers/irqchip/irq-brcmstb-l2.c
@@ -275,14 +275,14 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np,
return ret;
}
-int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
+static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
struct device_node *parent)
{
return brcmstb_l2_intc_of_init(np, parent, &l2_edge_intc_init);
}
IRQCHIP_DECLARE(brcmstb_l2_intc, "brcm,l2-intc", brcmstb_l2_edge_intc_of_init);
-int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
+static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
struct device_node *parent)
{
return brcmstb_l2_intc_of_init(np, parent, &l2_lvl_intc_init);
--
2.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] irqchip/brcmstb-l2: Make two init functions static
2019-03-20 14:22 [PATCH -next] irqchip/brcmstb-l2: Make two init functions static Yue Haibing
@ 2019-03-20 16:14 ` Florian Fainelli
2019-03-20 19:37 ` Mukesh Ojha
2019-03-20 20:45 ` Mukesh Ojha
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2019-03-20 16:14 UTC (permalink / raw)
To: Yue Haibing, cernekee, tglx, jason, marc.zyngier,
computersforpeace, gregory.0xf0, bcm-kernel-feedback-list
Cc: linux-kernel, linux-arm-kernel, linux-mips
On 3/20/19 7:22 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/irqchip/irq-brcmstb-l2.c:278:12: warning:
> symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static?
> drivers/irqchip/irq-brcmstb-l2.c:285:12: warning:
> symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] irqchip/brcmstb-l2: Make two init functions static
2019-03-20 14:22 [PATCH -next] irqchip/brcmstb-l2: Make two init functions static Yue Haibing
2019-03-20 16:14 ` Florian Fainelli
@ 2019-03-20 19:37 ` Mukesh Ojha
2019-03-20 20:45 ` Mukesh Ojha
2 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-03-20 19:37 UTC (permalink / raw)
To: Yue Haibing, cernekee, f.fainelli, tglx, jason, marc.zyngier,
computersforpeace, gregory.0xf0, bcm-kernel-feedback-list
Cc: linux-kernel, linux-arm-kernel, linux-mips
On 3/20/2019 7:52 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/irqchip/irq-brcmstb-l2.c:278:12: warning:
> symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static?
> drivers/irqchip/irq-brcmstb-l2.c:285:12: warning:
> symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
> index 83364fe..5e4ca13 100644
> --- a/drivers/irqchip/irq-brcmstb-l2.c
> +++ b/drivers/irqchip/irq-brcmstb-l2.c
> @@ -275,14 +275,14 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np,
> return ret;
> }
>
> -int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
> +static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
> struct device_node *parent)
> {
> return brcmstb_l2_intc_of_init(np, parent, &l2_edge_intc_init);
> }
> IRQCHIP_DECLARE(brcmstb_l2_intc, "brcm,l2-intc", brcmstb_l2_edge_intc_of_init);
>
> -int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
> +static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
> struct device_node *parent)
> {
> return brcmstb_l2_intc_of_init(np, parent, &l2_lvl_intc_init);
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Thanks,
Mukesh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] irqchip/brcmstb-l2: Make two init functions static
2019-03-20 14:22 [PATCH -next] irqchip/brcmstb-l2: Make two init functions static Yue Haibing
2019-03-20 16:14 ` Florian Fainelli
2019-03-20 19:37 ` Mukesh Ojha
@ 2019-03-20 20:45 ` Mukesh Ojha
2 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-03-20 20:45 UTC (permalink / raw)
To: Yue Haibing, cernekee, f.fainelli, tglx, jason, marc.zyngier,
computersforpeace, gregory.0xf0, bcm-kernel-feedback-list
Cc: linux-kernel, linux-arm-kernel, linux-mips
On 3/20/2019 7:52 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/irqchip/irq-brcmstb-l2.c:278:12: warning:
> symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static?
> drivers/irqchip/irq-brcmstb-l2.c:285:12: warning:
> symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
> index 83364fe..5e4ca13 100644
> --- a/drivers/irqchip/irq-brcmstb-l2.c
> +++ b/drivers/irqchip/irq-brcmstb-l2.c
> @@ -275,14 +275,14 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np,
> return ret;
> }
>
> -int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
> +static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
> struct device_node *parent)
> {
> return brcmstb_l2_intc_of_init(np, parent, &l2_edge_intc_init);
> }
> IRQCHIP_DECLARE(brcmstb_l2_intc, "brcm,l2-intc", brcmstb_l2_edge_intc_of_init);
>
> -int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
> +static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
> struct device_node *parent)
> {
> return
Acked-by: Mukesh Ojha <mojha@codeaurora.org>
Thanks,
Mukesh
> brcmstb_l2_intc_of_init(np, parent, &l2_lvl_intc_init);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-20 20:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 14:22 [PATCH -next] irqchip/brcmstb-l2: Make two init functions static Yue Haibing
2019-03-20 16:14 ` Florian Fainelli
2019-03-20 19:37 ` Mukesh Ojha
2019-03-20 20:45 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).