From: Daniele Nicolodi <daniele@grinta.net>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-media@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [media] bt8xx: One function call less in bttv_input_init() after error detection
Date: Mon, 12 Dec 2016 00:39:39 -0700 [thread overview]
Message-ID: <581046dd-0a4a-acea-a6a8-8d2469594881@grinta.net> (raw)
In-Reply-To: <ce612b15-0dff-ce33-6b22-3a2775bed4cd@users.sourceforge.net>
On 12/12/16 00:33, SF Markus Elfring wrote:
>>> I would prefer a safer coding style for the corresponding
>>> exception handling.
>>
>> Can you please point out what is wrong in the current code
>
> Is it useful to reconsider the software situation that another memory
> allocation is attempted when it could be determined that a previous one
> failed already?
No.
> Are two successful allocations finally needed to achieve the desired task?
Yes.
>> and how the changes you propose fix the problem?
>
> I suggest to check return values immediately after each function call.
> An error situation can be detected earlier then and only the required
> clean-up functionality will be executed at the end.
Which improvement does this bring?
>> No one has expressed acceptance for the kind of change you propose with
>> this patch, or to previous patches you proposed changing similar constructs.
>
> I got a mixed impression from the acceptance statistics about my
> published patches.
Have you proposed a similar patch that was accepted? I don't find record
of it, but I may be wrong.
>> The fact that you propose over and over again a class of changes that
>> has been already vocally rejected would suggest otherwise.
>
> I dare to propose another look at results from source code search patterns.
Why?
Cheers,
Daniele
next prev parent reply other threads:[~2016-12-12 7:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 20:45 [PATCH 0/4] [media] bt8xx: Fine-tuning for three functions SF Markus Elfring
2016-12-10 20:48 ` [PATCH 1/4] [media] bt8xx: One function call less in bttv_input_init() after error detection SF Markus Elfring
2016-12-10 21:29 ` Daniele Nicolodi
2016-12-10 22:10 ` SF Markus Elfring
2016-12-11 21:52 ` Daniele Nicolodi
2016-12-12 7:33 ` SF Markus Elfring
2016-12-12 7:39 ` Daniele Nicolodi [this message]
2016-12-12 17:15 ` SF Markus Elfring
2016-12-12 17:56 ` Daniele Nicolodi
2016-12-12 18:03 ` Clarification for acceptance statistics? SF Markus Elfring
2016-12-12 21:02 ` Daniele Nicolodi
2016-12-12 22:11 ` SF Markus Elfring
2016-12-12 23:19 ` Daniele Nicolodi
2016-12-12 19:11 ` [media] bt8xx: One function call less in bttv_input_init() after error detection Dan Carpenter
2016-12-10 20:50 ` [PATCH 2/4] [media] bt8xx: Delete two error messages for a failed memory allocation SF Markus Elfring
2016-12-10 20:51 ` [PATCH 3/4] [media] bt8xx: Delete unnecessary variable initialisations in ca_send_message() SF Markus Elfring
2016-12-10 20:53 ` [PATCH 4/4] [media] bt8xx: Less function calls in dst_ca_ioctl() after error detection SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=581046dd-0a4a-acea-a6a8-8d2469594881@grinta.net \
--to=daniele@grinta.net \
--cc=elfring@users.sourceforge.net \
--cc=hans.verkuil@cisco.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).