From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Daniele Nicolodi <daniele@grinta.net>
Cc: linux-media@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [media] bt8xx: One function call less in bttv_input_init() after error detection
Date: Mon, 12 Dec 2016 18:15:45 +0100 [thread overview]
Message-ID: <baf6a24e-6a4e-f1ea-1b4d-7a3211964e4b@users.sourceforge.net> (raw)
In-Reply-To: <581046dd-0a4a-acea-a6a8-8d2469594881@grinta.net>
>> I suggest to check return values immediately after each function call.
>> An error situation can be detected earlier then and only the required
>> clean-up functionality will be executed at the end.
>
> Which improvement does this bring?
* How do you think about to avoid requesting additional system resources
when it was determined that a previously required memory allocation failed?
* Can the corresponding exception handling become a bit more efficient?
> Why?
Do you care for any results from static source code analysis?
Regards,
Markus
next prev parent reply other threads:[~2016-12-12 17:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 20:45 [PATCH 0/4] [media] bt8xx: Fine-tuning for three functions SF Markus Elfring
2016-12-10 20:48 ` [PATCH 1/4] [media] bt8xx: One function call less in bttv_input_init() after error detection SF Markus Elfring
2016-12-10 21:29 ` Daniele Nicolodi
2016-12-10 22:10 ` SF Markus Elfring
2016-12-11 21:52 ` Daniele Nicolodi
2016-12-12 7:33 ` SF Markus Elfring
2016-12-12 7:39 ` Daniele Nicolodi
2016-12-12 17:15 ` SF Markus Elfring [this message]
2016-12-12 17:56 ` Daniele Nicolodi
2016-12-12 18:03 ` Clarification for acceptance statistics? SF Markus Elfring
2016-12-12 21:02 ` Daniele Nicolodi
2016-12-12 22:11 ` SF Markus Elfring
2016-12-12 23:19 ` Daniele Nicolodi
2016-12-12 19:11 ` [media] bt8xx: One function call less in bttv_input_init() after error detection Dan Carpenter
2016-12-10 20:50 ` [PATCH 2/4] [media] bt8xx: Delete two error messages for a failed memory allocation SF Markus Elfring
2016-12-10 20:51 ` [PATCH 3/4] [media] bt8xx: Delete unnecessary variable initialisations in ca_send_message() SF Markus Elfring
2016-12-10 20:53 ` [PATCH 4/4] [media] bt8xx: Less function calls in dst_ca_ioctl() after error detection SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf6a24e-6a4e-f1ea-1b4d-7a3211964e4b@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=daniele@grinta.net \
--cc=hans.verkuil@cisco.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).