* [PATCH] Input: drv260x - fix initializing overdrive voltage
@ 2016-12-11 6:59 Dmitry Torokhov
2016-12-12 13:00 ` Dan Murphy
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2016-12-11 6:59 UTC (permalink / raw)
To: Dan Murphy; +Cc: linux-input, linux-kernel
We were accidentally initializing haptics->rated_voltage twice, and did not
initialize overdrive voltage.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/drv260x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
index 2adfd86c..9789d4f 100644
--- a/drivers/input/misc/drv260x.c
+++ b/drivers/input/misc/drv260x.c
@@ -521,7 +521,7 @@ static int drv260x_probe(struct i2c_client *client,
if (!haptics)
return -ENOMEM;
- haptics->rated_voltage = DRV260X_DEF_OD_CLAMP_VOLT;
+ haptics->overdrive_voltage = DRV260X_DEF_OD_CLAMP_VOLT;
haptics->rated_voltage = DRV260X_DEF_RATED_VOLT;
if (pdata) {
--
2.8.0.rc3.226.g39d4020
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: drv260x - fix initializing overdrive voltage
2016-12-11 6:59 [PATCH] Input: drv260x - fix initializing overdrive voltage Dmitry Torokhov
@ 2016-12-12 13:00 ` Dan Murphy
0 siblings, 0 replies; 2+ messages in thread
From: Dan Murphy @ 2016-12-12 13:00 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel
Dmitry
On 12/11/2016 12:59 AM, Dmitry Torokhov wrote:
> We were accidentally initializing haptics->rated_voltage twice, and did not
> initialize overdrive voltage.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/misc/drv260x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
> index 2adfd86c..9789d4f 100644
> --- a/drivers/input/misc/drv260x.c
> +++ b/drivers/input/misc/drv260x.c
> @@ -521,7 +521,7 @@ static int drv260x_probe(struct i2c_client *client,
> if (!haptics)
> return -ENOMEM;
>
> - haptics->rated_voltage = DRV260X_DEF_OD_CLAMP_VOLT;
> + haptics->overdrive_voltage = DRV260X_DEF_OD_CLAMP_VOLT;
> haptics->rated_voltage = DRV260X_DEF_RATED_VOLT;
>
> if (pdata) {
Thanks for the fix
Acked-by: Dan Murphy <dmurphy@ti.com>
--
------------------
Dan Murphy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-12 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-11 6:59 [PATCH] Input: drv260x - fix initializing overdrive voltage Dmitry Torokhov
2016-12-12 13:00 ` Dan Murphy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).