* [PATCH] remoteproc: stm32: don't print an error on probe deferral
@ 2020-12-09 13:12 Arnaud Pouliquen
2020-12-09 14:06 ` [Linux-stm32] " Ahmad Fatoum
0 siblings, 1 reply; 3+ messages in thread
From: Arnaud Pouliquen @ 2020-12-09 13:12 UTC (permalink / raw)
To: Bjorn Andersson, Ohad Ben-Cohen, Mathieu Poirier
Cc: linux-remoteproc, linux-kernel, linux-stm32, arnaud.pouliquen,
Etienne Carriere
From: Etienne Carriere <etienne.carriere@st.com>
Change stm32 remoteproc driver to not generate an error message
when device probe operation is deferred for the reset controller.
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
---
drivers/remoteproc/stm32_rproc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index a180aeae9675..25c916782991 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -614,7 +614,9 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
ddata->rst = devm_reset_control_get_by_index(dev, 0);
if (IS_ERR(ddata->rst)) {
- dev_err(dev, "failed to get mcu reset\n");
+ if (PTR_ERR(ddata->rst) != -EPROBE_DEFER)
+ dev_err(dev, "failed to get mcu reset\n");
+
return PTR_ERR(ddata->rst);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Linux-stm32] [PATCH] remoteproc: stm32: don't print an error on probe deferral
2020-12-09 13:12 [PATCH] remoteproc: stm32: don't print an error on probe deferral Arnaud Pouliquen
@ 2020-12-09 14:06 ` Ahmad Fatoum
2020-12-09 14:41 ` Arnaud POULIQUEN
0 siblings, 1 reply; 3+ messages in thread
From: Ahmad Fatoum @ 2020-12-09 14:06 UTC (permalink / raw)
To: Arnaud Pouliquen, Bjorn Andersson, Ohad Ben-Cohen, Mathieu Poirier
Cc: Etienne Carriere, linux-remoteproc, linux-kernel, linux-stm32
Hello Arnaud,
On Wed, 2020-12-09 at 14:12 +0100, Arnaud Pouliquen wrote:
> From: Etienne Carriere <etienne.carriere@st.com>
>
> Change stm32 remoteproc driver to not generate an error message
> when device probe operation is deferred for the reset controller.
>
> Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
> ---
> drivers/remoteproc/stm32_rproc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c
> b/drivers/remoteproc/stm32_rproc.c
> index a180aeae9675..25c916782991 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -614,7 +614,9 @@ static int stm32_rproc_parse_dt(struct
> platform_device *pdev,
>
> ddata->rst = devm_reset_control_get_by_index(dev, 0);
> if (IS_ERR(ddata->rst)) {
> - dev_err(dev, "failed to get mcu reset\n");
> + if (PTR_ERR(ddata->rst) != -EPROBE_DEFER)
> + dev_err(dev, "failed to get mcu reset\n");
> +
There is dev_err_probe() now that could be used here instead.
It has the added benefit that it records the reason for the
deferred probe.
> return PTR_ERR(ddata->rst);
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Linux-stm32] [PATCH] remoteproc: stm32: don't print an error on probe deferral
2020-12-09 14:06 ` [Linux-stm32] " Ahmad Fatoum
@ 2020-12-09 14:41 ` Arnaud POULIQUEN
0 siblings, 0 replies; 3+ messages in thread
From: Arnaud POULIQUEN @ 2020-12-09 14:41 UTC (permalink / raw)
To: Ahmad Fatoum, Bjorn Andersson, Ohad Ben-Cohen, Mathieu Poirier
Cc: Etienne Carriere, linux-remoteproc, linux-kernel, linux-stm32
On 12/9/20 3:06 PM, Ahmad Fatoum wrote:
> Hello Arnaud,
>
> On Wed, 2020-12-09 at 14:12 +0100, Arnaud Pouliquen wrote:
>> From: Etienne Carriere <etienne.carriere@st.com>
>>
>> Change stm32 remoteproc driver to not generate an error message
>> when device probe operation is deferred for the reset controller.
>>
>> Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
>> ---
>> drivers/remoteproc/stm32_rproc.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/stm32_rproc.c
>> b/drivers/remoteproc/stm32_rproc.c
>> index a180aeae9675..25c916782991 100644
>> --- a/drivers/remoteproc/stm32_rproc.c
>> +++ b/drivers/remoteproc/stm32_rproc.c
>> @@ -614,7 +614,9 @@ static int stm32_rproc_parse_dt(struct
>> platform_device *pdev,
>>
>> ddata->rst = devm_reset_control_get_by_index(dev, 0);
>> if (IS_ERR(ddata->rst)) {
>> - dev_err(dev, "failed to get mcu reset\n");
>> + if (PTR_ERR(ddata->rst) != -EPROBE_DEFER)
>> + dev_err(dev, "failed to get mcu reset\n");
>> +
>
> There is dev_err_probe() now that could be used here instead.
> It has the added benefit that it records the reason for the
> deferred probe.
Thanks for the advice, I will test it!
>
>> return PTR_ERR(ddata->rst);
>> }
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-09 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 13:12 [PATCH] remoteproc: stm32: don't print an error on probe deferral Arnaud Pouliquen
2020-12-09 14:06 ` [Linux-stm32] " Ahmad Fatoum
2020-12-09 14:41 ` Arnaud POULIQUEN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).