* [PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments
@ 2016-12-19 14:36 devendra sharma
2016-12-19 17:48 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: devendra sharma @ 2016-12-19 14:36 UTC (permalink / raw)
To: abbotti; +Cc: hsweeten, gregkh, devel, linux-kernel, devendra sharma
Added comments before memory barrier
Signed-off-by: Devendra Sharma <devendra.sharma9091@gmail.com>
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
index c9eb26f..c3b5236 100644
--- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
+++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
@@ -122,6 +122,7 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
mutex_lock(&devpriv->mutex);
for (n = 0; n < insn->n; n++) {
+ /*multi-processor memory barrier*/
smp_mb();
/* trigger conversion and write data */
outw_p(data[n], dev->iobase);
@@ -141,6 +142,7 @@ static int dyna_pci10xx_di_insn_bits(struct comedi_device *dev,
u16 d = 0;
mutex_lock(&devpriv->mutex);
+ /*multi-processor memory barrier*/
smp_mb();
d = inw_p(devpriv->BADR3);
udelay(10);
@@ -161,6 +163,7 @@ static int dyna_pci10xx_do_insn_bits(struct comedi_device *dev,
mutex_lock(&devpriv->mutex);
if (comedi_dio_update_state(s, data)) {
+ /*multi-processor memory barrier*/
smp_mb();
outw_p(s->state, devpriv->BADR3);
udelay(10);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments
2016-12-19 14:36 [PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments devendra sharma
@ 2016-12-19 17:48 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2016-12-19 17:48 UTC (permalink / raw)
To: devendra sharma; +Cc: hsweeten, gregkh, devel, linux-kernel
On 19/12/2016 14:36, devendra sharma wrote:
> Added comments before memory barrier
>
> Signed-off-by: Devendra Sharma <devendra.sharma9091@gmail.com>
> ---
> drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> index c9eb26f..c3b5236 100644
> --- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
> +++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> @@ -122,6 +122,7 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
>
> mutex_lock(&devpriv->mutex);
> for (n = 0; n < insn->n; n++) {
> + /*multi-processor memory barrier*/
> smp_mb();
Thanks for the effort, but these comments add no useful information and
serve only to silence the checkpatch warnings. Also, there is no space
after the '/*' and before the '*/'.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-19 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-19 14:36 [PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments devendra sharma
2016-12-19 17:48 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).