[PATCH] sched: updated comments of CLONE_NEWNS

[PATCH] sched: updated comments of CLONE_NEWNS

[Chen Hanxiao]

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
---
 include/uapi/linux/sched.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
index 34f9d73..db765b4 100644
--- a/include/uapi/linux/sched.h
+++ b/include/uapi/linux/sched.h
@@ -13,7 +13,7 @@
 #define CLONE_VFORK	0x00004000	/* set if the parent wants the child to wake it up on mm_release */
 #define CLONE_PARENT	0x00008000	/* set if we want to have the same parent as the cloner */
 #define CLONE_THREAD	0x00010000	/* Same thread group? */
-#define CLONE_NEWNS	0x00020000	/* New namespace group? */
+#define CLONE_NEWNS	0x00020000	/* New mount namespace group? */
 #define CLONE_SYSVSEM	0x00040000	/* share system V SEM_UNDO semantics */
 #define CLONE_SETTLS	0x00080000	/* create a new TLS for the child */
 #define CLONE_PARENT_SETTID	0x00100000	/* set the TID in the parent */
-- 
1.9.0

Re: [PATCH] sched: updated comments of CLONE_NEWNS

[Serge Hallyn]

Quoting Chen Hanxiao (chenhanxiao@cn.fujitsu.com):
> Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>

Yeah that'll be helpful to anyone new to these parts.  But, why the question mark,
should you drop that too?  Either way

Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

> ---
>  include/uapi/linux/sched.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
> index 34f9d73..db765b4 100644
> --- a/include/uapi/linux/sched.h
> +++ b/include/uapi/linux/sched.h
> @@ -13,7 +13,7 @@
>  #define CLONE_VFORK	0x00004000	/* set if the parent wants the child to wake it up on mm_release */
>  #define CLONE_PARENT	0x00008000	/* set if we want to have the same parent as the cloner */
>  #define CLONE_THREAD	0x00010000	/* Same thread group? */
> -#define CLONE_NEWNS	0x00020000	/* New namespace group? */
> +#define CLONE_NEWNS	0x00020000	/* New mount namespace group? */
>  #define CLONE_SYSVSEM	0x00040000	/* share system V SEM_UNDO semantics */
>  #define CLONE_SETTLS	0x00080000	/* create a new TLS for the child */
>  #define CLONE_PARENT_SETTID	0x00100000	/* set the TID in the parent */
> -- 
> 1.9.0
> 
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/containers

RE: [PATCH] sched: updated comments of CLONE_NEWNS

[Chen, Hanxiao]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 888 bytes --]



> -----Original Message-----
> From: Serge Hallyn [mailto:serge.hallyn@ubuntu.com]
> Sent: Monday, October 06, 2014 10:27 PM
> To: Chen, Hanxiao/³Â êÏÏö
> Cc: Ingo Molnar; Peter Zijlstra; David Howells;
> containers@lists.linux-foundation.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] sched: updated comments of CLONE_NEWNS
> 
> Quoting Chen Hanxiao (chenhanxiao@cn.fujitsu.com):
> > Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
> 
> Yeah that'll be helpful to anyone new to these parts.  But, why the question mark,
> should you drop that too?  Either way

Yes, we should drop that question mark.
I'll send a v2 patch soon.

Thanks,
- Chen

> 
> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
> 

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥