From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v10 2/3] serial: exar: split out the exar code from 8250_pci
Date: Fri, 20 Jan 2017 23:55:53 +0000 [thread overview]
Message-ID: <5882A389.1070701@gmail.com> (raw)
In-Reply-To: <CAHp75VeQOHdKd7C_yO-ts9W_Gv5BYJSUp+JdpkhvaJFSYnFpzw@mail.gmail.com>
On Friday 20 January 2017 10:25 PM, Andy Shevchenko wrote:
> On Fri, Jan 20, 2017 at 12:23 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
>> From: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>>
>> Add the serial driver for the Exar chips. And also register the
>> platform device for the GPIO provided by the Exar chips.
>
> Thanks, this is indeed much cleaner that v6 I saw couple of weeks before!
>
>> Andy,
>> Having 3 setup hooks and assigning everything there was becoming too
>> complicated for me to follow, so i left it as it is. Though some more
>> parts from the board setup has been removed. uart_offset has been
>> completely removed.
>
> Yes, what about baudrate?
> I will check later, but for me it seems other way, i.e. simpler to
> have just 3 setup functions in a row than one is lurking somewhere
> with allocation et al.
>
<snip>
>> + CONNECT_DEVICE(XR17C154, UART_4_485),
>> + CONNECT_DEVICE(XR17C158, UART_8_485),
>
> Perhaps it takes few LOC more, but having same defined struct here
> with dedicated ->setup() looks cleaner to me.
>
I think now I understand the 3 different setup functions. Let me try v11
(hopefully the last one).
Regards
Sudip
next prev parent reply other threads:[~2017-01-20 23:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 22:23 [PATCH v10 1/3] gpio: exar: add gpio for exar cards Sudip Mukherjee
2017-01-19 22:23 ` [PATCH v10 2/3] serial: exar: split out the exar code from 8250_pci Sudip Mukherjee
2017-01-20 22:25 ` Andy Shevchenko
2017-01-20 23:55 ` Sudip Mukherjee [this message]
2017-01-19 22:23 ` [PATCH v10 3/3] serial: 8250_pci: remove exar code Sudip Mukherjee
2017-01-20 22:29 ` Andy Shevchenko
2017-01-20 22:02 ` [PATCH v10 1/3] gpio: exar: add gpio for exar cards Andy Shevchenko
2017-01-20 23:50 ` Sudip Mukherjee
2017-01-26 10:17 ` Linus Walleij
2017-01-26 10:16 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5882A389.1070701@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).