From: Linus Walleij <linus.walleij@linaro.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v10 1/3] gpio: exar: add gpio for exar cards
Date: Thu, 26 Jan 2017 11:16:15 +0100 [thread overview]
Message-ID: <CACRpkdb3L+C+rVB1FPWJ_gGxHPzGAgUFxEBYPTHJQ1_=06y5_g@mail.gmail.com> (raw)
In-Reply-To: <1484864602-5266-1-git-send-email-sudipm.mukherjee@gmail.com>
On Thu, Jan 19, 2017 at 11:23 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> From: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>
> Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
> can be controlled using gpio interface.
>
> Add the gpio specific code.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Patch applied.
I think maybe we can simplify the patch even more using
select GPIO_GENERIC and just specify the different
registers to bgpio_init().
But that can be done as a separate improvement patch, this
definately looks fine.
Maybe you also want something like:
default SERIAL_8250_EXAR
so that the module is by default added as "y" or "m" depending
on what is selected for the parent device?
Yours,
Linus Walleij
prev parent reply other threads:[~2017-01-26 10:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 22:23 [PATCH v10 1/3] gpio: exar: add gpio for exar cards Sudip Mukherjee
2017-01-19 22:23 ` [PATCH v10 2/3] serial: exar: split out the exar code from 8250_pci Sudip Mukherjee
2017-01-20 22:25 ` Andy Shevchenko
2017-01-20 23:55 ` Sudip Mukherjee
2017-01-19 22:23 ` [PATCH v10 3/3] serial: 8250_pci: remove exar code Sudip Mukherjee
2017-01-20 22:29 ` Andy Shevchenko
2017-01-20 22:02 ` [PATCH v10 1/3] gpio: exar: add gpio for exar cards Andy Shevchenko
2017-01-20 23:50 ` Sudip Mukherjee
2017-01-26 10:17 ` Linus Walleij
2017-01-26 10:16 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdb3L+C+rVB1FPWJ_gGxHPzGAgUFxEBYPTHJQ1_=06y5_g@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).