* [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance
@ 2017-01-24 19:53 Alex Williamson
2017-01-25 1:53 ` Jike Song
2017-01-25 2:24 ` [igvt-g-dev] " Zhenyu Wang
0 siblings, 2 replies; 3+ messages in thread
From: Alex Williamson @ 2017-01-24 19:53 UTC (permalink / raw)
To: zhi.a.wang, zhenyuw
Cc: jani.nikula, jike.song, airlied, intel-gfx, linux-kernel,
dri-devel, igvt-g-dev, daniel.vetter
Per the ABI specification[1], each mdev_supported_types entry should
have an available_instances, with an "s", not available_instance.
[1] Documentation/ABI/testing/sysfs-bus-vfio-mdev
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
This should really be fixed before initial release in v4.10
drivers/gpu/drm/i915/gvt/kvmgt.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
index faaae07..ab1e057 100644
--- a/drivers/gpu/drm/i915/gvt/kvmgt.c
+++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
@@ -230,8 +230,8 @@ static struct intel_vgpu_type *intel_gvt_find_vgpu_type(struct intel_gvt *gvt,
return NULL;
}
-static ssize_t available_instance_show(struct kobject *kobj, struct device *dev,
- char *buf)
+static ssize_t available_instances_show(struct kobject *kobj,
+ struct device *dev, char *buf)
{
struct intel_vgpu_type *type;
unsigned int num = 0;
@@ -269,12 +269,12 @@ static ssize_t description_show(struct kobject *kobj, struct device *dev,
type->fence);
}
-static MDEV_TYPE_ATTR_RO(available_instance);
+static MDEV_TYPE_ATTR_RO(available_instances);
static MDEV_TYPE_ATTR_RO(device_api);
static MDEV_TYPE_ATTR_RO(description);
static struct attribute *type_attrs[] = {
- &mdev_type_attr_available_instance.attr,
+ &mdev_type_attr_available_instances.attr,
&mdev_type_attr_device_api.attr,
&mdev_type_attr_description.attr,
NULL,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance
2017-01-24 19:53 [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance Alex Williamson
@ 2017-01-25 1:53 ` Jike Song
2017-01-25 2:24 ` [igvt-g-dev] " Zhenyu Wang
1 sibling, 0 replies; 3+ messages in thread
From: Jike Song @ 2017-01-25 1:53 UTC (permalink / raw)
To: Alex Williamson
Cc: zhi.a.wang, zhenyuw, jani.nikula, airlied, intel-gfx,
linux-kernel, dri-devel, igvt-g-dev, daniel.vetter
On 01/25/2017 03:53 AM, Alex Williamson wrote:
> Per the ABI specification[1], each mdev_supported_types entry should
> have an available_instances, with an "s", not available_instance.
>
> [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>
> This should really be fixed before initial release in v4.10
Acked-by: Jike Song <jike.song@intel.com>
Thanks for finding this!
--
Thanks,
Jike
>
> drivers/gpu/drm/i915/gvt/kvmgt.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index faaae07..ab1e057 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -230,8 +230,8 @@ static struct intel_vgpu_type *intel_gvt_find_vgpu_type(struct intel_gvt *gvt,
> return NULL;
> }
>
> -static ssize_t available_instance_show(struct kobject *kobj, struct device *dev,
> - char *buf)
> +static ssize_t available_instances_show(struct kobject *kobj,
> + struct device *dev, char *buf)
> {
> struct intel_vgpu_type *type;
> unsigned int num = 0;
> @@ -269,12 +269,12 @@ static ssize_t description_show(struct kobject *kobj, struct device *dev,
> type->fence);
> }
>
> -static MDEV_TYPE_ATTR_RO(available_instance);
> +static MDEV_TYPE_ATTR_RO(available_instances);
> static MDEV_TYPE_ATTR_RO(device_api);
> static MDEV_TYPE_ATTR_RO(description);
>
> static struct attribute *type_attrs[] = {
> - &mdev_type_attr_available_instance.attr,
> + &mdev_type_attr_available_instances.attr,
> &mdev_type_attr_device_api.attr,
> &mdev_type_attr_description.attr,
> NULL,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [igvt-g-dev] [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance
2017-01-24 19:53 [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance Alex Williamson
2017-01-25 1:53 ` Jike Song
@ 2017-01-25 2:24 ` Zhenyu Wang
1 sibling, 0 replies; 3+ messages in thread
From: Zhenyu Wang @ 2017-01-25 2:24 UTC (permalink / raw)
To: Alex Williamson
Cc: zhi.a.wang, zhenyuw, airlied, intel-gfx, igvt-g-dev,
linux-kernel, dri-devel, jani.nikula, daniel.vetter
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On 2017.01.24 12:53:45 -0700, Alex Williamson wrote:
> Per the ABI specification[1], each mdev_supported_types entry should
> have an available_instances, with an "s", not available_instance.
>
> [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>
> This should really be fixed before initial release in v4.10
Will queue this up for 4.10 fixes. Thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-25 2:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 19:53 [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance Alex Williamson
2017-01-25 1:53 ` Jike Song
2017-01-25 2:24 ` [igvt-g-dev] " Zhenyu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).