linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [patch] {1620} net: hns3: add dcb cap flag in init sequence
  2017-01-25  7:26 [patch] {1620} net: hns3: add dcb cap flag in init sequence Kejian Yan
@ 2017-01-25  7:19 ` Yankejian (Hackim Yim)
  2017-01-25 16:24 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: Yankejian (Hackim Yim) @ 2017-01-25  7:19 UTC (permalink / raw)
  To: liguozhu, yisen.zhuang, huangdaode, lipeng321, davem, robh+dt,
	pawel.moll, mark.rutland, ijc+devicetree, galak, catalin.marinas,
	will.deacon
  Cc: devicetree, linux-arm-kernel, linux-kernel, linuxarm

it is misoperation, please ignore. sorry to interrupt you!


On 2017/1/25 15:26, Kejian Yan wrote:
> If enable DCB feature, we need to add the capacity, and the current
> procedure cannot setting the dcb because of no capacity flag and every
> ops interface will implement by the capicity flag is enable.
>
> Signed-off-by: Kejian Yan <yankejian@huawei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 ++++--
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c   | 5 +++++
>  2 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> index 26b9b46..fffe781 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> @@ -314,12 +314,14 @@ static int hclge_configure(struct hclge_dev *hdev)
>  		hdev->tx_sch_mode = HCLGE_FLAG_TC_BASE_SCH_MODE;
>  #ifdef CONFIG_HNS3_DCB
>  		hdev->dcbx_cap = DCB_CAP_DCBX_VER_CEE |
> -			DCB_CAP_DCBX_VER_IEEE;
> +			DCB_CAP_DCBX_VER_IEEE | DCB_CAP_DCBX_HOST;
> +		hdev->flag |= HCLGE_FLAG_DCB_CAPABLE;
>  #endif /* #ifdef CONFIG_HNS3_DCB */
>  	} else {
>  		hdev->tx_sch_mode = HCLGE_FLAG_VNET_BASE_SCH_MODE;
>  #ifdef CONFIG_HNS3_DCB
> -		hdev->dcbx_cap = DCB_CAP_DCBX_VER_IEEE;
> +		hdev->dcbx_cap = DCB_CAP_DCBX_VER_IEEE | DCB_CAP_DCBX_HOST;
> +		hdev->flag |= HCLGE_FLAG_DCB_CAPABLE;
>  #endif /* #ifdef CONFIG_HNS3_DCB */
>  	}
>  
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
> index 903c413..6b00982 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
> @@ -687,6 +687,11 @@ static void hclge_tm_tc_info_init(struct hclge_dev *hdev)
>  	hdev->dcb_info_tmp.num_tc = hdev->dcb_info.num_tc;
>  	memcpy(hdev->dcb_info_tmp.tc_info, hdev->dcb_info.tc_info,
>  	       HNAE3_MAX_TC * sizeof(*hdev->dcb_info.tc_info));
> +
> +	if (hdev->dcb_info.num_tc > 1)
> +		hdev->flag |= HCLGE_FLAG_DCB_ENABLE;
> +	else
> +		hdev->flag &= ~HCLGE_FLAG_DCB_ENABLE;
>  }
>  
>  static void hclge_tm_pg_info_init(struct hclge_dev *hdev)


-- 
MBR,
Yankejian (Hackim Yim)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [patch] {1620} net: hns3: add dcb cap flag in init sequence
@ 2017-01-25  7:26 Kejian Yan
  2017-01-25  7:19 ` Yankejian (Hackim Yim)
  2017-01-25 16:24 ` David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Kejian Yan @ 2017-01-25  7:26 UTC (permalink / raw)
  To: liguozhu, yisen.zhuang, huangdaode, lipeng321, yankejian, davem,
	robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	catalin.marinas, will.deacon
  Cc: devicetree, linux-arm-kernel, linux-kernel, linuxarm

If enable DCB feature, we need to add the capacity, and the current
procedure cannot setting the dcb because of no capacity flag and every
ops interface will implement by the capicity flag is enable.

Signed-off-by: Kejian Yan <yankejian@huawei.com>
---
 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 ++++--
 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c   | 5 +++++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index 26b9b46..fffe781 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -314,12 +314,14 @@ static int hclge_configure(struct hclge_dev *hdev)
 		hdev->tx_sch_mode = HCLGE_FLAG_TC_BASE_SCH_MODE;
 #ifdef CONFIG_HNS3_DCB
 		hdev->dcbx_cap = DCB_CAP_DCBX_VER_CEE |
-			DCB_CAP_DCBX_VER_IEEE;
+			DCB_CAP_DCBX_VER_IEEE | DCB_CAP_DCBX_HOST;
+		hdev->flag |= HCLGE_FLAG_DCB_CAPABLE;
 #endif /* #ifdef CONFIG_HNS3_DCB */
 	} else {
 		hdev->tx_sch_mode = HCLGE_FLAG_VNET_BASE_SCH_MODE;
 #ifdef CONFIG_HNS3_DCB
-		hdev->dcbx_cap = DCB_CAP_DCBX_VER_IEEE;
+		hdev->dcbx_cap = DCB_CAP_DCBX_VER_IEEE | DCB_CAP_DCBX_HOST;
+		hdev->flag |= HCLGE_FLAG_DCB_CAPABLE;
 #endif /* #ifdef CONFIG_HNS3_DCB */
 	}
 
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
index 903c413..6b00982 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
@@ -687,6 +687,11 @@ static void hclge_tm_tc_info_init(struct hclge_dev *hdev)
 	hdev->dcb_info_tmp.num_tc = hdev->dcb_info.num_tc;
 	memcpy(hdev->dcb_info_tmp.tc_info, hdev->dcb_info.tc_info,
 	       HNAE3_MAX_TC * sizeof(*hdev->dcb_info.tc_info));
+
+	if (hdev->dcb_info.num_tc > 1)
+		hdev->flag |= HCLGE_FLAG_DCB_ENABLE;
+	else
+		hdev->flag &= ~HCLGE_FLAG_DCB_ENABLE;
 }
 
 static void hclge_tm_pg_info_init(struct hclge_dev *hdev)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [patch] {1620} net: hns3: add dcb cap flag in init sequence
  2017-01-25  7:26 [patch] {1620} net: hns3: add dcb cap flag in init sequence Kejian Yan
  2017-01-25  7:19 ` Yankejian (Hackim Yim)
@ 2017-01-25 16:24 ` David Miller
  2017-01-26  3:28   ` Yankejian (Hackim Yim)
  1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2017-01-25 16:24 UTC (permalink / raw)
  To: yankejian
  Cc: liguozhu, yisen.zhuang, huangdaode, lipeng321, robh+dt,
	pawel.moll, mark.rutland, ijc+devicetree, galak, catalin.marinas,
	will.deacon, devicetree, linux-arm-kernel, linux-kernel,
	linuxarm


Networking patches must be sent to netdev@vger.kernel.org

Thank you.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] {1620} net: hns3: add dcb cap flag in init sequence
  2017-01-25 16:24 ` David Miller
@ 2017-01-26  3:28   ` Yankejian (Hackim Yim)
  0 siblings, 0 replies; 4+ messages in thread
From: Yankejian (Hackim Yim) @ 2017-01-26  3:28 UTC (permalink / raw)
  To: David Miller
  Cc: liguozhu, yisen.zhuang, huangdaode, lipeng321, robh+dt,
	pawel.moll, mark.rutland, ijc+devicetree, galak, catalin.marinas,
	will.deacon, devicetree, linux-arm-kernel, linux-kernel,
	linuxarm

On 2017/1/26 0:24, David Miller wrote:
> Networking patches must be sent to netdev@vger.kernel.org
>
> Thank you.
>
> .
>

it is misoperation, please ignore. sorry to interrupt you!


-- 
MBR,
Yankejian (Hackim Yim)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-26  3:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-25  7:26 [patch] {1620} net: hns3: add dcb cap flag in init sequence Kejian Yan
2017-01-25  7:19 ` Yankejian (Hackim Yim)
2017-01-25 16:24 ` David Miller
2017-01-26  3:28   ` Yankejian (Hackim Yim)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).