* [PATCH] phy: qcom-ufs: Fix misplaced jump label
@ 2017-01-27 8:10 Vivek Gautam
2017-01-27 8:15 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 3+ messages in thread
From: Vivek Gautam @ 2017-01-27 8:10 UTC (permalink / raw)
To: kishon
Cc: linux-kernel, linux-arm-msm, Vivek Gautam, Subhash Jadavani,
Martin K. Petersen, stable
We want to skip only tx/rx_iface clocks and not ref_clk_src
as well. Fix the jump label accordingly.
Fixes: 300f96771d78 ("phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy")
Cc: Subhash Jadavani <subhashj@codeaurora.org>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: stable@vger.kernel.org
Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
---
Based on linux-phy next.
drivers/phy/phy-qcom-ufs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index c69568b8543d..1aee8723a682 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -189,12 +189,12 @@ int ufs_qcom_phy_init_clks(struct ufs_qcom_phy *phy_common)
if (err)
goto out;
+skip_txrx_clk:
err = ufs_qcom_phy_clk_get(phy_common->dev, "ref_clk_src",
&phy_common->ref_clk_src);
if (err)
goto out;
-skip_txrx_clk:
/*
* "ref_clk_parent" is optional hence don't abort init if it's not
* found.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: qcom-ufs: Fix misplaced jump label
2017-01-27 8:10 [PATCH] phy: qcom-ufs: Fix misplaced jump label Vivek Gautam
@ 2017-01-27 8:15 ` Kishon Vijay Abraham I
2017-01-27 9:04 ` Vivek Gautam
0 siblings, 1 reply; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2017-01-27 8:15 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-kernel, linux-arm-msm, Subhash Jadavani,
Martin K. Petersen, stable
On Friday 27 January 2017 01:40 PM, Vivek Gautam wrote:
> We want to skip only tx/rx_iface clocks and not ref_clk_src
> as well. Fix the jump label accordingly.
>
> Fixes: 300f96771d78 ("phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy")
merged, thanks.
-Kishon
>
> Cc: Subhash Jadavani <subhashj@codeaurora.org>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> ---
>
> Based on linux-phy next.
>
> drivers/phy/phy-qcom-ufs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
> index c69568b8543d..1aee8723a682 100644
> --- a/drivers/phy/phy-qcom-ufs.c
> +++ b/drivers/phy/phy-qcom-ufs.c
> @@ -189,12 +189,12 @@ int ufs_qcom_phy_init_clks(struct ufs_qcom_phy *phy_common)
> if (err)
> goto out;
>
> +skip_txrx_clk:
> err = ufs_qcom_phy_clk_get(phy_common->dev, "ref_clk_src",
> &phy_common->ref_clk_src);
> if (err)
> goto out;
>
> -skip_txrx_clk:
> /*
> * "ref_clk_parent" is optional hence don't abort init if it's not
> * found.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: qcom-ufs: Fix misplaced jump label
2017-01-27 8:15 ` Kishon Vijay Abraham I
@ 2017-01-27 9:04 ` Vivek Gautam
0 siblings, 0 replies; 3+ messages in thread
From: Vivek Gautam @ 2017-01-27 9:04 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: linux-kernel, linux-arm-msm, Subhash Jadavani,
Martin K. Petersen, stable
On 01/27/2017 01:45 PM, Kishon Vijay Abraham I wrote:
>
> On Friday 27 January 2017 01:40 PM, Vivek Gautam wrote:
>> We want to skip only tx/rx_iface clocks and not ref_clk_src
>> as well. Fix the jump label accordingly.
>>
>> Fixes: 300f96771d78 ("phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy")
> merged, thanks.
Thanks Kishon.
>
> -Kishon
>> Cc: Subhash Jadavani <subhashj@codeaurora.org>
>> Cc: Martin K. Petersen <martin.petersen@oracle.com>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>> ---
>>
>> Based on linux-phy next.
>>
>> drivers/phy/phy-qcom-ufs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
>> index c69568b8543d..1aee8723a682 100644
>> --- a/drivers/phy/phy-qcom-ufs.c
>> +++ b/drivers/phy/phy-qcom-ufs.c
>> @@ -189,12 +189,12 @@ int ufs_qcom_phy_init_clks(struct ufs_qcom_phy *phy_common)
>> if (err)
>> goto out;
>>
>> +skip_txrx_clk:
>> err = ufs_qcom_phy_clk_get(phy_common->dev, "ref_clk_src",
>> &phy_common->ref_clk_src);
>> if (err)
>> goto out;
>>
>> -skip_txrx_clk:
>> /*
>> * "ref_clk_parent" is optional hence don't abort init if it's not
>> * found.
>>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-30 22:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-27 8:10 [PATCH] phy: qcom-ufs: Fix misplaced jump label Vivek Gautam
2017-01-27 8:15 ` Kishon Vijay Abraham I
2017-01-27 9:04 ` Vivek Gautam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).