* [PATCH] clk: at91: sam9x60: Don't use audio PLL
@ 2020-01-30 17:47 Codrin Ciubotariu
2020-01-31 10:42 ` Claudiu.Beznea
0 siblings, 1 reply; 3+ messages in thread
From: Codrin Ciubotariu @ 2020-01-30 17:47 UTC (permalink / raw)
To: linux-clk, linux-arm-kernel, linux-kernel
Cc: sboyd, nicolas.ferre, alexandre.belloni, ludovic.desroches,
eugen.hristev, Codrin Ciubotariu
On sam9x60, there is not audio PLL and so I2S and classD have to use one
of the best matching parents for their generated clock.
Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---
drivers/clk/at91/sam9x60.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
index 77398aefeb6d..0aeb44fed9de 100644
--- a/drivers/clk/at91/sam9x60.c
+++ b/drivers/clk/at91/sam9x60.c
@@ -144,11 +144,9 @@ static const struct {
{ .n = "sdmmc1_gclk", .id = 26, .r = { .min = 0, .max = 105000000 }, },
{ .n = "flex11_gclk", .id = 32, },
{ .n = "flex12_gclk", .id = 33, },
- { .n = "i2s_gclk", .id = 34, .r = { .min = 0, .max = 105000000 },
- .pll = true, },
+ { .n = "i2s_gclk", .id = 34, .r = { .min = 0, .max = 105000000 }, },
{ .n = "pit64b_gclk", .id = 37, },
- { .n = "classd_gclk", .id = 42, .r = { .min = 0, .max = 100000000 },
- .pll = true, },
+ { .n = "classd_gclk", .id = 42, .r = { .min = 0, .max = 100000000 }, },
{ .n = "tcb1_gclk", .id = 45, },
{ .n = "dbgu_gclk", .id = 47, },
};
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: at91: sam9x60: Don't use audio PLL
2020-01-30 17:47 [PATCH] clk: at91: sam9x60: Don't use audio PLL Codrin Ciubotariu
@ 2020-01-31 10:42 ` Claudiu.Beznea
2020-01-31 11:51 ` Codrin.Ciubotariu
0 siblings, 1 reply; 3+ messages in thread
From: Claudiu.Beznea @ 2020-01-31 10:42 UTC (permalink / raw)
To: Codrin.Ciubotariu, linux-clk, linux-arm-kernel, linux-kernel
Cc: alexandre.belloni, sboyd, Ludovic.Desroches, Eugen.Hristev
Hi Codrin,
On 30.01.2020 19:47, Codrin Ciubotariu wrote:
> On sam9x60, there is not audio PLL and so I2S and classD have to use one
> of the best matching parents for their generated clock.
>
> Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> drivers/clk/at91/sam9x60.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
> index 77398aefeb6d..0aeb44fed9de 100644
> --- a/drivers/clk/at91/sam9x60.c
> +++ b/drivers/clk/at91/sam9x60.c
> @@ -144,11 +144,9 @@ static const struct {
> { .n = "sdmmc1_gclk", .id = 26, .r = { .min = 0, .max = 105000000 }, },
> { .n = "flex11_gclk", .id = 32, },
> { .n = "flex12_gclk", .id = 33, },
> - { .n = "i2s_gclk", .id = 34, .r = { .min = 0, .max = 105000000 },
> - .pll = true, },
> + { .n = "i2s_gclk", .id = 34, .r = { .min = 0, .max = 105000000 }, },
> { .n = "pit64b_gclk", .id = 37, },
> - { .n = "classd_gclk", .id = 42, .r = { .min = 0, .max = 100000000 },
> - .pll = true, },
> + { .n = "classd_gclk", .id = 42, .r = { .min = 0, .max = 100000000 }, },
> { .n = "tcb1_gclk", .id = 45, },
> { .n = "dbgu_gclk", .id = 47, },
> };
Please remove also the pll member of:
static const struct {
char *n;
u8 id;
struct clk_range r;
bool pll;
}
> --
> 2.20.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: at91: sam9x60: Don't use audio PLL
2020-01-31 10:42 ` Claudiu.Beznea
@ 2020-01-31 11:51 ` Codrin.Ciubotariu
0 siblings, 0 replies; 3+ messages in thread
From: Codrin.Ciubotariu @ 2020-01-31 11:51 UTC (permalink / raw)
To: Claudiu.Beznea, linux-clk, linux-arm-kernel, linux-kernel
Cc: alexandre.belloni, sboyd, Ludovic.Desroches, Eugen.Hristev
On 31.01.2020 12:42, Claudiu Beznea - M18063 wrote:
> Hi Codrin,
>
> On 30.01.2020 19:47, Codrin Ciubotariu wrote:
>> On sam9x60, there is not audio PLL and so I2S and classD have to use one
>> of the best matching parents for their generated clock.
>>
>> Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
>> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>> ---
>> drivers/clk/at91/sam9x60.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
>> index 77398aefeb6d..0aeb44fed9de 100644
>> --- a/drivers/clk/at91/sam9x60.c
>> +++ b/drivers/clk/at91/sam9x60.c
>> @@ -144,11 +144,9 @@ static const struct {
>> { .n = "sdmmc1_gclk", .id = 26, .r = { .min = 0, .max = 105000000 }, },
>> { .n = "flex11_gclk", .id = 32, },
>> { .n = "flex12_gclk", .id = 33, },
>> - { .n = "i2s_gclk", .id = 34, .r = { .min = 0, .max = 105000000 },
>> - .pll = true, },
>> + { .n = "i2s_gclk", .id = 34, .r = { .min = 0, .max = 105000000 }, },
>> { .n = "pit64b_gclk", .id = 37, },
>> - { .n = "classd_gclk", .id = 42, .r = { .min = 0, .max = 100000000 },
>> - .pll = true, },
>> + { .n = "classd_gclk", .id = 42, .r = { .min = 0, .max = 100000000 }, },
>> { .n = "tcb1_gclk", .id = 45, },
>> { .n = "dbgu_gclk", .id = 47, },
>> };
>
> Please remove also the pll member of:
>
> static const struct {
> char *n;
> u8 id;
> struct clk_range r;
> bool pll;
> }
Sure, will send v2.
Thanks and best regards,
Codrin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-31 11:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-30 17:47 [PATCH] clk: at91: sam9x60: Don't use audio PLL Codrin Ciubotariu
2020-01-31 10:42 ` Claudiu.Beznea
2020-01-31 11:51 ` Codrin.Ciubotariu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).