From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Hyun Kwon <hyun.kwon@xilinx.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] drm: xlnx: fix build warning & errors when DMADEVICES is not set
Date: Fri, 4 Sep 2020 11:29:56 -0700 [thread overview]
Message-ID: <58bb811e-7ca5-10e9-fcab-39fd5bdc857d@infradead.org> (raw)
In-Reply-To: <1f7bdabb-e28b-2cc1-5fbd-92c381299ba9@infradead.org>
On 9/3/20 9:41 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig warnings & build errors caused by DRM_ZYNQMP_DPSUB.
>
> Any driver that selects DMA_ENGINE should make sure that
> DMADEVICES is already enabled.
> As is, this causes build errors in many other drivers.
>
> See https://lore.kernel.org/lkml/202009020239.oUPh82Xc%25lkp@intel.com/
> for the numerous build errors.
>
> WARNING: unmet direct dependencies detected for DMA_ENGINE
> Depends on [n]: DMADEVICES [=n]
> Selected by [y]:
> - DRM_ZYNQMP_DPSUB [=y] && HAS_IOMEM [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && COMMON_CLK [=y] && DRM [=y] && OF [=y]
>
Sorry, this is a duplicate of a patch that Laurent has already posted
so my patch isn't needed.
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/xlnx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200903.orig/drivers/gpu/drm/xlnx/Kconfig
> +++ linux-next-20200903/drivers/gpu/drm/xlnx/Kconfig
> @@ -2,6 +2,7 @@ config DRM_ZYNQMP_DPSUB
> tristate "ZynqMP DisplayPort Controller Driver"
> depends on ARCH_ZYNQMP || COMPILE_TEST
> depends on COMMON_CLK && DRM && OF
> + depends on DMADEVICES
> select DMA_ENGINE
> select DRM_GEM_CMA_HELPER
> select DRM_KMS_CMA_HELPER
>
--
~Randy
prev parent reply other threads:[~2020-09-04 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 4:41 [PATCH] drm: xlnx: fix build warning & errors when DMADEVICES is not set Randy Dunlap
2020-09-04 18:29 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58bb811e-7ca5-10e9-fcab-39fd5bdc857d@infradead.org \
--to=rdunlap@infradead.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hyun.kwon@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).