* [PATCH] drm: xlnx: fix build warning & errors when DMADEVICES is not set
@ 2020-09-04 4:41 Randy Dunlap
2020-09-04 18:29 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-09-04 4:41 UTC (permalink / raw)
To: LKML, dri-devel, Hyun Kwon, Laurent Pinchart; +Cc: kernel test robot
From: Randy Dunlap <rdunlap@infradead.org>
Fix kconfig warnings & build errors caused by DRM_ZYNQMP_DPSUB.
Any driver that selects DMA_ENGINE should make sure that
DMADEVICES is already enabled.
As is, this causes build errors in many other drivers.
See https://lore.kernel.org/lkml/202009020239.oUPh82Xc%25lkp@intel.com/
for the numerous build errors.
WARNING: unmet direct dependencies detected for DMA_ENGINE
Depends on [n]: DMADEVICES [=n]
Selected by [y]:
- DRM_ZYNQMP_DPSUB [=y] && HAS_IOMEM [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && COMMON_CLK [=y] && DRM [=y] && OF [=y]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/xlnx/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20200903.orig/drivers/gpu/drm/xlnx/Kconfig
+++ linux-next-20200903/drivers/gpu/drm/xlnx/Kconfig
@@ -2,6 +2,7 @@ config DRM_ZYNQMP_DPSUB
tristate "ZynqMP DisplayPort Controller Driver"
depends on ARCH_ZYNQMP || COMPILE_TEST
depends on COMMON_CLK && DRM && OF
+ depends on DMADEVICES
select DMA_ENGINE
select DRM_GEM_CMA_HELPER
select DRM_KMS_CMA_HELPER
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: xlnx: fix build warning & errors when DMADEVICES is not set
2020-09-04 4:41 [PATCH] drm: xlnx: fix build warning & errors when DMADEVICES is not set Randy Dunlap
@ 2020-09-04 18:29 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2020-09-04 18:29 UTC (permalink / raw)
To: LKML, dri-devel, Hyun Kwon, Laurent Pinchart; +Cc: kernel test robot
On 9/3/20 9:41 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig warnings & build errors caused by DRM_ZYNQMP_DPSUB.
>
> Any driver that selects DMA_ENGINE should make sure that
> DMADEVICES is already enabled.
> As is, this causes build errors in many other drivers.
>
> See https://lore.kernel.org/lkml/202009020239.oUPh82Xc%25lkp@intel.com/
> for the numerous build errors.
>
> WARNING: unmet direct dependencies detected for DMA_ENGINE
> Depends on [n]: DMADEVICES [=n]
> Selected by [y]:
> - DRM_ZYNQMP_DPSUB [=y] && HAS_IOMEM [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && COMMON_CLK [=y] && DRM [=y] && OF [=y]
>
Sorry, this is a duplicate of a patch that Laurent has already posted
so my patch isn't needed.
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/xlnx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200903.orig/drivers/gpu/drm/xlnx/Kconfig
> +++ linux-next-20200903/drivers/gpu/drm/xlnx/Kconfig
> @@ -2,6 +2,7 @@ config DRM_ZYNQMP_DPSUB
> tristate "ZynqMP DisplayPort Controller Driver"
> depends on ARCH_ZYNQMP || COMPILE_TEST
> depends on COMMON_CLK && DRM && OF
> + depends on DMADEVICES
> select DMA_ENGINE
> select DRM_GEM_CMA_HELPER
> select DRM_KMS_CMA_HELPER
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-04 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-04 4:41 [PATCH] drm: xlnx: fix build warning & errors when DMADEVICES is not set Randy Dunlap
2020-09-04 18:29 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).