From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: RFC: Compact Flash True IDE Mode Driver
Date: Mon, 13 Feb 2006 17:53:11 +0100 [thread overview]
Message-ID: <58cb370e0602130853s4ce767c6j57337a9587cc2963@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0602131020370.30316-100000@gate.crashing.org>
On 2/13/06, Kumar Gala <galak@kernel.crashing.org> wrote:
> > > +static void cfide_outsl(unsigned long port, void *addr, u32 count)
> > > +{
> > > + panic("outsl unsupported");
> > > +}
> >
> > This will panic as soon as somebody tries to enable 32-bit I/O
> > using hdparm. Please add ide_hwif_t.no_io_32bit flag and teach
> > ide-disk.c:ide_disk_setup() about it (separate patch).
>
> I'm not sure I follow this, can you expand.
Do "hdparm -c 2 /dev/hdx" first and then read/write to the device
and you should see it. :)
We need to make "hdparm -c 2" (and "hdparm -c 3") unsupported
(see how "io_32bit" setting is handled in ide_add_generic_settings()
and how it can be read-only or read-write setting depending on the
value of drive->no_io_32bit).
To do this we need to set drive->no_io_32bit to 1 (see how
ide_disk_setup() handles it). Unfortunately 32-bit I/O capability
is based on capabilities of both host and device so we have to
add new flag hwif->no_io_32bit to indicate that host doesn't
support 32-bit I/O.
> > > +static ide_hwif_t *cfide_locate_hwif(void __iomem * base, void __iomem * ctrl,
> > > + unsigned int sz, int irq)
> >
> > __devinit
> >
> > > +{
> > > + unsigned long port = (unsigned long)base;
> > > + ide_hwif_t *hwif;
> > > + int index, i;
> > > +
> > > + for (index = 0; index < MAX_HWIFS; ++index) {
> > > + hwif = ide_hwifs + index;
> > > + if (hwif->io_ports[IDE_DATA_OFFSET] == port)
> > > + goto found;
> > > + }
> > > +
> > > + for (index = 0; index < MAX_HWIFS; ++index) {
> > > + hwif = ide_hwifs + index;
> > > + if (hwif->io_ports[IDE_DATA_OFFSET] == 0)
> > > + goto found;
> > > + }
> > > +
> > > + return NULL;
> >
> > This is the same as in icside.c/rapide.c,
> > it really should be generic helper (separate patch)
>
> Suggesitions, on where that should live, ide-probe.c?
ide.c, no rush for this one as I have patch ready
(only needs to find it... sigh...)
> > Otherwise driver looks pretty decent and with the above changes
> > it gets my ACK. Additional enhancements as suggested by Ben
> > would be nice but obviously they are not needed for a start
>
> Everything else makes sense and I'll make those changes, plus some based
> on Ben's comments. If you can let me know about the two questions
> (expanding on ide_hwif_t.no_io_32bit and where to but a generic version of
> cfide_locate_hwif).
Thanks,
Bartlomiej
next prev parent reply other threads:[~2006-02-13 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-01 7:19 RFC: Compact Flash True IDE Mode Driver Kumar Gala
2006-02-06 4:13 ` Benjamin Herrenschmidt
2006-02-13 10:35 ` Bartlomiej Zolnierkiewicz
2006-02-13 16:30 ` Kumar Gala
2006-02-13 16:53 ` Bartlomiej Zolnierkiewicz [this message]
2006-02-13 19:45 ` Kumar Gala
2006-02-13 20:21 ` Bartlomiej Zolnierkiewicz
2006-02-13 22:13 ` Kumar Gala
2006-02-13 22:35 ` Bartlomiej Zolnierkiewicz
2006-02-14 14:57 ` Kumar Gala
2006-02-14 15:57 ` Bartlomiej Zolnierkiewicz
2006-02-14 16:07 ` Kumar Gala
2006-02-14 16:24 ` Bartlomiej Zolnierkiewicz
2006-02-14 16:58 ` Alan Cox
2006-02-14 16:48 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0602130853s4ce767c6j57337a9587cc2963@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).