From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: RFC: Compact Flash True IDE Mode Driver
Date: Tue, 14 Feb 2006 16:57:37 +0100 [thread overview]
Message-ID: <58cb370e0602140757r5b265f25wc9f1f2e44d5f075c@mail.gmail.com> (raw)
In-Reply-To: <A9DB3731-BF2F-4C52-BFBB-7E247E646FA6@kernel.crashing.org>
On 2/14/06, Kumar Gala <galak@kernel.crashing.org> wrote:
> >> Now I'm confused. If I understand the code, what I want is for the
> >> "io_32bit" setting to have its RW field set to SETTING_READ, such
> >> that drive->no_io_32bit can NOT be changed. Additionally, I want it
> >> set to 1 if hwif->no_io_32bit is 1.
> >
> > Yes.
> >
> >> Are you saying that at the end of probe_hwif() I should iterate over
> >> the drives for that hwif and set drive->no_io_32bit to 1 if hwif-
> >>> no_io_32bit is 1? If so, can I do this in the last loop that
> >> already exists that iterates over the drives?
> >
> > Well, no - this loop is for tuning and is already over-complicated.
> >
> >> Will I not also want to test hwif->no_io_32bit in idedisk_setup() to
> >> ensure that it can only set driver->no_io_32bit to 0 if hwif-
> >>> no_io32bit is 0?
> >
> > No, you want to move this code to ide-probe.c because of the
> > reason given in my last mail: setting drive->no_io_32bit in ide-disk
> > is too late w.r.t. ide_add_generic_settings():
> >
> > init_gendisk()->hwif_init()->ide_add_generic_settings()
> >
> > so drive->no_io_32bit flag needs to be set earlier
> > (probe_hwif() is OK).
>
> Will drive->id->dword_io be valid by the end of probe_hwif()?
Yes.
> > And yes, this IDE stuff is complicated... :)
>
> That it is ;)
>
> - kumar
next prev parent reply other threads:[~2006-02-14 15:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-01 7:19 RFC: Compact Flash True IDE Mode Driver Kumar Gala
2006-02-06 4:13 ` Benjamin Herrenschmidt
2006-02-13 10:35 ` Bartlomiej Zolnierkiewicz
2006-02-13 16:30 ` Kumar Gala
2006-02-13 16:53 ` Bartlomiej Zolnierkiewicz
2006-02-13 19:45 ` Kumar Gala
2006-02-13 20:21 ` Bartlomiej Zolnierkiewicz
2006-02-13 22:13 ` Kumar Gala
2006-02-13 22:35 ` Bartlomiej Zolnierkiewicz
2006-02-14 14:57 ` Kumar Gala
2006-02-14 15:57 ` Bartlomiej Zolnierkiewicz [this message]
2006-02-14 16:07 ` Kumar Gala
2006-02-14 16:24 ` Bartlomiej Zolnierkiewicz
2006-02-14 16:58 ` Alan Cox
2006-02-14 16:48 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0602140757r5b265f25wc9f1f2e44d5f075c@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).