From: "Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>
To: "Sergei Shtylylov" <sshtylyov@ru.mvista.com>
Cc: "Adrian Bunk" <bunk@stusta.de>,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [2.6 patch] always enable CONFIG_PDC202XX_FORCE
Date: Mon, 27 Mar 2006 16:40:20 +0200 [thread overview]
Message-ID: <58cb370e0603270640v7c6070a9gb7dbd2aa5fcbbf98@mail.gmail.com> (raw)
In-Reply-To: <4427F5E7.1000108@ru.mvista.com>
On 3/27/06, Sergei Shtylylov <sshtylyov@ru.mvista.com> wrote:
> Hello.
>
> Adrian Bunk wrote:
>
> > This patch removes the CONFIG_PDC202XX_FORCE=n case.
>
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> > ---
> >
> > This patch was already sent on:
> > - 14 Jan 2006
> >
> > drivers/ide/Kconfig | 7 -------
> > drivers/ide/pci/pdc202xx_new.c | 6 ------
> > drivers/ide/pci/pdc202xx_old.c | 15 ---------------
> > 3 files changed, 28 deletions(-)
>
> [skipped]
>
> > --- linux-2.6.15-mm4-full/drivers/ide/pci/pdc202xx_old.c.old 2006-01-14 20:44:01.000000000 +0100
> > +++ linux-2.6.15-mm4-full/drivers/ide/pci/pdc202xx_old.c 2006-01-14 20:44:21.000000000 +0100
> > @@ -786,9 +786,6 @@
> > .init_dma = init_dma_pdc202xx,
> > .channels = 2,
> > .autodma = AUTODMA,
> > -#ifndef CONFIG_PDC202XX_FORCE
> > - .enablebits = {{0x50,0x02,0x02}, {0x50,0x04,0x04}},
> > -#endif
> > .bootable = OFF_BOARD,
> > .extra = 16,
> > },{ /* 1 */
> > @@ -799,9 +796,6 @@
> > .init_dma = init_dma_pdc202xx,
> > .channels = 2,
> > .autodma = AUTODMA,
> > -#ifndef CONFIG_PDC202XX_FORCE
> > - .enablebits = {{0x50,0x02,0x02}, {0x50,0x04,0x04}},
> > -#endif
> > .bootable = OFF_BOARD,
> > .extra = 48,
> > .flags = IDEPCI_FLAG_FORCE_PDC,
>
> A late question: wasn't that IDEPCI_FLAG_FORCE_PDC flag there for the same
> purpose -- to bypass enablebits check? Wasn't it enough?
It was for the same purpose but it wasn't enough,
now this flag can die...
Bartlomiej
next prev parent reply other threads:[~2006-03-27 14:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 17:12 [2.6 patch] always enable CONFIG_PDC202XX_FORCE Adrian Bunk
2006-03-27 14:25 ` Sergei Shtylylov
2006-03-27 14:40 ` Bartlomiej Zolnierkiewicz [this message]
2006-04-07 0:31 ` [2.6 patch] remove the obsolete IDEPCI_FLAG_FORCE_PDC Adrian Bunk
2006-04-07 11:41 ` Bartlomiej Zolnierkiewicz
-- strict thread matches above, loose matches on Subject: below --
2006-01-28 23:04 [2.6 patch] always enable CONFIG_PDC202XX_FORCE Adrian Bunk
2006-01-14 15:21 [2.6 patch] Fix PDC202XX_FORCE kconfig selection Adrian Bunk
2006-01-14 16:13 ` Alan Cox
2006-01-14 17:47 ` Bartlomiej Zolnierkiewicz
2006-01-14 19:55 ` [2.6 patch] always enable CONFIG_PDC202XX_FORCE Adrian Bunk
2006-01-15 1:07 ` Alan Cox
2006-01-15 1:50 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0603270640v7c6070a9gb7dbd2aa5fcbbf98@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@stusta.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).