* [PATCH] cpufreq: OMAP: Fix compilation error 'r & ret undeclared'
@ 2013-11-13 10:09 Viresh Kumar
2013-11-16 1:12 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Viresh Kumar @ 2013-11-13 10:09 UTC (permalink / raw)
To: rjw
Cc: linaro-kernel, patches, cpufreq, linux-pm, linux-kernel,
santosh.shilimkar, Viresh Kumar
With a recent change "d4019f0 cpufreq: move freq change notifications to cpufreq
core" few variables (r & ret) are removed by mistake and hence these warnings:
drivers/cpufreq/omap-cpufreq.c: In function omap_target:
drivers/cpufreq/omap-cpufreq.c:64:2: error: ret undeclared (first use in this function)
drivers/cpufreq/omap-cpufreq.c:64:2: note: each undeclared identifier is reported only once for each function it appears in
drivers/cpufreq/omap-cpufreq.c:94:3: error: r undeclared (first use in this function)
drivers/cpufreq/omap-cpufreq.c:116:1: warning: control reaches end of non-void function [-Wreturn-type]
Lets fix them by declaring those variables again.
Reported-by: Sebastian Capella <sebastian.capella@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/omap-cpufreq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c
index be6d143..a0acd0b 100644
--- a/drivers/cpufreq/omap-cpufreq.c
+++ b/drivers/cpufreq/omap-cpufreq.c
@@ -53,6 +53,7 @@ static unsigned int omap_getspeed(unsigned int cpu)
static int omap_target(struct cpufreq_policy *policy, unsigned int index)
{
+ int r, ret;
struct dev_pm_opp *opp;
unsigned long freq, volt = 0, volt_old = 0, tol = 0;
unsigned int old_freq, new_freq;
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: OMAP: Fix compilation error 'r & ret undeclared'
2013-11-13 10:09 [PATCH] cpufreq: OMAP: Fix compilation error 'r & ret undeclared' Viresh Kumar
@ 2013-11-16 1:12 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2013-11-16 1:12 UTC (permalink / raw)
To: Viresh Kumar
Cc: linaro-kernel, patches, cpufreq, linux-pm, linux-kernel,
santosh.shilimkar
On Wednesday, November 13, 2013 03:39:23 PM Viresh Kumar wrote:
> With a recent change "d4019f0 cpufreq: move freq change notifications to cpufreq
> core" few variables (r & ret) are removed by mistake and hence these warnings:
>
> drivers/cpufreq/omap-cpufreq.c: In function omap_target:
> drivers/cpufreq/omap-cpufreq.c:64:2: error: ret undeclared (first use in this function)
> drivers/cpufreq/omap-cpufreq.c:64:2: note: each undeclared identifier is reported only once for each function it appears in
> drivers/cpufreq/omap-cpufreq.c:94:3: error: r undeclared (first use in this function)
> drivers/cpufreq/omap-cpufreq.c:116:1: warning: control reaches end of non-void function [-Wreturn-type]
>
> Lets fix them by declaring those variables again.
>
> Reported-by: Sebastian Capella <sebastian.capella@linaro.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Queued up for the next PM pull request, thanks!
> ---
> drivers/cpufreq/omap-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c
> index be6d143..a0acd0b 100644
> --- a/drivers/cpufreq/omap-cpufreq.c
> +++ b/drivers/cpufreq/omap-cpufreq.c
> @@ -53,6 +53,7 @@ static unsigned int omap_getspeed(unsigned int cpu)
>
> static int omap_target(struct cpufreq_policy *policy, unsigned int index)
> {
> + int r, ret;
> struct dev_pm_opp *opp;
> unsigned long freq, volt = 0, volt_old = 0, tol = 0;
> unsigned int old_freq, new_freq;
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-16 0:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-13 10:09 [PATCH] cpufreq: OMAP: Fix compilation error 'r & ret undeclared' Viresh Kumar
2013-11-16 1:12 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).