From: Chanwoo Choi <cw00.choi@samsung.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Benson Leung <bleung@chromium.org>,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
Date: Tue, 23 May 2017 18:58:12 +0900 [thread overview]
Message-ID: <592407B4.5040108@samsung.com> (raw)
In-Reply-To: <3f4c4b85-e9db-0531-e3da-2e671a8fa750@collabora.com>
Hi,
On 2017년 05월 23일 18:52, Enric Balletbo i Serra wrote:
>
>
> On 23/05/17 11:46, Chanwoo Choi wrote:
>> Hi Enric,
>>
>> On 2017년 04월 20일 19:16, Enric Balletbo i Serra wrote:
>>> On 05/04/17 03:21, Chanwoo Choi wrote:
>>>> Hi Enric,
>>>>
>>>> On 2017년 03월 02일 16:29, Chanwoo Choi wrote:
>>>>> Hi,
>>>>>
>>>>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote:
>>>>>> From: Benson Leung <bleung@chromium.org>
>>>>>>
>>>>>> This is the driver for the USB Type C cable detection mechanism
>>>>>> built into the ChromeOS Embedded Controller on systems that
>>>>>> have USB Type-C ports.
>>>>>>
>>>>>> At present, this allows for the presence of display out, but in
>>>>>> future, it may also be used to notify host and device type cables
>>>>>> and the presence of power.
>>>>>>
>>>>>> Signed-off-by: Benson Leung <bleung@chromium.org>
>>>>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>>>>> ---
>>>>>> Changes since v1:
>>>>>> Requested by Chanwoo Choi
>>>>>> - Rename files changing _ for -
>>>>>> - Remove the unneeded blank line on bottom of header.
>>>>>> - Remove kobject.h and cros_ec_commands.h includes.
>>>>>> - Remove the debug message as is not necessary.
>>>>>> - Use the tab for indentation instead of space for if sentence.
>>>>>> - Define each variable on different lines when the variables should be
>>>>>> initialized.
>>>>>> - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
>>>>>> - Add one blank line to split out between state and property setting.
>>>>>> - Add the author information (header and module)
>>>>>>
>>>>>> Enric Balletbo
>>>>>> - As Rob suggested to rename the compatible name to something indicating that
>>>>>> is USB Type C related I also renamed the file names, extcon-cros-ec ->
>>>>>> extcon-usbc-cros-ec, I think it's more clear.
>>>>>>
>>>>>> drivers/extcon/Kconfig | 7 +
>>>>>> drivers/extcon/Makefile | 1 +
>>>>>> drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++
>>>>>> include/linux/mfd/cros_ec_commands.h | 75 +++++++
>>>>>> 4 files changed, 498 insertions(+)
>>>>>> create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c
>>>>>>
>>>>>
>>>>> Looks good to me.
>>>>> Acked-by: Chanwoo Choi <cw00.chio@samsung.com>
>>>>>
>>>>> I think this patch should be handled with patches[1].
>>>>> [1] https://lkml.org/lkml/2017/2/14/655
>>>>>
>>>>> I think that one maintainer among following subsystems
>>>>> (mfd, chrome h/w platform, rtc and extcon)
>>>>> will apply their git repository, and then one maintainer
>>>>> will send the pull request of immutable branch for these patches.
>>>>>
>>>>
>>>> As I mentioned, these patch should be handled with related patches[1].
>>>> [1] https://lkml.org/lkml/2017/2/14/655
>>>>
>>>> So, I can't apply these patch on extcon git because there is a merge conflict
>>>> and we should handle these patches with immutable branch between subsystem maintainer.
>>>>
>>>> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1,
>>>> please take care of these patches.
>>>>
>>>
>>> CC'ied : Olof Johansson
>>>
>>> Olof, Benson,
>>>
>>> Could at least the following patch in this series [1] picked as soon as possible
>>> if it's ok.
>>>
>>> 9630769 New [01/13] mfd: cros_ec: Add helper for event notifier
>>>
>>> This specific patch is blocking this and others like the rtc-cros-ec to land and
>>> the series were send some time ago without received bad feedback.
>>>
>>> [1] https://lkml.org/lkml/2017/3/17/321
>>>
>>> Many thanks,
>>> Enric
>>
>> Maybe, you better to resend these patches based on v4.12-rcX.
>>
>
> I did a week ago :) The patches were rebased on top of current linux-next,
> waiting for the maintainers, hope will be accepted soon so we can unblock this
> patch and the rtc patches.
>
> https://lkml.org/lkml/2017/5/16/478
>
OK. This patch must need the immutable branch.
I expect that some maintainer will make the immutable branch
and then send pull request to other maintainer related to them.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2017-05-23 9:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 11:19 [PATCH v2 0/2] Add support for cros-ec-extcon driver Enric Balletbo i Serra
2017-03-01 11:19 ` [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out Enric Balletbo i Serra
2017-03-02 7:29 ` Chanwoo Choi
2017-04-05 1:21 ` Chanwoo Choi
2017-04-10 14:52 ` Enric Balletbo i Serra
2017-04-24 11:58 ` Lee Jones
2017-04-20 10:16 ` Enric Balletbo i Serra
2017-05-23 9:46 ` Chanwoo Choi
2017-05-23 9:52 ` Enric Balletbo i Serra
2017-05-23 9:58 ` Chanwoo Choi [this message]
2017-05-23 22:24 ` Benson Leung
2017-07-12 10:28 ` Enric Balletbo Serra
2017-07-13 10:26 ` Chanwoo Choi
2017-07-13 10:45 ` Enric Balletbo Serra
2017-07-16 6:01 ` Chanwoo Choi
2017-03-14 17:02 ` Lee Jones
2017-03-01 11:19 ` [PATCH v2 2/2] dt-bindings: extcon: Add support for cros-ec device Enric Balletbo i Serra
2017-03-03 6:43 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592407B4.5040108@samsung.com \
--to=cw00.choi@samsung.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).