From: Nagarjuna Kristam <nkristam@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: <balbi@kernel.org>, <gregkh@linuxfoundation.org>,
<jonathanh@nvidia.com>, <mark.rutland@arm.com>,
<robh+dt@kernel.org>, <kishon@ti.com>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/18] dt-bindings: phy: tegra-xusb: Add usb-role-switch
Date: Mon, 9 Dec 2019 10:15:29 +0530 [thread overview]
Message-ID: <59527c41-7388-b6ae-f49e-0f8eb1407063@nvidia.com> (raw)
In-Reply-To: <20191206144905.GC2085684@ulmo>
> On 06-12-2019 20:19, Thierry Reding wrote:
>
> On Fri, Dec 06, 2019 at 04:20:04PM +0530, Nagarjuna Kristam wrote:
>> Add usb-role-switch property for Tegra210 and Tegra186 platforms. This
>> entry is used by XUSB pad controller driver to register for role changes
>> for OTG/Peripheral capable USB 2 ports.
>>
>> Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com>
>> ---
>> Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
>> index 9fb682e..0f19ed6 100644
>> --- a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
>> +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
>> @@ -179,6 +179,10 @@ Optional properties:
>> is internal. In the absence of this property the port is considered to be
>> external.
>> - vbus-supply: phandle to a regulator supplying the VBUS voltage.
>> +- usb-role-switch: boolean property to indicate use of USB Role Switch.
> That first sentence here seems a bit useless and vague. It doesn't
> really convey anything other than the name already does. Perhaps
> something like:
>
> Boolean property to indicate that the port support OTG. If
> present, the port supports switching between USB host and
> peripheral roles.
>
Will update this accordingly.
>> + This property is MUST for OTG,Peripheral capable USB 2 ports. Connector
> If this is mandatory, why not add it to the list of required properties?
> I guess since it's only mandatory for ports that support OTG, perhaps we
> could add a section "Required properties for OTG capable ports:" or
> something like that? Then you can also omit the second sentence in the
> description.
>
Will add section "Required properties for OTG/Peripheral capable ports:" under ports
and add usb-role-switch there.
>> + should be added as subnode, see connector.txt. vbus-gpio in connector is
> There's no file called "connector.txt". Are you referring to
>
> Documentation/devicetree/bindings/connector/usb-connector.txt
>
> ? Also, that file calls the property "vbus-gpios" and lists it as
> optional. What would happen if we don't specify it? Doesn't that just
> mean that we can't support role detection?
>
After going through other bindings found usb/usb-conn-gpio.txt is the one that should
be referred. Will update accordingly. All details on gpios are documented clearly
in usb/usb-conn-gpio.txt.
>> + Mandatory.
> "mandatory"
>
> Thierry
>
>>
Will update.
Thanks,
Nagarjuna
>> ULPI ports:
>> -----------
>> --
>> 2.7.4
>>
next prev parent reply other threads:[~2019-12-09 4:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 10:50 [PATCH 00/18] Tegra XUSB OTG support Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 01/18] dt-bindings: phy: tegra-xusb: Add usb-role-switch Nagarjuna Kristam
2019-12-06 14:49 ` Thierry Reding
2019-12-09 4:45 ` Nagarjuna Kristam [this message]
2019-12-06 10:50 ` [PATCH 02/18] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding Nagarjuna Kristam
2019-12-13 18:45 ` Rob Herring
2019-12-16 6:30 ` Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 03/18] phy: tegra: xusb: Add usb-role-switch support Nagarjuna Kristam
2019-12-06 14:54 ` Thierry Reding
2019-12-10 3:52 ` Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 04/18] phy: tegra: xusb: Add usb-phy support Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 05/18] phy: tegra: xusb: Add support to get companion USB 3 port Nagarjuna Kristam
2019-12-06 14:57 ` Thierry Reding
2019-12-09 6:27 ` Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 06/18] phy: tegra: xusb: Add set_mode support for USB 2 phy on Tegra210 Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 07/18] phy: tegra: xusb: Add set_mode support for utmi phy on Tegra186 Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 08/18] usb: xhci-tegra: Add OTG support Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 09/18] usb: gadget: tegra-xudc: Remove usb-role-switch support Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 10/18] usb: gadget: tegra-xudc: Add usb-phy support Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 11/18] usb: gadget: tegra-xudc: use phy_set_mode to set/unset device mode Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 12/18] usb: gadget: tegra-xudc: support multiple device modes Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 13/18] arm64: tegra: update OTG port entries for jetson-tx1 Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 14/18] arm64: tegra: update OTG port entries for jetson-tx2 Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 15/18] arm64: tegra: Add xudc node for Tegra210 Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 16/18] arm64: tegra: Enable xudc on Jetson TX1 Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 17/18] arm64: tegra: Add xudc node for Tegra186 Nagarjuna Kristam
2019-12-06 10:50 ` [PATCH 18/18] arm64: tegra: Enable xudc node on Jetson TX2 Nagarjuna Kristam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59527c41-7388-b6ae-f49e-0f8eb1407063@nvidia.com \
--to=nkristam@nvidia.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).