* [PATCH] x86: xen: remove unnecessary variable in xen_foreach_remap_area()
@ 2017-06-23 22:01 Gustavo A. R. Silva
2017-06-26 11:59 ` Juergen Groß
2017-07-03 11:28 ` Juergen Gross
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-06-23 22:01 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86
Cc: xen-devel, linux-kernel, Gustavo A. R. Silva
Remove unnecessary variable mfn in function xen_foreach_remap_area() and,
refactor the code.
Variable mfn at line 518:mfn = xen_remap_buf.mfns[i];
is only being used to store a value to be passed as
an argument to the xen_update_mem_tables() function.
This value can be passed directly, which makes variable
mfn unnecessary. Also, value assigned to variable mfn
at line 534:mfn = xen_remap_mfn; is never used.
Addresses-Coverity-ID: 1260110
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
arch/x86/xen/setup.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index a5bf7c4..c810463 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -499,7 +499,7 @@ static unsigned long __init xen_foreach_remap_area(unsigned long nr_pages,
void __init xen_remap_memory(void)
{
unsigned long buf = (unsigned long)&xen_remap_buf;
- unsigned long mfn_save, mfn, pfn;
+ unsigned long mfn_save, pfn;
unsigned long remapped = 0;
unsigned int i;
unsigned long pfn_s = ~0UL;
@@ -515,8 +515,7 @@ void __init xen_remap_memory(void)
pfn = xen_remap_buf.target_pfn;
for (i = 0; i < xen_remap_buf.size; i++) {
- mfn = xen_remap_buf.mfns[i];
- xen_update_mem_tables(pfn, mfn);
+ xen_update_mem_tables(pfn, xen_remap_buf.mfns[i]);
remapped++;
pfn++;
}
@@ -530,8 +529,6 @@ void __init xen_remap_memory(void)
pfn_s = xen_remap_buf.target_pfn;
len = xen_remap_buf.size;
}
-
- mfn = xen_remap_mfn;
xen_remap_mfn = xen_remap_buf.next_area_mfn;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: xen: remove unnecessary variable in xen_foreach_remap_area()
2017-06-23 22:01 [PATCH] x86: xen: remove unnecessary variable in xen_foreach_remap_area() Gustavo A. R. Silva
@ 2017-06-26 11:59 ` Juergen Groß
2017-07-03 11:28 ` Juergen Gross
1 sibling, 0 replies; 3+ messages in thread
From: Juergen Groß @ 2017-06-26 11:59 UTC (permalink / raw)
To: Gustavo A. R. Silva, Boris Ostrovsky, Thomas Gleixner,
Ingo Molnar, H. Peter Anvin, x86
Cc: xen-devel, linux-kernel
On 06/24/2017 12:01 AM, Gustavo A. R. Silva wrote:
> Remove unnecessary variable mfn in function xen_foreach_remap_area() and,
> refactor the code.
>
> Variable mfn at line 518:mfn = xen_remap_buf.mfns[i];
> is only being used to store a value to be passed as
> an argument to the xen_update_mem_tables() function.
> This value can be passed directly, which makes variable
> mfn unnecessary. Also, value assigned to variable mfn
> at line 534:mfn = xen_remap_mfn; is never used.
>
> Addresses-Coverity-ID: 1260110
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Thanks,
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: xen: remove unnecessary variable in xen_foreach_remap_area()
2017-06-23 22:01 [PATCH] x86: xen: remove unnecessary variable in xen_foreach_remap_area() Gustavo A. R. Silva
2017-06-26 11:59 ` Juergen Groß
@ 2017-07-03 11:28 ` Juergen Gross
1 sibling, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2017-07-03 11:28 UTC (permalink / raw)
To: Gustavo A. R. Silva, Boris Ostrovsky, Thomas Gleixner,
Ingo Molnar, H. Peter Anvin, x86
Cc: xen-devel, linux-kernel
On 24/06/17 00:01, Gustavo A. R. Silva wrote:
> Remove unnecessary variable mfn in function xen_foreach_remap_area() and,
> refactor the code.
>
> Variable mfn at line 518:mfn = xen_remap_buf.mfns[i];
> is only being used to store a value to be passed as
> an argument to the xen_update_mem_tables() function.
> This value can be passed directly, which makes variable
> mfn unnecessary. Also, value assigned to variable mfn
> at line 534:mfn = xen_remap_mfn; is never used.
>
> Addresses-Coverity-ID: 1260110
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Queued to xen/tip.git for-linus-4.13
Thanks,
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-03 11:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 22:01 [PATCH] x86: xen: remove unnecessary variable in xen_foreach_remap_area() Gustavo A. R. Silva
2017-06-26 11:59 ` Juergen Groß
2017-07-03 11:28 ` Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).