* [PATCH] ARM: hisi: Fix typo in comment
@ 2017-08-07 9:33 Yunzhi Li
2017-08-16 9:18 ` Wei Xu
0 siblings, 1 reply; 3+ messages in thread
From: Yunzhi Li @ 2017-08-07 9:33 UTC (permalink / raw)
To: yunzhi.li; +Cc: Yunzhi Li, linux-kernel, Russell King, linux-arm-kernel, Wei Xu
Fix the rc vs. pc typo. There is no a register named rc, I felt
confused when I read this assembler command in comment.
Signed-off-by: Yunzhi Li <yunzhi.li@deephi.tech>
---
arch/arm/mach-hisi/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c
index 91bb02dec20f..da5689ababf7 100644
--- a/arch/arm/mach-hisi/platsmp.c
+++ b/arch/arm/mach-hisi/platsmp.c
@@ -109,7 +109,7 @@ static void hix5hd2_set_scu_boot_addr(phys_addr_t start_addr, phys_addr_t jump_a
virt = ioremap(start_addr, PAGE_SIZE);
- writel_relaxed(0xe51ff004, virt); /* ldr pc, [rc, #-4] */
+ writel_relaxed(0xe51ff004, virt); /* ldr pc, [pc, #-4] */
writel_relaxed(jump_addr, virt + 4); /* pc jump phy address */
iounmap(virt);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: hisi: Fix typo in comment
2017-08-07 9:33 [PATCH] ARM: hisi: Fix typo in comment Yunzhi Li
@ 2017-08-16 9:18 ` Wei Xu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Xu @ 2017-08-16 9:18 UTC (permalink / raw)
To: Yunzhi Li, yunzhi.li
Cc: linux-kernel, Russell King, linux-arm-kernel, Linuxarm
Hi Yunzhi,
On 2017/8/7 10:33, Yunzhi Li wrote:
> Fix the rc vs. pc typo. There is no a register named rc, I felt
> confused when I read this assembler command in comment.
>
Thanks!
Yes, it is a typo.
And 0xe51ff004 is the machine code to do the jump.
I will change the commit msg as below and pick up it:
The machine code "0xe51ff004" means "ldr pc, [pc, #-4]".
This patch fixed the comment typo to avoid any confusion.
Best Regards,
Wei
> Signed-off-by: Yunzhi Li <yunzhi.li@deephi.tech>
> ---
>
> arch/arm/mach-hisi/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c
> index 91bb02dec20f..da5689ababf7 100644
> --- a/arch/arm/mach-hisi/platsmp.c
> +++ b/arch/arm/mach-hisi/platsmp.c
> @@ -109,7 +109,7 @@ static void hix5hd2_set_scu_boot_addr(phys_addr_t start_addr, phys_addr_t jump_a
>
> virt = ioremap(start_addr, PAGE_SIZE);
>
> - writel_relaxed(0xe51ff004, virt); /* ldr pc, [rc, #-4] */
> + writel_relaxed(0xe51ff004, virt); /* ldr pc, [pc, #-4] */
> writel_relaxed(jump_addr, virt + 4); /* pc jump phy address */
> iounmap(virt);
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: hisi: Fix typo in comment
@ 2017-08-07 9:37 Yunzhi Li
0 siblings, 0 replies; 3+ messages in thread
From: Yunzhi Li @ 2017-08-07 9:37 UTC (permalink / raw)
To: yunzhi.li; +Cc: linux-kernel, Russell King, linux-arm-kernel, Wei Xu
Fix the rc vs. pc typo. There is no a register named rc, I felt
confused when I read this assembler command in comment.
Signed-off-by: Yunzhi Li <yunzhi.li@deephi.tech>
---
arch/arm/mach-hisi/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c
index 91bb02dec20f..da5689ababf7 100644
--- a/arch/arm/mach-hisi/platsmp.c
+++ b/arch/arm/mach-hisi/platsmp.c
@@ -109,7 +109,7 @@ static void hix5hd2_set_scu_boot_addr(phys_addr_t start_addr, phys_addr_t jump_a
virt = ioremap(start_addr, PAGE_SIZE);
- writel_relaxed(0xe51ff004, virt); /* ldr pc, [rc, #-4] */
+ writel_relaxed(0xe51ff004, virt); /* ldr pc, [pc, #-4] */
writel_relaxed(jump_addr, virt + 4); /* pc jump phy address */
iounmap(virt);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-16 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-07 9:33 [PATCH] ARM: hisi: Fix typo in comment Yunzhi Li
2017-08-16 9:18 ` Wei Xu
2017-08-07 9:37 Yunzhi Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).