* [PATCH] nvram: annotate implicit fall through
@ 2019-01-14 20:44 Mathieu Malaterre
2019-01-14 21:40 ` Gustavo A. R. Silva
2019-01-22 9:23 ` Greg Kroah-Hartman
0 siblings, 2 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2019-01-14 20:44 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Mathieu Malaterre, Greg Kroah-Hartman, linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warning (W=1).
This commit remove the following warning:
drivers/char/generic_nvram.c:83:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
drivers/char/generic_nvram.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/generic_nvram.c b/drivers/char/generic_nvram.c
index ff5394f47587..53123c110f7b 100644
--- a/drivers/char/generic_nvram.c
+++ b/drivers/char/generic_nvram.c
@@ -81,6 +81,7 @@ static int nvram_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
#ifdef CONFIG_PPC_PMAC
case OBSOLETE_PMAC_NVRAM_GET_OFFSET:
printk(KERN_WARNING "nvram: Using obsolete PMAC_NVRAM_GET_OFFSET ioctl\n");
+ /* fall through */
case IOC_NVRAM_GET_OFFSET: {
int part, offset;
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvram: annotate implicit fall through
2019-01-14 20:44 [PATCH] nvram: annotate implicit fall through Mathieu Malaterre
@ 2019-01-14 21:40 ` Gustavo A. R. Silva
2019-01-22 9:23 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-14 21:40 UTC (permalink / raw)
To: Mathieu Malaterre, Arnd Bergmann; +Cc: Greg Kroah-Hartman, linux-kernel
On 1/14/19 2:44 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
> drivers/char/generic_nvram.c:83:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> drivers/char/generic_nvram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/generic_nvram.c b/drivers/char/generic_nvram.c
> index ff5394f47587..53123c110f7b 100644
> --- a/drivers/char/generic_nvram.c
> +++ b/drivers/char/generic_nvram.c
> @@ -81,6 +81,7 @@ static int nvram_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> #ifdef CONFIG_PPC_PMAC
> case OBSOLETE_PMAC_NVRAM_GET_OFFSET:
> printk(KERN_WARNING "nvram: Using obsolete PMAC_NVRAM_GET_OFFSET ioctl\n");
Here you could use the pr_warn() macro instead of the obsolete printk KERN_WARNING, but that'd
be another patch.
Anyway:
Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks
--
Gustavo
> + /* fall through */
> case IOC_NVRAM_GET_OFFSET: {
> int part, offset;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvram: annotate implicit fall through
2019-01-14 20:44 [PATCH] nvram: annotate implicit fall through Mathieu Malaterre
2019-01-14 21:40 ` Gustavo A. R. Silva
@ 2019-01-22 9:23 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-01-22 9:23 UTC (permalink / raw)
To: Mathieu Malaterre; +Cc: Arnd Bergmann, linux-kernel
On Mon, Jan 14, 2019 at 09:44:15PM +0100, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
> drivers/char/generic_nvram.c:83:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/char/generic_nvram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/generic_nvram.c b/drivers/char/generic_nvram.c
> index ff5394f47587..53123c110f7b 100644
> --- a/drivers/char/generic_nvram.c
> +++ b/drivers/char/generic_nvram.c
> @@ -81,6 +81,7 @@ static int nvram_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> #ifdef CONFIG_PPC_PMAC
> case OBSOLETE_PMAC_NVRAM_GET_OFFSET:
> printk(KERN_WARNING "nvram: Using obsolete PMAC_NVRAM_GET_OFFSET ioctl\n");
> + /* fall through */
> case IOC_NVRAM_GET_OFFSET: {
> int part, offset;
>
This file is now gone from my tree, sorry.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-22 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 20:44 [PATCH] nvram: annotate implicit fall through Mathieu Malaterre
2019-01-14 21:40 ` Gustavo A. R. Silva
2019-01-22 9:23 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).