* [PATCH] extcon: max77693: Delete an unnecessary variable initialisation in max77693_muic_set_path()
@ 2017-11-09 8:49 ` SF Markus Elfring
2017-11-09 9:16 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-11-09 8:49 UTC (permalink / raw)
To: kernel-janitors, Bartlomiej Zolnierkiewicz, Chanwoo Choi,
Krzysztof Kozlowski, MyungJoo Ham
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 9 Nov 2017 09:40:59 +0100
The variable "ret" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/extcon/extcon-max77693.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
index 643411066ad9..227651ff9666 100644
--- a/drivers/extcon/extcon-max77693.c
+++ b/drivers/extcon/extcon-max77693.c
@@ -266,7 +266,7 @@ static int max77693_muic_set_debounce_time(struct max77693_muic_info *info,
static int max77693_muic_set_path(struct max77693_muic_info *info,
u8 val, bool attached)
{
- int ret = 0;
+ int ret;
unsigned int ctrl1, ctrl2 = 0;
if (attached)
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: max77693: Delete an unnecessary variable initialisation in max77693_muic_set_path()
2017-11-09 8:49 ` [PATCH] extcon: max77693: Delete an unnecessary variable initialisation in max77693_muic_set_path() SF Markus Elfring
@ 2017-11-09 9:16 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2017-11-09 9:16 UTC (permalink / raw)
To: SF Markus Elfring, kernel-janitors, Bartlomiej Zolnierkiewicz,
Krzysztof Kozlowski, MyungJoo Ham
Cc: LKML
Hi,
On 2017년 11월 09일 17:49, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 9 Nov 2017 09:40:59 +0100
>
> The variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/extcon/extcon-max77693.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
> index 643411066ad9..227651ff9666 100644
> --- a/drivers/extcon/extcon-max77693.c
> +++ b/drivers/extcon/extcon-max77693.c
> @@ -266,7 +266,7 @@ static int max77693_muic_set_debounce_time(struct max77693_muic_info *info,
> static int max77693_muic_set_path(struct max77693_muic_info *info,
> u8 val, bool attached)
> {
> - int ret = 0;
> + int ret;
> unsigned int ctrl1, ctrl2 = 0;
>
> if (attached)
>
Applied it. But, it will be merged to v4.16-rc1.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-09 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20171109084920epcas2p1a711136b29d823b7ce7d4bc56be69bb9@epcas2p1.samsung.com>
2017-11-09 8:49 ` [PATCH] extcon: max77693: Delete an unnecessary variable initialisation in max77693_muic_set_path() SF Markus Elfring
2017-11-09 9:16 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).