From: zhong jiang <zhongjiang@huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: John Garry <john.garry@huawei.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
<aacraid@microsemi.com>, linux-scsi <linux-scsi@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] driver/scsi/fnic/fnic_trace: Use vzalloc to zero instead of vmalloc+memset
Date: Thu, 2 Aug 2018 14:16:47 +0800 [thread overview]
Message-ID: <5B62A1CF.7040904@huawei.com> (raw)
In-Reply-To: <CAHp75Vchu7QwNBeYQxa9fY8=PinGzPpUPaRbk_MyoZ+w07hA4A@mail.gmail.com>
On 2018/8/1 23:30, Andy Shevchenko wrote:
> On Wed, Aug 1, 2018 at 4:26 PM, zhong jiang <zhongjiang@huawei.com> wrote:
>> The vzalloc is better than vmalloc+memset, so replace them to make
>> the code concise.
>> - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
>> + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * PAGE_SIZE));
> At the same time you may get rid of unnecessary parens.
>
Thanks , I will repost with the change.
Thanks
zhong jiang
next prev parent reply other threads:[~2018-08-02 6:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 13:26 [PATCH 0/4] use dma_zalloc_coherent and vzalloc to replace open code zhong jiang
2018-08-01 13:26 ` [PATCH 1/4] driver/scsi/fnic/fnic_trace: Use vzalloc to zero instead of vmalloc+memset zhong jiang
2018-08-01 15:30 ` Andy Shevchenko
2018-08-01 15:47 ` Joe Perches
2018-08-02 6:16 ` zhong jiang [this message]
2018-08-01 13:26 ` [PATCH 2/4] drivers/scsi/dpt_i2o: Use dma_zalloc_coherent to repalce dma_alloc_coherent+memset zhong jiang
2018-08-01 15:32 ` Andy Shevchenko
2018-08-01 13:26 ` [PATCH 3/4] drivers/scsi/snic/snic_trc: Use vzalloc instead of vmalloc+memset zhong jiang
2018-08-01 15:33 ` Andy Shevchenko
2018-08-01 13:26 ` [PATCH 4/4] drivers/scsi/mvsas/mv_init: Use dma_zalloc_coherent to replace dma_alloc_coherent+memset zhong jiang
2018-08-01 15:34 ` Andy Shevchenko
2018-08-01 23:55 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B62A1CF.7040904@huawei.com \
--to=zhongjiang@huawei.com \
--cc=aacraid@microsemi.com \
--cc=andy.shevchenko@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).