From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: John Garry <john.garry@huawei.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
aacraid@microsemi.com, linux-scsi <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] drivers/scsi/snic/snic_trc: Use vzalloc instead of vmalloc+memset
Date: Wed, 1 Aug 2018 18:33:17 +0300 [thread overview]
Message-ID: <CAHp75Vd1=Tw+=JMSe3XTGx0jsXCW7qi+dMCo1i6RTWc-kMYH2A@mail.gmail.com> (raw)
In-Reply-To: <1533129976-51930-4-git-send-email-zhongjiang@huawei.com>
On Wed, Aug 1, 2018 at 4:26 PM, zhong jiang <zhongjiang@huawei.com> wrote:
> The vzmalloc is better than vmalloc+memset, so replace them.
>
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/scsi/snic/snic_trc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/snic/snic_trc.c b/drivers/scsi/snic/snic_trc.c
> index fc60c93..876c490 100644
> --- a/drivers/scsi/snic/snic_trc.c
> +++ b/drivers/scsi/snic/snic_trc.c
> @@ -126,7 +126,7 @@ struct snic_trc_data *
> int tbuf_sz = 0, ret;
>
> tbuf_sz = (snic_trace_max_pages * PAGE_SIZE);
> - tbuf = vmalloc(tbuf_sz);
> + tbuf = vzmalloc(tbuf_sz);
> if (!tbuf) {
> SNIC_ERR("Failed to Allocate Trace Buffer Size. %d\n", tbuf_sz);
> SNIC_ERR("Trace Facility not enabled.\n");
> @@ -135,7 +135,6 @@ struct snic_trc_data *
> return ret;
> }
>
> - memset(tbuf, 0, tbuf_sz);
> trc->buf = (struct snic_trc_data *) tbuf;
> spin_lock_init(&trc->lock);
>
> --
> 1.7.12.4
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-08-01 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 13:26 [PATCH 0/4] use dma_zalloc_coherent and vzalloc to replace open code zhong jiang
2018-08-01 13:26 ` [PATCH 1/4] driver/scsi/fnic/fnic_trace: Use vzalloc to zero instead of vmalloc+memset zhong jiang
2018-08-01 15:30 ` Andy Shevchenko
2018-08-01 15:47 ` Joe Perches
2018-08-02 6:16 ` zhong jiang
2018-08-01 13:26 ` [PATCH 2/4] drivers/scsi/dpt_i2o: Use dma_zalloc_coherent to repalce dma_alloc_coherent+memset zhong jiang
2018-08-01 15:32 ` Andy Shevchenko
2018-08-01 13:26 ` [PATCH 3/4] drivers/scsi/snic/snic_trc: Use vzalloc instead of vmalloc+memset zhong jiang
2018-08-01 15:33 ` Andy Shevchenko [this message]
2018-08-01 13:26 ` [PATCH 4/4] drivers/scsi/mvsas/mv_init: Use dma_zalloc_coherent to replace dma_alloc_coherent+memset zhong jiang
2018-08-01 15:34 ` Andy Shevchenko
2018-08-01 23:55 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vd1=Tw+=JMSe3XTGx0jsXCW7qi+dMCo1i6RTWc-kMYH2A@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=aacraid@microsemi.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).