From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 04/11] arm64: dts: meson-g12a-u200: add regulators
Date: Sat, 16 Mar 2019 15:40:53 +0100 [thread overview]
Message-ID: <5C8D0AF5.5040101@baylibre.com> (raw)
In-Reply-To: <CAFBinCCiV21kB38SXqVYMmQ5YkK2MxXKhiTJrVP3jOCLDtuBBg@mail.gmail.com>
HI,
Le 15/03/2019 23:01, Martin Blumenstingl a écrit :
> Hi Neil,
>
> On Mon, Mar 11, 2019 at 10:57 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> From: Jerome Brunet <jbrunet@baylibre.com>
>>
>> Add system regulators for the S905D2 U200 reference design.
> I find the hint in the meson-g12a-sei510 regulators patch very good:
> Still missing
> * VDD_EE (0.8V - PWM controlled)
> * VDD_CPU(PWM controlled)
> * VDDQ1_5
I will add the same comment here
>
> VDD_EE and VDD_CPU are *probably* going to be very similar across all
> boards (Meson8b uses two slightly different PWM regulators on all
> boards supported by mainline, but the basic concept is always the
> same)
Not necessarily, it can change, it used to change across GXBB boards, but
seems to be more coherent across GXL/GXM/G12A ref designs and derivative
boards, but it can still change if the HW designer decides to be creative !
> I'm not sure if VDDQ1_5 is specific to the SEI510 board though.
I think VDDQ1_5 is specific to SEI510, will check on the schematics
>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> .../boot/dts/amlogic/meson-g12a-u200.dts | 79 +++++++++++++++++++
>> 1 file changed, 79 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
>> index f2afd0bf3e28..17696f356ff2 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
>> @@ -14,13 +14,92 @@
>> aliases {
>> serial0 = &uart_AO;
>> };
>> +
>> chosen {
>> stdout-path = "serial0:115200n8";
>> };
>> +
>> memory@0 {
>> device_type = "memory";
>> reg = <0x0 0x0 0x0 0x40000000>;
>> };
> there are two unrelated whitespace changes above.
> please clean them up if you have to re-send this for whatever reason
Yep, will cleanup
>
>
> Regards
> Martin
>
next prev parent reply other threads:[~2019-03-16 14:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 9:56 [PATCH 00/11] arm64: dts: g12a: Add boards peripherals Neil Armstrong
2019-03-11 9:56 ` [PATCH 01/11] arm64: dts: meson-g12a-u200: add uart_AO pinctrl Neil Armstrong
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 02/11] arm64: dts: meson-g12a-sei510: " Neil Armstrong
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 03/11] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 04/11] arm64: dts: meson-g12a-u200: add regulators Neil Armstrong
2019-03-15 22:01 ` Martin Blumenstingl
2019-03-16 14:40 ` Neil Armstrong [this message]
2019-03-11 9:56 ` [PATCH 05/11] arm64: dts: meson-g12a-sei510: " Neil Armstrong
2019-03-11 9:56 ` [PATCH 06/11] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
2019-03-15 22:05 ` Martin Blumenstingl
2019-03-16 14:41 ` Neil Armstrong
2019-03-16 14:41 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 07/11] arm64: dts: meson-g12a-x96-max: Enable BT Module Neil Armstrong
2019-03-15 21:48 ` Martin Blumenstingl
2019-03-16 14:42 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 08/11] arm64: dts: meson-g12a-sei510: Add ADC Key and BT support Neil Armstrong
2019-03-11 9:56 ` [PATCH 09/11] arm64: dts: meson-g12a-sei510: Enable USB Neil Armstrong
2019-03-11 9:56 ` [PATCH 10/11] arm64: dts: meson-g12a-u200: " Neil Armstrong
2019-03-15 21:52 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 11/11] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
2019-03-15 21:50 ` Martin Blumenstingl
2019-03-16 14:46 ` Neil Armstrong
2019-03-16 22:07 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C8D0AF5.5040101@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).