From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Guillaume La Roque <glaroque@baylibre.com>
Cc: khilman@baylibre.com, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/11] arm64: dts: meson-g12a-x96-max: add regulators
Date: Sat, 16 Mar 2019 15:41:28 +0100 [thread overview]
Message-ID: <5C8D0B18.1070001@baylibre.com> (raw)
In-Reply-To: <CAFBinCBEeCAKuzOztT5wU1t9UvY=ocVVrdHB6PNG7pp+gXq1=A@mail.gmail.com>
Le 15/03/2019 23:05, Martin Blumenstingl a écrit :
> Hi Neil and Guillaume,
>
> On Mon, Mar 11, 2019 at 11:04 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> From: Guillaume La Roque <glaroque@baylibre.com>
>>
>> Add system regulators for the X96 Max Set-Top-Box.
> the hint from the "meson-g12a-sei510: add regulators" patch would be
> great here as well:
> Still missing
> * VDD_EE (0.8V - PWM controlled)
> * VDD_CPU(PWM controlled)
> * VDDQ1_5
Will add the comment
>
> I'm not sure whether this board also has VDDQ1_5 though, but VDD_EE
> and VDD_CPU should be very similar (or even identical)
It's bases on a ref design, we can assume it's the same yes
>
>>
>> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> .../boot/dts/amlogic/meson-g12a-x96-max.dts | 65 +++++++++++++++++++
>> 1 file changed, 65 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> index 0edbd00b358f..21e5de48613e 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> @@ -21,6 +21,71 @@
>> device_type = "memory";
>> reg = <0x0 0x0 0x0 0x40000000>;
>> };
>> +
>> + flash_1v8: regulator-flash_1v8 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "FLASH_1V8";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + vin-supply = <&vcc_3v3>;
>> + regulator-always-on;
>> + };
>> +
>> + main_12v: regulator-main_12v {
>> + compatible = "regulator-fixed";
>> + regulator-name = "12V";
>> + regulator-min-microvolt = <12000000>;
>> + regulator-max-microvolt = <12000000>;
>> + regulator-always-on;
>> + };
> mine has a 5V DC in. can you please check this on your board?
>
>
> Regards
> Martin
>
next prev parent reply other threads:[~2019-03-16 14:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 9:56 [PATCH 00/11] arm64: dts: g12a: Add boards peripherals Neil Armstrong
2019-03-11 9:56 ` [PATCH 01/11] arm64: dts: meson-g12a-u200: add uart_AO pinctrl Neil Armstrong
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 02/11] arm64: dts: meson-g12a-sei510: " Neil Armstrong
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 03/11] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 04/11] arm64: dts: meson-g12a-u200: add regulators Neil Armstrong
2019-03-15 22:01 ` Martin Blumenstingl
2019-03-16 14:40 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 05/11] arm64: dts: meson-g12a-sei510: " Neil Armstrong
2019-03-11 9:56 ` [PATCH 06/11] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
2019-03-15 22:05 ` Martin Blumenstingl
2019-03-16 14:41 ` Neil Armstrong [this message]
2019-03-16 14:41 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 07/11] arm64: dts: meson-g12a-x96-max: Enable BT Module Neil Armstrong
2019-03-15 21:48 ` Martin Blumenstingl
2019-03-16 14:42 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 08/11] arm64: dts: meson-g12a-sei510: Add ADC Key and BT support Neil Armstrong
2019-03-11 9:56 ` [PATCH 09/11] arm64: dts: meson-g12a-sei510: Enable USB Neil Armstrong
2019-03-11 9:56 ` [PATCH 10/11] arm64: dts: meson-g12a-u200: " Neil Armstrong
2019-03-15 21:52 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 11/11] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
2019-03-15 21:50 ` Martin Blumenstingl
2019-03-16 14:46 ` Neil Armstrong
2019-03-16 22:07 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C8D0B18.1070001@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=glaroque@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).