From: Zhou Wang <wangzhou1@hisilicon.com>
To: Jens Axboe <axboe@fb.com>,
"robert.jarzmik@free.fr" <robert.jarzmik@free.fr>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxarm@huawei.com" <linuxarm@huawei.com>
Subject: Re: [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg
Date: Thu, 8 Aug 2019 22:01:51 +0800 [thread overview]
Message-ID: <5D4C2B4F.2040401@hisilicon.com> (raw)
In-Reply-To: <ba094177-6dc5-e1f6-d256-8e21d119729e@fb.com>
On 2019/8/8 21:40, Jens Axboe wrote:
> On 7/28/19 6:44 PM, Zhou Wang wrote:
>> On 2019/7/24 11:54, Zhou Wang wrote:
>>> In function sg_split, the second sg_calculate_split will return -EINVAL
>>> when in_mapped_nents is 0.
>>>
>>> Indeed there is no need to do second sg_calculate_split and sg_split_mapped
>>> when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in
>>> original sgl.
>>>
>>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
>>> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
>>> ---
>>> v2: Just add Acked-by from Robert.
>>>
>>> lib/sg_split.c | 12 +++++++-----
>>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/lib/sg_split.c b/lib/sg_split.c
>>> index 9982c63..60a0bab 100644
>>> --- a/lib/sg_split.c
>>> +++ b/lib/sg_split.c
>>> @@ -176,11 +176,13 @@ int sg_split(struct scatterlist *in, const int in_mapped_nents,
>>> * The order of these 3 calls is important and should be kept.
>>> */
>>> sg_split_phys(splitters, nb_splits);
>>> - ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
>>> - split_sizes, splitters, true);
>>> - if (ret < 0)
>>> - goto err;
>>> - sg_split_mapped(splitters, nb_splits);
>>> + if (in_mapped_nents) {
>>> + ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
>>> + split_sizes, splitters, true);
>>> + if (ret < 0)
>>> + goto err;
>>> + sg_split_mapped(splitters, nb_splits);
>>> + }
>>>
>>> for (i = 0; i < nb_splits; i++) {
>>> out[i] = splitters[i].out_sg;
>>>
>>
>> Hi Jens,
>>
>> I saw you are the committer of sg_splite.c, could you help to take this patch?
>
> Yes, I can take it for 5.4, it looks fine to me.
Thanks a lot for taking this patch :)
>
prev parent reply other threads:[~2019-08-08 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 3:54 [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg Zhou Wang
2019-07-29 1:44 ` Zhou Wang
2019-08-06 1:46 ` Zhou Wang
2019-08-08 13:40 ` Jens Axboe
2019-08-08 14:01 ` Zhou Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D4C2B4F.2040401@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).