* [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg
@ 2019-07-24 3:54 Zhou Wang
2019-07-29 1:44 ` Zhou Wang
0 siblings, 1 reply; 5+ messages in thread
From: Zhou Wang @ 2019-07-24 3:54 UTC (permalink / raw)
To: robert.jarzmik, axboe; +Cc: linux-kernel, linuxarm, Zhou Wang
In function sg_split, the second sg_calculate_split will return -EINVAL
when in_mapped_nents is 0.
Indeed there is no need to do second sg_calculate_split and sg_split_mapped
when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in
original sgl.
Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
v2: Just add Acked-by from Robert.
lib/sg_split.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/lib/sg_split.c b/lib/sg_split.c
index 9982c63..60a0bab 100644
--- a/lib/sg_split.c
+++ b/lib/sg_split.c
@@ -176,11 +176,13 @@ int sg_split(struct scatterlist *in, const int in_mapped_nents,
* The order of these 3 calls is important and should be kept.
*/
sg_split_phys(splitters, nb_splits);
- ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
- split_sizes, splitters, true);
- if (ret < 0)
- goto err;
- sg_split_mapped(splitters, nb_splits);
+ if (in_mapped_nents) {
+ ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
+ split_sizes, splitters, true);
+ if (ret < 0)
+ goto err;
+ sg_split_mapped(splitters, nb_splits);
+ }
for (i = 0; i < nb_splits; i++) {
out[i] = splitters[i].out_sg;
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg
2019-07-24 3:54 [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg Zhou Wang
@ 2019-07-29 1:44 ` Zhou Wang
2019-08-06 1:46 ` Zhou Wang
2019-08-08 13:40 ` Jens Axboe
0 siblings, 2 replies; 5+ messages in thread
From: Zhou Wang @ 2019-07-29 1:44 UTC (permalink / raw)
To: robert.jarzmik, axboe, axboe; +Cc: linux-kernel, linuxarm
On 2019/7/24 11:54, Zhou Wang wrote:
> In function sg_split, the second sg_calculate_split will return -EINVAL
> when in_mapped_nents is 0.
>
> Indeed there is no need to do second sg_calculate_split and sg_split_mapped
> when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in
> original sgl.
>
> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> v2: Just add Acked-by from Robert.
>
> lib/sg_split.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/lib/sg_split.c b/lib/sg_split.c
> index 9982c63..60a0bab 100644
> --- a/lib/sg_split.c
> +++ b/lib/sg_split.c
> @@ -176,11 +176,13 @@ int sg_split(struct scatterlist *in, const int in_mapped_nents,
> * The order of these 3 calls is important and should be kept.
> */
> sg_split_phys(splitters, nb_splits);
> - ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
> - split_sizes, splitters, true);
> - if (ret < 0)
> - goto err;
> - sg_split_mapped(splitters, nb_splits);
> + if (in_mapped_nents) {
> + ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
> + split_sizes, splitters, true);
> + if (ret < 0)
> + goto err;
> + sg_split_mapped(splitters, nb_splits);
> + }
>
> for (i = 0; i < nb_splits; i++) {
> out[i] = splitters[i].out_sg;
>
Hi Jens,
I saw you are the committer of sg_splite.c, could you help to take this patch?
Many thanks,
Zhou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg
2019-07-29 1:44 ` Zhou Wang
@ 2019-08-06 1:46 ` Zhou Wang
2019-08-08 13:40 ` Jens Axboe
1 sibling, 0 replies; 5+ messages in thread
From: Zhou Wang @ 2019-08-06 1:46 UTC (permalink / raw)
To: robert.jarzmik, axboe, axboe, gregkh; +Cc: linux-kernel, linuxarm
On 2019/7/29 9:44, Zhou Wang wrote:
> On 2019/7/24 11:54, Zhou Wang wrote:
>> In function sg_split, the second sg_calculate_split will return -EINVAL
>> when in_mapped_nents is 0.
>>
>> Indeed there is no need to do second sg_calculate_split and sg_split_mapped
>> when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in
>> original sgl.
>>
>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
>> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> ---
>> v2: Just add Acked-by from Robert.
>>
>> lib/sg_split.c | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/lib/sg_split.c b/lib/sg_split.c
>> index 9982c63..60a0bab 100644
>> --- a/lib/sg_split.c
>> +++ b/lib/sg_split.c
>> @@ -176,11 +176,13 @@ int sg_split(struct scatterlist *in, const int in_mapped_nents,
>> * The order of these 3 calls is important and should be kept.
>> */
>> sg_split_phys(splitters, nb_splits);
>> - ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
>> - split_sizes, splitters, true);
>> - if (ret < 0)
>> - goto err;
>> - sg_split_mapped(splitters, nb_splits);
>> + if (in_mapped_nents) {
>> + ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
>> + split_sizes, splitters, true);
>> + if (ret < 0)
>> + goto err;
>> + sg_split_mapped(splitters, nb_splits);
>> + }
>>
>> for (i = 0; i < nb_splits; i++) {
>> out[i] = splitters[i].out_sg;
>>
>
> Hi Jens,
>
> I saw you are the committer of sg_splite.c, could you help to take this patch?
>
> Many thanks,
> Zhou
>
Anyone can help to take this fix?
Best,
Zhou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg
2019-07-29 1:44 ` Zhou Wang
2019-08-06 1:46 ` Zhou Wang
@ 2019-08-08 13:40 ` Jens Axboe
2019-08-08 14:01 ` Zhou Wang
1 sibling, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2019-08-08 13:40 UTC (permalink / raw)
To: Zhou Wang, robert.jarzmik, axboe; +Cc: linux-kernel, linuxarm
On 7/28/19 6:44 PM, Zhou Wang wrote:
> On 2019/7/24 11:54, Zhou Wang wrote:
>> In function sg_split, the second sg_calculate_split will return -EINVAL
>> when in_mapped_nents is 0.
>>
>> Indeed there is no need to do second sg_calculate_split and sg_split_mapped
>> when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in
>> original sgl.
>>
>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
>> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> ---
>> v2: Just add Acked-by from Robert.
>>
>> lib/sg_split.c | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/lib/sg_split.c b/lib/sg_split.c
>> index 9982c63..60a0bab 100644
>> --- a/lib/sg_split.c
>> +++ b/lib/sg_split.c
>> @@ -176,11 +176,13 @@ int sg_split(struct scatterlist *in, const int in_mapped_nents,
>> * The order of these 3 calls is important and should be kept.
>> */
>> sg_split_phys(splitters, nb_splits);
>> - ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
>> - split_sizes, splitters, true);
>> - if (ret < 0)
>> - goto err;
>> - sg_split_mapped(splitters, nb_splits);
>> + if (in_mapped_nents) {
>> + ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
>> + split_sizes, splitters, true);
>> + if (ret < 0)
>> + goto err;
>> + sg_split_mapped(splitters, nb_splits);
>> + }
>>
>> for (i = 0; i < nb_splits; i++) {
>> out[i] = splitters[i].out_sg;
>>
>
> Hi Jens,
>
> I saw you are the committer of sg_splite.c, could you help to take this patch?
Yes, I can take it for 5.4, it looks fine to me.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg
2019-08-08 13:40 ` Jens Axboe
@ 2019-08-08 14:01 ` Zhou Wang
0 siblings, 0 replies; 5+ messages in thread
From: Zhou Wang @ 2019-08-08 14:01 UTC (permalink / raw)
To: Jens Axboe, robert.jarzmik, axboe; +Cc: linux-kernel, linuxarm
On 2019/8/8 21:40, Jens Axboe wrote:
> On 7/28/19 6:44 PM, Zhou Wang wrote:
>> On 2019/7/24 11:54, Zhou Wang wrote:
>>> In function sg_split, the second sg_calculate_split will return -EINVAL
>>> when in_mapped_nents is 0.
>>>
>>> Indeed there is no need to do second sg_calculate_split and sg_split_mapped
>>> when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in
>>> original sgl.
>>>
>>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
>>> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
>>> ---
>>> v2: Just add Acked-by from Robert.
>>>
>>> lib/sg_split.c | 12 +++++++-----
>>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/lib/sg_split.c b/lib/sg_split.c
>>> index 9982c63..60a0bab 100644
>>> --- a/lib/sg_split.c
>>> +++ b/lib/sg_split.c
>>> @@ -176,11 +176,13 @@ int sg_split(struct scatterlist *in, const int in_mapped_nents,
>>> * The order of these 3 calls is important and should be kept.
>>> */
>>> sg_split_phys(splitters, nb_splits);
>>> - ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
>>> - split_sizes, splitters, true);
>>> - if (ret < 0)
>>> - goto err;
>>> - sg_split_mapped(splitters, nb_splits);
>>> + if (in_mapped_nents) {
>>> + ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip,
>>> + split_sizes, splitters, true);
>>> + if (ret < 0)
>>> + goto err;
>>> + sg_split_mapped(splitters, nb_splits);
>>> + }
>>>
>>> for (i = 0; i < nb_splits; i++) {
>>> out[i] = splitters[i].out_sg;
>>>
>>
>> Hi Jens,
>>
>> I saw you are the committer of sg_splite.c, could you help to take this patch?
>
> Yes, I can take it for 5.4, it looks fine to me.
Thanks a lot for taking this patch :)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-08 14:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24 3:54 [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg Zhou Wang
2019-07-29 1:44 ` Zhou Wang
2019-08-06 1:46 ` Zhou Wang
2019-08-08 13:40 ` Jens Axboe
2019-08-08 14:01 ` Zhou Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).