* [PATCH] fs: omfs: Use kmemdup rather than duplicating its implementation in omfs_get_imap @ 2019-09-03 6:39 zhong jiang 2019-09-03 13:25 ` Bob Copeland 0 siblings, 1 reply; 3+ messages in thread From: zhong jiang @ 2019-09-03 6:39 UTC (permalink / raw) To: me; +Cc: zhongjiang, linux-kernel, linux-karma-devel kmemdup contains the kmalloc + memcpy. hence it is better to use kmemdup directly. Just replace it. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- fs/omfs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index b76ec6b..8867cef 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/inode.c @@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb) bh = sb_bread(sb, block++); if (!bh) goto nomem_free; - *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL); + *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL); if (!*ptr) { brelse(bh); goto nomem_free; } - memcpy(*ptr, bh->b_data, sb->s_blocksize); if (count < sb->s_blocksize) memset((void *)*ptr + count, 0xff, sb->s_blocksize - count); -- 1.7.12.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: omfs: Use kmemdup rather than duplicating its implementation in omfs_get_imap 2019-09-03 6:39 [PATCH] fs: omfs: Use kmemdup rather than duplicating its implementation in omfs_get_imap zhong jiang @ 2019-09-03 13:25 ` Bob Copeland 2019-09-03 13:57 ` zhong jiang 0 siblings, 1 reply; 3+ messages in thread From: Bob Copeland @ 2019-09-03 13:25 UTC (permalink / raw) To: zhong jiang; +Cc: linux-kernel, Fuqian Huang On Tue, Sep 03, 2019 at 02:39:44PM +0800, zhong jiang wrote: > kmemdup contains the kmalloc + memcpy. hence it is better to use kmemdup > directly. Just replace it. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> This same patch was already sent to me by someone else and I acked it: https://lore.kernel.org/lkml/20190703163158.937-1-huangfq.daxian@gmail.com/ -- Bob Copeland %% https://bobcopeland.com/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: omfs: Use kmemdup rather than duplicating its implementation in omfs_get_imap 2019-09-03 13:25 ` Bob Copeland @ 2019-09-03 13:57 ` zhong jiang 0 siblings, 0 replies; 3+ messages in thread From: zhong jiang @ 2019-09-03 13:57 UTC (permalink / raw) To: Bob Copeland; +Cc: linux-kernel, Fuqian Huang On 2019/9/3 21:25, Bob Copeland wrote: > On Tue, Sep 03, 2019 at 02:39:44PM +0800, zhong jiang wrote: >> kmemdup contains the kmalloc + memcpy. hence it is better to use kmemdup >> directly. Just replace it. >> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> > This same patch was already sent to me by someone else and I acked it: > > https://lore.kernel.org/lkml/20190703163158.937-1-huangfq.daxian@gmail.com/ > I miss the patch. Thanks, Sincerely, zhong jiang ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-03 13:58 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-09-03 6:39 [PATCH] fs: omfs: Use kmemdup rather than duplicating its implementation in omfs_get_imap zhong jiang 2019-09-03 13:25 ` Bob Copeland 2019-09-03 13:57 ` zhong jiang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).