* [PATCH -next] crypto: hisilicon - qm depends on UACCE
@ 2020-02-25 3:03 Hongbo Yao
2020-02-25 8:44 ` Zhou Wang
0 siblings, 1 reply; 4+ messages in thread
From: Hongbo Yao @ 2020-02-25 3:03 UTC (permalink / raw)
To: herbert, davem
Cc: linux-kernel, linux-crypto, yaohongbo, chenzhou10, wangzhou1, xuzaibo
If UACCE=m and CRYPTO_DEV_HISI_QM=y, the following error
is seen while building qm.o:
drivers/crypto/hisilicon/qm.o: In function `hisi_qm_init':
(.text+0x23c6): undefined reference to `uacce_alloc'
(.text+0x2474): undefined reference to `uacce_remove'
(.text+0x286b): undefined reference to `uacce_remove'
drivers/crypto/hisilicon/qm.o: In function `hisi_qm_uninit':
(.text+0x2918): undefined reference to `uacce_remove'
make[1]: *** [vmlinux] Error 1
make: *** [autoksyms_recursive] Error 2
It has the similar issue while CONFIG_CRYPTO_DEV_HISI_ZIP=y, fix
the config dependency for QM or ZIP here.
reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
---
drivers/crypto/hisilicon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
index 8851161f722f..b35c2ec15bc2 100644
--- a/drivers/crypto/hisilicon/Kconfig
+++ b/drivers/crypto/hisilicon/Kconfig
@@ -40,6 +40,7 @@ config CRYPTO_DEV_HISI_QM
tristate
depends on ARM64 || COMPILE_TEST
depends on PCI && PCI_MSI
+ depends on UACCE
help
HiSilicon accelerator engines use a common queue management
interface. Specific engine driver may use this module.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] crypto: hisilicon - qm depends on UACCE
2020-02-25 3:03 [PATCH -next] crypto: hisilicon - qm depends on UACCE Hongbo Yao
@ 2020-02-25 8:44 ` Zhou Wang
2020-02-25 10:22 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Zhou Wang @ 2020-02-25 8:44 UTC (permalink / raw)
To: Hongbo Yao, herbert, davem
Cc: linux-kernel, linux-crypto, chenzhou10, xuzaibo
On 2020/2/25 11:03, Hongbo Yao wrote:
> If UACCE=m and CRYPTO_DEV_HISI_QM=y, the following error
> is seen while building qm.o:
>
> drivers/crypto/hisilicon/qm.o: In function `hisi_qm_init':
> (.text+0x23c6): undefined reference to `uacce_alloc'
> (.text+0x2474): undefined reference to `uacce_remove'
> (.text+0x286b): undefined reference to `uacce_remove'
> drivers/crypto/hisilicon/qm.o: In function `hisi_qm_uninit':
> (.text+0x2918): undefined reference to `uacce_remove'
> make[1]: *** [vmlinux] Error 1
> make: *** [autoksyms_recursive] Error 2
>
> It has the similar issue while CONFIG_CRYPTO_DEV_HISI_ZIP=y, fix
> the config dependency for QM or ZIP here.
>
> reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
> ---
> drivers/crypto/hisilicon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
> index 8851161f722f..b35c2ec15bc2 100644
> --- a/drivers/crypto/hisilicon/Kconfig
> +++ b/drivers/crypto/hisilicon/Kconfig
> @@ -40,6 +40,7 @@ config CRYPTO_DEV_HISI_QM
> tristate
> depends on ARM64 || COMPILE_TEST
> depends on PCI && PCI_MSI
> + depends on UACCE
> help
> HiSilicon accelerator engines use a common queue management
> interface. Specific engine driver may use this module.
>
Indeed, this driver does not depend on uacce fully, as if there is no uacce, it still can
register to kernel crypto.
Seems that changing uacce config to bool can avoid this problem.
Best,
Zhou
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] crypto: hisilicon - qm depends on UACCE
2020-02-25 8:44 ` Zhou Wang
@ 2020-02-25 10:22 ` Herbert Xu
2020-02-26 1:42 ` Zhou Wang
0 siblings, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2020-02-25 10:22 UTC (permalink / raw)
To: Zhou Wang
Cc: Hongbo Yao, davem, linux-kernel, linux-crypto, chenzhou10, xuzaibo
On Tue, Feb 25, 2020 at 04:44:57PM +0800, Zhou Wang wrote:
>
> > diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
> > index 8851161f722f..b35c2ec15bc2 100644
> > --- a/drivers/crypto/hisilicon/Kconfig
> > +++ b/drivers/crypto/hisilicon/Kconfig
> > @@ -40,6 +40,7 @@ config CRYPTO_DEV_HISI_QM
> > tristate
> > depends on ARM64 || COMPILE_TEST
> > depends on PCI && PCI_MSI
> > + depends on UACCE
> > help
> > HiSilicon accelerator engines use a common queue management
> > interface. Specific engine driver may use this module.
> >
>
> Indeed, this driver does not depend on uacce fully, as if there is no uacce, it still can
> register to kernel crypto.
>
> Seems that changing uacce config to bool can avoid this problem.
You shouldn't make it a bool. The standard way to solve this is to
add this:
depends on UACCE || UACCE=n
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] crypto: hisilicon - qm depends on UACCE
2020-02-25 10:22 ` Herbert Xu
@ 2020-02-26 1:42 ` Zhou Wang
0 siblings, 0 replies; 4+ messages in thread
From: Zhou Wang @ 2020-02-26 1:42 UTC (permalink / raw)
To: Herbert Xu
Cc: Hongbo Yao, davem, linux-kernel, linux-crypto, chenzhou10, xuzaibo
On 2020/2/25 18:22, Herbert Xu wrote:
> On Tue, Feb 25, 2020 at 04:44:57PM +0800, Zhou Wang wrote:
>>
>>> diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
>>> index 8851161f722f..b35c2ec15bc2 100644
>>> --- a/drivers/crypto/hisilicon/Kconfig
>>> +++ b/drivers/crypto/hisilicon/Kconfig
>>> @@ -40,6 +40,7 @@ config CRYPTO_DEV_HISI_QM
>>> tristate
>>> depends on ARM64 || COMPILE_TEST
>>> depends on PCI && PCI_MSI
>>> + depends on UACCE
>>> help
>>> HiSilicon accelerator engines use a common queue management
>>> interface. Specific engine driver may use this module.
>>>
>>
>> Indeed, this driver does not depend on uacce fully, as if there is no uacce, it still can
>> register to kernel crypto.
>>
>> Seems that changing uacce config to bool can avoid this problem.
>
> You shouldn't make it a bool. The standard way to solve this is to
> add this:
>
> depends on UACCE || UACCE=n
Thanks! Let's fix together with zip Kconfig.
Best,
Zhou
>
> Cheers,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-26 1:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-25 3:03 [PATCH -next] crypto: hisilicon - qm depends on UACCE Hongbo Yao
2020-02-25 8:44 ` Zhou Wang
2020-02-25 10:22 ` Herbert Xu
2020-02-26 1:42 ` Zhou Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).