* [PATCH] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe()
@ 2020-08-06 6:44 Jing Xiangfeng
2020-08-06 6:53 ` Jing Xiangfeng
0 siblings, 1 reply; 2+ messages in thread
From: Jing Xiangfeng @ 2020-08-06 6:44 UTC (permalink / raw)
To: alim.akhtar, avri.altman, jejb, martin.petersen, vigneshr, jingxiangfeng
Cc: linux-scsi, linux-kernel
Fix to return error code IS_ERR() from the error handling case instead
of 0.
Fixes: 22617e216331 ("scsi: ufs: ti-j721e-ufs: Fix unwinding of pm_runtime changes")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/scsi/ufs/ti-j721e-ufs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ti-j721e-ufs.c b/drivers/scsi/ufs/ti-j721e-ufs.c
index 46bb905b4d6a..eafe7c08b0c8 100644
--- a/drivers/scsi/ufs/ti-j721e-ufs.c
+++ b/drivers/scsi/ufs/ti-j721e-ufs.c
@@ -38,6 +38,7 @@ static int ti_j721e_ufs_probe(struct platform_device *pdev)
/* Select MPHY refclk frequency */
clk = devm_clk_get(dev, NULL);
if (IS_ERR(clk)) {
+ ret = IS_ERR(clk);
dev_err(dev, "Cannot claim MPHY clock.\n");
goto clk_err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe()
2020-08-06 6:44 [PATCH] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe() Jing Xiangfeng
@ 2020-08-06 6:53 ` Jing Xiangfeng
0 siblings, 0 replies; 2+ messages in thread
From: Jing Xiangfeng @ 2020-08-06 6:53 UTC (permalink / raw)
To: alim.akhtar, avri.altman, jejb, martin.petersen, vigneshr
Cc: linux-scsi, linux-kernel
Please ignore this patch.
Thanks
On 2020/8/6 14:44, Jing Xiangfeng wrote:
> Fix to return error code IS_ERR() from the error handling case instead
> of 0.
>
> Fixes: 22617e216331 ("scsi: ufs: ti-j721e-ufs: Fix unwinding of pm_runtime changes")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/scsi/ufs/ti-j721e-ufs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ti-j721e-ufs.c b/drivers/scsi/ufs/ti-j721e-ufs.c
> index 46bb905b4d6a..eafe7c08b0c8 100644
> --- a/drivers/scsi/ufs/ti-j721e-ufs.c
> +++ b/drivers/scsi/ufs/ti-j721e-ufs.c
> @@ -38,6 +38,7 @@ static int ti_j721e_ufs_probe(struct platform_device *pdev)
> /* Select MPHY refclk frequency */
> clk = devm_clk_get(dev, NULL);
> if (IS_ERR(clk)) {
> + ret = IS_ERR(clk);
> dev_err(dev, "Cannot claim MPHY clock.\n");
> goto clk_err;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-06 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 6:44 [PATCH] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe() Jing Xiangfeng
2020-08-06 6:53 ` Jing Xiangfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).