From: Denis Kirjanov <dkirjanov@suse.de>
To: Dongliang Mu <mudongliangabcd@gmail.com>,
Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ieee802154: fix shift-out-of-bound in nl802154_new_interface
Date: Thu, 11 Nov 2021 16:19:21 +0300 [thread overview]
Message-ID: <5a1969b0-f5ad-d5b4-0c66-14e65fdcd0dd@suse.de> (raw)
In-Reply-To: <20211111125118.1441463-1-mudongliangabcd@gmail.com>
11/11/21 3:51 PM, Dongliang Mu пишет:
> In nl802154_new_interface, if type retrieved from info->attr is
> NL802154_IFTYPE_UNSPEC(-1), i.e., less than NL802154_IFTYPE_MAX,
> it will trigger a shift-out-of-bound bug in BIT(type).
>
> Fix this by adding a condition to check if the variable type is
> larger than NL802154_IFTYPE_UNSPEC(-1).
Please add Fixes tag
>
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
> net/ieee802154/nl802154.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
> index 277124f206e0..cecf5ce0aa20 100644
> --- a/net/ieee802154/nl802154.c
> +++ b/net/ieee802154/nl802154.c
> @@ -915,7 +915,7 @@ static int nl802154_new_interface(struct sk_buff *skb, struct genl_info *info)
>
> if (info->attrs[NL802154_ATTR_IFTYPE]) {
> type = nla_get_u32(info->attrs[NL802154_ATTR_IFTYPE]);
> - if (type > NL802154_IFTYPE_MAX ||
> + if (type <= NL802154_IFTYPE_UNSPEC || type > NL802154_IFTYPE_MAX ||
> !(rdev->wpan_phy.supported.iftypes & BIT(type)))
> return -EINVAL;
> }
>
prev parent reply other threads:[~2021-11-11 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 12:51 [PATCH] net: ieee802154: fix shift-out-of-bound in nl802154_new_interface Dongliang Mu
2021-11-11 13:19 ` Denis Kirjanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a1969b0-f5ad-d5b4-0c66-14e65fdcd0dd@suse.de \
--to=dkirjanov@suse.de \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=mudongliangabcd@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).