* [PATCH] net: ieee802154: fix shift-out-of-bound in nl802154_new_interface
@ 2021-11-11 12:51 Dongliang Mu
2021-11-11 13:19 ` Denis Kirjanov
0 siblings, 1 reply; 2+ messages in thread
From: Dongliang Mu @ 2021-11-11 12:51 UTC (permalink / raw)
To: Alexander Aring, Stefan Schmidt, David S. Miller, Jakub Kicinski
Cc: Dongliang Mu, linux-wpan, netdev, linux-kernel
In nl802154_new_interface, if type retrieved from info->attr is
NL802154_IFTYPE_UNSPEC(-1), i.e., less than NL802154_IFTYPE_MAX,
it will trigger a shift-out-of-bound bug in BIT(type).
Fix this by adding a condition to check if the variable type is
larger than NL802154_IFTYPE_UNSPEC(-1).
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
net/ieee802154/nl802154.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index 277124f206e0..cecf5ce0aa20 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -915,7 +915,7 @@ static int nl802154_new_interface(struct sk_buff *skb, struct genl_info *info)
if (info->attrs[NL802154_ATTR_IFTYPE]) {
type = nla_get_u32(info->attrs[NL802154_ATTR_IFTYPE]);
- if (type > NL802154_IFTYPE_MAX ||
+ if (type <= NL802154_IFTYPE_UNSPEC || type > NL802154_IFTYPE_MAX ||
!(rdev->wpan_phy.supported.iftypes & BIT(type)))
return -EINVAL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ieee802154: fix shift-out-of-bound in nl802154_new_interface
2021-11-11 12:51 [PATCH] net: ieee802154: fix shift-out-of-bound in nl802154_new_interface Dongliang Mu
@ 2021-11-11 13:19 ` Denis Kirjanov
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kirjanov @ 2021-11-11 13:19 UTC (permalink / raw)
To: Dongliang Mu, Alexander Aring, Stefan Schmidt, David S. Miller,
Jakub Kicinski
Cc: linux-wpan, netdev, linux-kernel
11/11/21 3:51 PM, Dongliang Mu пишет:
> In nl802154_new_interface, if type retrieved from info->attr is
> NL802154_IFTYPE_UNSPEC(-1), i.e., less than NL802154_IFTYPE_MAX,
> it will trigger a shift-out-of-bound bug in BIT(type).
>
> Fix this by adding a condition to check if the variable type is
> larger than NL802154_IFTYPE_UNSPEC(-1).
Please add Fixes tag
>
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
> net/ieee802154/nl802154.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
> index 277124f206e0..cecf5ce0aa20 100644
> --- a/net/ieee802154/nl802154.c
> +++ b/net/ieee802154/nl802154.c
> @@ -915,7 +915,7 @@ static int nl802154_new_interface(struct sk_buff *skb, struct genl_info *info)
>
> if (info->attrs[NL802154_ATTR_IFTYPE]) {
> type = nla_get_u32(info->attrs[NL802154_ATTR_IFTYPE]);
> - if (type > NL802154_IFTYPE_MAX ||
> + if (type <= NL802154_IFTYPE_UNSPEC || type > NL802154_IFTYPE_MAX ||
> !(rdev->wpan_phy.supported.iftypes & BIT(type)))
> return -EINVAL;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-11 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 12:51 [PATCH] net: ieee802154: fix shift-out-of-bound in nl802154_new_interface Dongliang Mu
2021-11-11 13:19 ` Denis Kirjanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).