* [PATCH] scsi: megaraid_sas: add in missing white space in error message text
@ 2016-09-12 12:42 Colin King
2016-09-13 11:51 ` Sumit Saxena
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Colin King @ 2016-09-12 12:42 UTC (permalink / raw)
To: Kashyap Desai, Sumit Saxena, Uday Lingala,
James E . J . Bottomley, Martin K . Petersen, megaraidlinux.pdl,
linux-scsi
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
A dev_printk message spans two lines and the literal string is missing
a white space between words. Add the white space.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 2d62d71..c236c4d 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5782,7 +5782,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
&instance->consumer_h);
if (!instance->producer || !instance->consumer) {
- dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate"
+ dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate "
"memory for producer, consumer\n");
goto fail_alloc_dma_buf;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi: megaraid_sas: add in missing white space in error message text
2016-09-12 12:42 [PATCH] scsi: megaraid_sas: add in missing white space in error message text Colin King
@ 2016-09-13 11:51 ` Sumit Saxena
2016-09-14 13:23 ` Hannes Reinecke
2016-09-14 17:13 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Sumit Saxena @ 2016-09-13 11:51 UTC (permalink / raw)
To: Colin King, Kashyap Desai, Sumit Saxena, Uday Lingala,
James E . J . Bottomley, Martin K . Petersen, megaraidlinux.pdl,
linux-scsi
Cc: linux-kernel
>-----Original Message-----
>From: Colin King [mailto:colin.king@canonical.com]
>Sent: Monday, September 12, 2016 6:12 PM
>To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E . J . Bottomley;
>Martin K
>. Petersen; megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org
>Cc: linux-kernel@vger.kernel.org
>Subject: [PATCH] scsi: megaraid_sas: add in missing white space in error
>message
>text
>
>From: Colin Ian King <colin.king@canonical.com>
>
>A dev_printk message spans two lines and the literal string is missing a
>white
>space between words. Add the white space.
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 2d62d71..c236c4d 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -5782,7 +5782,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
> &instance->consumer_h);
>
> if (!instance->producer || !instance->consumer) {
>- dev_printk(KERN_DEBUG, &pdev->dev, "Failed to
>allocate"
>+ dev_printk(KERN_DEBUG, &pdev->dev, "Failed to
>allocate "
> "memory for producer, consumer\n");
> goto fail_alloc_dma_buf;
> }
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
>--
>2.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: megaraid_sas: add in missing white space in error message text
2016-09-12 12:42 [PATCH] scsi: megaraid_sas: add in missing white space in error message text Colin King
2016-09-13 11:51 ` Sumit Saxena
@ 2016-09-14 13:23 ` Hannes Reinecke
2016-09-14 17:13 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2016-09-14 13:23 UTC (permalink / raw)
To: Colin King, Kashyap Desai, Sumit Saxena, Uday Lingala,
James E . J . Bottomley, Martin K . Petersen, megaraidlinux.pdl,
linux-scsi
Cc: linux-kernel
On 09/12/2016 02:42 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A dev_printk message spans two lines and the literal string is missing
> a white space between words. Add the white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 2d62d71..c236c4d 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5782,7 +5782,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
> &instance->consumer_h);
>
> if (!instance->producer || !instance->consumer) {
> - dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate"
> + dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate "
> "memory for producer, consumer\n");
> goto fail_alloc_dma_buf;
> }
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: megaraid_sas: add in missing white space in error message text
2016-09-12 12:42 [PATCH] scsi: megaraid_sas: add in missing white space in error message text Colin King
2016-09-13 11:51 ` Sumit Saxena
2016-09-14 13:23 ` Hannes Reinecke
@ 2016-09-14 17:13 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2016-09-14 17:13 UTC (permalink / raw)
To: Colin King
Cc: Kashyap Desai, Sumit Saxena, Uday Lingala,
James E . J . Bottomley, Martin K . Petersen, megaraidlinux.pdl,
linux-scsi, linux-kernel
>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:
Colin> From: Colin Ian King <colin.king@canonical.com> A dev_printk
Colin> message spans two lines and the literal string is missing a white
Colin> space between words. Add the white space.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-14 17:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 12:42 [PATCH] scsi: megaraid_sas: add in missing white space in error message text Colin King
2016-09-13 11:51 ` Sumit Saxena
2016-09-14 13:23 ` Hannes Reinecke
2016-09-14 17:13 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).