From: Yunus Bas <Y.Bas@phytec.de>
To: "lee.jones@linaro.org" <lee.jones@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: mfd-core: Change "Failed to locate of_node" warning to debug
Date: Thu, 17 Jun 2021 07:46:33 +0000 [thread overview]
Message-ID: <5a3f5fd82a391ade9a659338983e5efa7924210d.camel@phytec.de> (raw)
In-Reply-To: <YMm+VXRrRKIHGgmr@dell>
Hi Lee,
Am Mittwoch, dem 16.06.2021 um 10:03 +0100 schrieb Lee Jones:
> On Wed, 16 Jun 2021, Yunus Bas wrote:
>
> > The MFD-core iterates through all subdevices of the corresponding
> > MFD-device and checks, if the devicetree subnode has a fitting
> > compatible.
> > When nothing is found, a warning is thrown. This can be the case,
> > when it
> > is the intention to not use the MFD-device to it's full content.
> > Therefore, change the warning to a debug print instead, to also avoid
> > irritations.
> >
> > Signed-off-by: Yunus Bas <y.bas@phytec.de>
> > ---
> > drivers/mfd/mfd-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> > index 6f02b8022c6d..e34c97088943 100644
> > --- a/drivers/mfd/mfd-core.c
> > +++ b/drivers/mfd/mfd-core.c
> > @@ -213,7 +213,7 @@ static int mfd_add_device(struct device *parent,
> > int id,
> > }
> >
> > if (!pdev->dev.of_node)
> > - pr_warn("%s: Failed to locate of_node [id:
> > %d]\n",
> > + pr_debug("%s: Failed to locate of_node [id:
> > %d]\n",
> > cell->name, platform_id);
> > }
>
> Can you provide an example of a device tree where this is a problem?
Of course, sorry for the poor description.
Here is an example of the imx6qdl-phytec-phycore-som.dtsi which uses
the DA9062 multi-functional device. The DA9062 has five mfd-cell
devices with compatibles defined as subfunctions. The devicetree needs
and uses just three of them:
...
pmic: pmic@58 {
compatible = "dlg,da9062";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_pmic>;
reg = <0x58>;
interrupt-parent = <&gpio1>;
interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
interrupt-controller;
gpio-controller;
#gpio-cells = <2>;
da9062_rtc: rtc {
compatible = "dlg,da9062-rtc";
};
da9062_onkey: onkey {
compatible = "dlg,da9062-onkey";
};
watchdog {
compatible = "dlg,da9062-watchdog";
dlg,use-sw-pm;
}
...
Since the driver iterates through the mfd_cells-struct tries matching
compatibles in the devicetree MFD node, it throws a warning when there
is no counterpart in the devicetree.
In fact, I could also evalutate oder devicetree's using MFD-devices not
to it's full content.
>
> Probably worth popping that in the commit message too.
>
Yes, I will send a v2 ASAP. Thank you for the advice.
Regards,
Yunus
--
Mit freundlichen Grüßen
Yunus Bas
-Software Engineer-
PHYTEC Messtechnik GmbH
Robert-Koch-Str. 39
55129 Mainz
Germany
Tel.: +49 (0)6131 9221- 466
Web: www.phytec.de
Sie finden uns auch auf: Facebook, LinkedIn, Xing, YouTube
PHYTEC Messtechnik GmbH | Robert-Koch-Str. 39 | 55129 Mainz, Germany
Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber |
Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 266500608, DE
149059855
This E-Mail may contain confidential or privileged information. If you
are not the intended recipient (or have received this E-Mail in error)
please notify the sender immediately and destroy this E-Mail. Any
unauthorized copying, disclosure or distribution of the material in
this E-Mail is strictly forbidden.
next prev parent reply other threads:[~2021-06-17 7:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 8:19 [PATCH] mfd: mfd-core: Change "Failed to locate of_node" warning to debug Yunus Bas
2021-06-16 9:03 ` Lee Jones
2021-06-17 7:46 ` Yunus Bas [this message]
2021-06-17 8:27 ` Lee Jones
2021-06-29 7:25 ` Yunus Bas
2021-06-29 9:07 ` Lee Jones
2021-06-29 9:41 ` Yunus Bas
2021-06-29 13:39 ` Lee Jones
2021-06-30 7:27 ` Yunus Bas
2021-06-30 8:42 ` Lee Jones
2021-06-30 10:55 ` Daniel Thompson
2021-06-30 12:33 ` Lee Jones
2021-07-01 15:34 ` Yunus Bas
2021-07-01 16:45 ` Lee Jones
2021-07-02 12:59 ` Daniel Thompson
2021-07-02 18:36 ` Lee Jones
2021-07-02 19:10 ` Daniel Thompson
2021-07-05 7:24 ` Yunus Bas
2021-07-05 7:31 ` Lee Jones
2021-07-05 7:50 ` Yunus Bas
2021-07-05 8:05 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a3f5fd82a391ade9a659338983e5efa7924210d.camel@phytec.de \
--to=y.bas@phytec.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).