From: Lee Jones <lee.jones@linaro.org>
To: Yunus Bas <Y.Bas@phytec.de>
Cc: "daniel.thompson@linaro.org" <daniel.thompson@linaro.org>,
"stwiss.opensource@diasemi.com" <stwiss.opensource@diasemi.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: mfd-core: Change "Failed to locate of_node" warning to debug
Date: Mon, 5 Jul 2021 09:05:55 +0100 [thread overview]
Message-ID: <YOK9Yyc31lKr6BzA@dell> (raw)
In-Reply-To: <614d720b0f468334e74a4e29b626d498f25a7c31.camel@phytec.de>
On Mon, 05 Jul 2021, Yunus Bas wrote:
> Am Montag, dem 05.07.2021 um 08:31 +0100 schrieb Lee Jones:
> > On Mon, 05 Jul 2021, Yunus Bas wrote:
> >
> > > Thank you for the clarification. I'm now aware on how to handle
> > > MFD's
> > > in the devicetree. But given this, the default behavior of MFD's
> > > should
> > > definitely be documented since i could see many other devicetree
> > > examples handling this also not in the proper manner.
> >
> > In the 8 years I've been working with DT and MFD, this is the first
> > time this particular issue has arisen, but if you'd like to submit
> > such a document, it will be considered for inclusion.
>
> This is because on older kernel versions (or at least on the last LTS)
> there was no warning in the first place. The warning was added with the
> following patch of yours:
>
> Commit 466a62d7642f ("mfd: core: Make a best effort attempt to match
> devices with the correct of_nodes")
Right. The implementation was decidedly more broken before this and
many sins were lying dormant. Fortunately, we now have an early
warning system which should catch these kinds of misdemeanours during
initial implementation.
You make a good point about LTS' though.
I'll be sure to keep this in mind as more people update.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-07-05 8:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 8:19 [PATCH] mfd: mfd-core: Change "Failed to locate of_node" warning to debug Yunus Bas
2021-06-16 9:03 ` Lee Jones
2021-06-17 7:46 ` Yunus Bas
2021-06-17 8:27 ` Lee Jones
2021-06-29 7:25 ` Yunus Bas
2021-06-29 9:07 ` Lee Jones
2021-06-29 9:41 ` Yunus Bas
2021-06-29 13:39 ` Lee Jones
2021-06-30 7:27 ` Yunus Bas
2021-06-30 8:42 ` Lee Jones
2021-06-30 10:55 ` Daniel Thompson
2021-06-30 12:33 ` Lee Jones
2021-07-01 15:34 ` Yunus Bas
2021-07-01 16:45 ` Lee Jones
2021-07-02 12:59 ` Daniel Thompson
2021-07-02 18:36 ` Lee Jones
2021-07-02 19:10 ` Daniel Thompson
2021-07-05 7:24 ` Yunus Bas
2021-07-05 7:31 ` Lee Jones
2021-07-05 7:50 ` Yunus Bas
2021-07-05 8:05 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOK9Yyc31lKr6BzA@dell \
--to=lee.jones@linaro.org \
--cc=Y.Bas@phytec.de \
--cc=daniel.thompson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).