From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Zhang, Rui" <rui.zhang@intel.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] Thermal ACPI APIs for generic trip points
Date: Wed, 18 Jan 2023 11:01:01 -0800 [thread overview]
Message-ID: <5aabdd3010a02e361fbbe01f4af0e30d11f0ae6b.camel@linux.intel.com> (raw)
In-Reply-To: <2627c37e07dce6b125d3fea3bf38a5f2407ad6a1.camel@intel.com>
On Wed, 2023-01-18 at 13:48 +0000, Zhang, Rui wrote:
> On Wed, 2023-01-18 at 10:53 +0100, Daniel Lezcano wrote:
> > Hi,
> >
> > On 13/01/2023 19:02, Daniel Lezcano wrote:
> > > Recently sent as a RFC, the thermal ACPI for generic trip points
> > > is
> > > a set of
> > > functions to fill the generic trip points structure which will
> > > become the
> > > standard structure for the thermal framework and its users.
> > >
> > > Different Intel drivers and the ACPI thermal driver are using the
> > > ACPI tables to
> > > get the thermal zone information. As those are getting the same
> > > information,
> > > providing this set of ACPI function with the generic trip points
> > > will
> > > consolidate the code.
> > >
> > > Also, the Intel PCH and the Intel 34xx drivers are converted to
> > > use
> > > the generic
> > > trip points relying on the ACPI generic trip point parsing
> > > functions.
> > >
> > > These changes have been tested on a Thinkpad Lenovo x280 with the
> > > PCH and
> > > INT34xx drivers. No regression have been observed, the trip
> > > points
> > > remain the
> > > same for what is described on this system.
> >
> > Are we ok with this series ?
> >
> > Sorry for insisting but I would like to go forward with the generic
> > thermal trip work. There are more patches pending depending on this
> > series.
>
> The whole series looks good to me.
>
> Reviwed-by: Zhang Rui <rui.zhang@intel.com>
>
> But we'd better wait for the thermald test result from Srinvias.
A quick test show that things still work with thermald and these
changes.
Thanks,
Srinivas
>
> thanks,
> rui
> >
> > Thanks
> > -- Daniel
> >
> > > Changelog:
> > > - V5:
> > > - Fixed GTSH unit conversion, deciK -> milli C
> > >
> > > - V4:
> > > - Fixed Kconfig option dependency, select THERMAL_ACPI if
> > > ACPI
> > > is set
> > > only for the PCH driver
> > >
> > > - V3:
> > > - Took into account Rafael's comments
> > > - Used a silence option THERMAL_ACPI in order to stay
> > > consistent
> > > with THERMAL_OF. It is up to the API user to select the
> > > option.
> > >
> > > - V2:
> > > - Fix the thermal ACPI patch where the thermal_acpi.c was not
> > > included in
> > > the series
> > > - Provide a couple of users of this API which could have been
> > > tested on a
> > > real system
> > >
> > > Daniel Lezcano (3):
> > > thermal/acpi: Add ACPI trip point routines
> > > thermal/drivers/intel: Use generic trip points for intel_pch
> > > thermal/drivers/intel: Use generic trip points int340x
> > >
> > > drivers/thermal/Kconfig | 4 +
> > > drivers/thermal/Makefile | 1 +
> > > drivers/thermal/intel/Kconfig | 1 +
> > > drivers/thermal/intel/int340x_thermal/Kconfig | 1 +
> > > .../int340x_thermal/int340x_thermal_zone.c | 177 ++++-------
> > > --
> > > --
> > > .../int340x_thermal/int340x_thermal_zone.h | 10 +-
> > > drivers/thermal/intel/intel_pch_thermal.c | 88 ++------
> > > drivers/thermal/thermal_acpi.c | 210
> > > ++++++++++++++++++
> > > include/linux/thermal.h | 8 +
> > > 9 files changed, 286 insertions(+), 214 deletions(-)
> > > create mode 100644 drivers/thermal/thermal_acpi.c
> > >
next prev parent reply other threads:[~2023-01-18 19:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 18:02 [PATCH v5 0/3] Thermal ACPI APIs for generic trip points Daniel Lezcano
2023-01-13 18:02 ` [PATCH v5 1/3] thermal/acpi: Add ACPI trip point routines Daniel Lezcano
2023-01-19 13:15 ` Rafael J. Wysocki
2023-01-20 18:08 ` Daniel Lezcano
2023-01-20 18:15 ` Rafael J. Wysocki
2023-01-20 18:27 ` Daniel Lezcano
2023-01-20 18:47 ` Rafael J. Wysocki
2023-01-13 18:02 ` [PATCH v5 2/3] thermal/drivers/intel: Use generic trip points for intel_pch Daniel Lezcano
2023-01-13 18:02 ` [PATCH v5 3/3] thermal/drivers/intel: Use generic trip points int340x Daniel Lezcano
2023-01-18 9:53 ` [PATCH v5 0/3] Thermal ACPI APIs for generic trip points Daniel Lezcano
2023-01-18 13:48 ` Zhang, Rui
2023-01-18 13:54 ` Daniel Lezcano
2023-01-18 19:01 ` srinivas pandruvada [this message]
2023-01-18 19:14 ` Daniel Lezcano
2023-01-18 19:16 ` srinivas pandruvada
2023-01-18 20:00 ` Daniel Lezcano
2023-01-18 20:53 ` srinivas pandruvada
2023-01-18 21:01 ` Daniel Lezcano
2023-01-18 21:16 ` srinivas pandruvada
2023-01-18 22:14 ` Daniel Lezcano
2023-01-18 23:04 ` srinivas pandruvada
2023-01-19 12:17 ` Rafael J. Wysocki
2023-01-19 16:58 ` srinivas pandruvada
2023-01-19 17:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aabdd3010a02e361fbbe01f4af0e30d11f0ae6b.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel.lezcano@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).