From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
"Zhang, Rui" <rui.zhang@intel.com>,
"rafael@kernel.org" <rafael@kernel.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] Thermal ACPI APIs for generic trip points
Date: Wed, 18 Jan 2023 12:53:31 -0800 [thread overview]
Message-ID: <8547963350fb3bdb09a4693f0eb80c7199ab6f21.camel@linux.intel.com> (raw)
In-Reply-To: <c210542f-0a71-15f2-c58f-ec607e60b06d@linaro.org>
On Wed, 2023-01-18 at 21:00 +0100, Daniel Lezcano wrote:
> On 18/01/2023 20:16, srinivas pandruvada wrote:
>
> [ ... ]
>
> > > > But we'd better wait for the thermald test result from
> > > > Srinvias.
> > >
> > > A quick test show that things still work with thermald and these
> > > changes.
> >
> > But I have a question. In some devices trip point temperature is
> > not
> > static. When hardware changes, we get notification. For example
> > INT3403_PERF_TRIP_POINT_CHANGED for INT3403 drivers.
> > Currently get_trip can get the latest changed value. But if we
> > preregister, we need some mechanism to update them.
>
> When the notification INT3403_PERF_TRIP_POINT_CHANGED happens, we
> call
> int340x_thermal_read_trips() which in turn updates the trip points.
>
Not sure how we handle concurrency here when driver can freely update
trips while thermal core is using trips.
Thanks,
Srinivas
>
>
next prev parent reply other threads:[~2023-01-18 20:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 18:02 [PATCH v5 0/3] Thermal ACPI APIs for generic trip points Daniel Lezcano
2023-01-13 18:02 ` [PATCH v5 1/3] thermal/acpi: Add ACPI trip point routines Daniel Lezcano
2023-01-19 13:15 ` Rafael J. Wysocki
2023-01-20 18:08 ` Daniel Lezcano
2023-01-20 18:15 ` Rafael J. Wysocki
2023-01-20 18:27 ` Daniel Lezcano
2023-01-20 18:47 ` Rafael J. Wysocki
2023-01-13 18:02 ` [PATCH v5 2/3] thermal/drivers/intel: Use generic trip points for intel_pch Daniel Lezcano
2023-01-13 18:02 ` [PATCH v5 3/3] thermal/drivers/intel: Use generic trip points int340x Daniel Lezcano
2023-01-18 9:53 ` [PATCH v5 0/3] Thermal ACPI APIs for generic trip points Daniel Lezcano
2023-01-18 13:48 ` Zhang, Rui
2023-01-18 13:54 ` Daniel Lezcano
2023-01-18 19:01 ` srinivas pandruvada
2023-01-18 19:14 ` Daniel Lezcano
2023-01-18 19:16 ` srinivas pandruvada
2023-01-18 20:00 ` Daniel Lezcano
2023-01-18 20:53 ` srinivas pandruvada [this message]
2023-01-18 21:01 ` Daniel Lezcano
2023-01-18 21:16 ` srinivas pandruvada
2023-01-18 22:14 ` Daniel Lezcano
2023-01-18 23:04 ` srinivas pandruvada
2023-01-19 12:17 ` Rafael J. Wysocki
2023-01-19 16:58 ` srinivas pandruvada
2023-01-19 17:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8547963350fb3bdb09a4693f0eb80c7199ab6f21.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel.lezcano@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).