[PATCH 0/4] mfd/pwm: dt-bindings: google,cros-ec: include generic pwm schema

[PATCH 0/4] mfd/pwm: dt-bindings: google,cros-ec: include generic pwm schema

[Krzysztof Kozlowski]

Hi,

DTS patches are independent. Not tested, but I really hope no downstream kernel
depends on pwm node naming... If it does, please change it to compatible. :)

Best regards,
Krzysztof

Krzysztof Kozlowski (4):
  dt-bindings: pwm: google,cros-ec: include generic pwm schema
  arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema
  arm64: dts: qcom: align Google CROS EC PWM node name with dtschema
  arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema

 Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++
 .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml          | 5 ++++-
 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi       | 2 +-
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi                 | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts   | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi               | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi               | 2 +-
 arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi                   | 2 +-
 arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi      | 2 +-
 9 files changed, 15 insertions(+), 8 deletions(-)

-- 
2.32.0

[PATCH 1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema

[Krzysztof Kozlowski]

Include generic pwm.yaml schema, which enforces PWM node naming.  Keep
the old name in bindings as deprecated.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++
 .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml          | 5 ++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
index d1f53bd449f7..0255b7028496 100644
--- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
+++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
@@ -89,6 +89,10 @@ properties:
 
   ec-pwm:
     $ref: "/schemas/pwm/google,cros-ec-pwm.yaml#"
+    deprecated: true
+
+  pwm:
+    $ref: "/schemas/pwm/google,cros-ec-pwm.yaml#"
 
   keyboard-controller:
     $ref: "/schemas/input/google,cros-ec-keyb.yaml#"
diff --git a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml
index 4cfbffd8414a..7ab6912a845f 100644
--- a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml
@@ -16,6 +16,9 @@ description: |
   An EC PWM node should be only found as a sub-node of the EC node (see
   Documentation/devicetree/bindings/mfd/google,cros-ec.yaml).
 
+allOf:
+  - $ref: pwm.yaml#
+
 properties:
   compatible:
     const: google,cros-ec-pwm
@@ -39,7 +42,7 @@ examples:
             compatible = "google,cros-ec-spi";
             reg = <0>;
 
-            cros_ec_pwm: ec-pwm {
+            cros_ec_pwm: pwm {
                 compatible = "google,cros-ec-pwm";
                 #pwm-cells = <1>;
             };
-- 
2.32.0

[PATCH 2/4] arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema

[Krzysztof Kozlowski]

dtschema expects PWM node name to be a generic "pwm".  This also matches
Devicetree specification requirements about generic node names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
index 8f7bf33f607d..2d7a193272ae 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
@@ -92,7 +92,7 @@ volume_up {
 };
 
 &cros_ec {
-	cros_ec_pwm: ec-pwm {
+	cros_ec_pwm: pwm {
 		compatible = "google,cros-ec-pwm";
 		#pwm-cells = <1>;
 		status = "disabled";
-- 
2.32.0

[PATCH 3/4] arm64: dts: qcom: align Google CROS EC PWM node name with dtschema

[Krzysztof Kozlowski]

dtschema expects PWM node name to be a generic "pwm".  This also matches
Devicetree specification requirements about generic node names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi               | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi             | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi             | 2 +-
 arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi                 | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 78296ed6fd29..732e1181af48 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -637,7 +637,7 @@ cros_ec: ec@0 {
 		pinctrl-0 = <&ap_ec_int_l>;
 		spi-max-frequency = <3000000>;
 
-		cros_ec_pwm: ec-pwm {
+		cros_ec_pwm: pwm {
 			compatible = "google,cros-ec-pwm";
 			#pwm-cells = <1>;
 		};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts
index af46a60b4b98..1779d96c30f6 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts
@@ -705,7 +705,7 @@ cros_ec: ec@0 {
 		pinctrl-0 = <&ap_ec_int_l>;
 		spi-max-frequency = <3000000>;
 
-		cros_ec_pwm: ec-pwm {
+		cros_ec_pwm: pwm {
 			compatible = "google,cros-ec-pwm";
 			#pwm-cells = <1>;
 		};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index 7c22f0b062be..dc17f2079695 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -421,7 +421,7 @@ cros_ec: ec@0 {
 		pinctrl-0 = <&ap_ec_int_l>;
 		spi-max-frequency = <3000000>;
 
-		cros_ec_pwm: ec-pwm {
+		cros_ec_pwm: pwm {
 			compatible = "google,cros-ec-pwm";
 			#pwm-cells = <1>;
 		};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi
index 0896a6151817..a7c346aa3b02 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi
@@ -20,7 +20,7 @@ cros_ec: ec@0 {
 		pinctrl-0 = <&ap_ec_int_l>;
 		spi-max-frequency = <3000000>;
 
-		cros_ec_pwm: ec-pwm {
+		cros_ec_pwm: pwm {
 			compatible = "google,cros-ec-pwm";
 			#pwm-cells = <1>;
 		};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index 4a6285a25f77..e7e4cc5936aa 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -708,7 +708,7 @@ cros_ec: ec@0 {
 		pinctrl-0 = <&ec_ap_int_l>;
 		spi-max-frequency = <3000000>;
 
-		cros_ec_pwm: ec-pwm {
+		cros_ec_pwm: pwm {
 			compatible = "google,cros-ec-pwm";
 			#pwm-cells = <1>;
 		};
-- 
2.32.0

[PATCH 4/4] arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema

[Krzysztof Kozlowski]

dtschema expects PWM node name to be a generic "pwm".  This also matches
Devicetree specification requirements about generic node names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
index 9b2c679f5eca..3355fb90fa54 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
@@ -462,7 +462,7 @@ ap_i2c_tp: &i2c5 {
 };
 
 &cros_ec {
-	cros_ec_pwm: ec-pwm {
+	cros_ec_pwm: pwm {
 		compatible = "google,cros-ec-pwm";
 		#pwm-cells = <1>;
 	};
-- 
2.32.0

Re: [PATCH 2/4] arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema

[AngeloGioacchino Del Regno]

Il 14/02/22 09:19, Krzysztof Kozlowski ha scritto:
> dtschema expects PWM node name to be a generic "pwm".  This also matches
> Devicetree specification requirements about generic node names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> index 8f7bf33f607d..2d7a193272ae 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> @@ -92,7 +92,7 @@ volume_up {
>   };
>   
>   &cros_ec {
> -	cros_ec_pwm: ec-pwm {
> +	cros_ec_pwm: pwm {
>   		compatible = "google,cros-ec-pwm";
>   		#pwm-cells = <1>;
>   		status = "disabled";

Re: [PATCH 3/4] arm64: dts: qcom: align Google CROS EC PWM node name with dtschema

[Doug Anderson]

Hi,

On Mon, Feb 14, 2022 at 12:20 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> dtschema expects PWM node name to be a generic "pwm".  This also matches
> Devicetree specification requirements about generic node names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi               | 2 +-
>  arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts | 2 +-
>  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi             | 2 +-
>  arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi             | 2 +-
>  arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi                 | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Re: [PATCH 4/4] arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema

[Doug Anderson]

Hi,

On Mon, Feb 14, 2022 at 12:20 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> dtschema expects PWM node name to be a generic "pwm".  This also matches
> Devicetree specification requirements about generic node names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Re: [PATCH 1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema

[Rob Herring]

On Mon, 14 Feb 2022 09:19:13 +0100, Krzysztof Kozlowski wrote:
> Include generic pwm.yaml schema, which enforces PWM node naming.  Keep
> the old name in bindings as deprecated.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++
>  .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml          | 5 ++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: (subset) [PATCH 0/4] mfd/pwm: dt-bindings: google, cros-ec: include generic pwm schema

[Heiko Stuebner]

On Mon, 14 Feb 2022 09:19:12 +0100, Krzysztof Kozlowski wrote:
> DTS patches are independent. Not tested, but I really hope no downstream kernel
> depends on pwm node naming... If it does, please change it to compatible. :)
> 
> Best regards,
> Krzysztof
> 
> Krzysztof Kozlowski (4):
>   dt-bindings: pwm: google,cros-ec: include generic pwm schema
>   arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema
>   arm64: dts: qcom: align Google CROS EC PWM node name with dtschema
>   arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema
> 
> [...]

Applied, thanks!

[4/4] arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema
      commit: 474a84be692d893f45a54b405dcbc137cbf77949

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: (subset) [PATCH 0/4] mfd/pwm: dt-bindings: google, cros-ec: include generic pwm schema

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

Hello,

On Wed, Feb 23, 2022 at 12:27:08AM +0100, Heiko Stuebner wrote:
> On Mon, 14 Feb 2022 09:19:12 +0100, Krzysztof Kozlowski wrote:
> > DTS patches are independent. Not tested, but I really hope no downstream kernel
> > depends on pwm node naming... If it does, please change it to compatible. :)
> > 
> > Best regards,
> > Krzysztof
> > 
> > Krzysztof Kozlowski (4):
> >   dt-bindings: pwm: google,cros-ec: include generic pwm schema
> >   arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema
> >   arm64: dts: qcom: align Google CROS EC PWM node name with dtschema
> >   arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema
> > 
> > [...]
> 
> Applied, thanks!
> 
> [4/4] arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema
>       commit: 474a84be692d893f45a54b405dcbc137cbf77949

I expected that all patches in this series go in together via an ARM
tree. Or are there expectations that this goes via PWM?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: (subset) [PATCH 0/4] mfd/pwm: dt-bindings: google, cros-ec: include generic pwm schema

[Krzysztof Kozlowski]

On 23/02/2022 07:22, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Feb 23, 2022 at 12:27:08AM +0100, Heiko Stuebner wrote:
>> On Mon, 14 Feb 2022 09:19:12 +0100, Krzysztof Kozlowski wrote:
>>> DTS patches are independent. Not tested, but I really hope no downstream kernel
>>> depends on pwm node naming... If it does, please change it to compatible. :)
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>> Krzysztof Kozlowski (4):
>>>   dt-bindings: pwm: google,cros-ec: include generic pwm schema
>>>   arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema
>>>   arm64: dts: qcom: align Google CROS EC PWM node name with dtschema
>>>   arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [4/4] arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema
>>       commit: 474a84be692d893f45a54b405dcbc137cbf77949
> 
> I expected that all patches in this series go in together via an ARM
> tree. Or are there expectations that this goes via PWM?

I would propose to pick individual patches by each maintainer. bindings
by PWM tree (Rob acked it) and DTS via each SoC tree.

Such approach gives flexibility, although `make dtbs_check` will spot
the new errors when run in PWM tree. Next will be fine, though.

Best regards,
Krzysztof

Re: [PATCH 1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema

[Lee Jones]

On Mon, 14 Feb 2022, Krzysztof Kozlowski wrote:

> Include generic pwm.yaml schema, which enforces PWM node naming.  Keep
> the old name in bindings as deprecated.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++

Acked-by: Lee Jones <lee.jones@linaro.org>

>  .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml          | 5 ++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema

[Heiko Stuebner]

Hi Lee,

Am Mittwoch, 23. Februar 2022, 10:16:01 CET schrieb Lee Jones:
> On Mon, 14 Feb 2022, Krzysztof Kozlowski wrote:
> 
> > Include generic pwm.yaml schema, which enforces PWM node naming.  Keep
> > the old name in bindings as deprecated.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>

what is your expectation regarding this patch?

Are you planning to merge it or are you expecting this to go through
some other tree?

The binding-change here is backward-comaptible in that the old
node-name is still in it, only marked as deprecated, so in theory
this patch should be able to be applied on its own without
causing defects.


Heiko

> 
> >  .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml          | 5 ++++-
> >  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> 

Re: [PATCH 1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema

[Lee Jones]

On Wed, 23 Feb 2022, Heiko Stuebner wrote:

> Hi Lee,
> 
> Am Mittwoch, 23. Februar 2022, 10:16:01 CET schrieb Lee Jones:
> > On Mon, 14 Feb 2022, Krzysztof Kozlowski wrote:
> > 
> > > Include generic pwm.yaml schema, which enforces PWM node naming.  Keep
> > > the old name in bindings as deprecated.
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > > ---
> > >  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++
> > 
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> 
> what is your expectation regarding this patch?
> 
> Are you planning to merge it or are you expecting this to go through
> some other tree?
> 
> The binding-change here is backward-comaptible in that the old
> node-name is still in it, only marked as deprecated, so in theory
> this patch should be able to be applied on its own without
> causing defects.

In an ideal world, it would be broken up and I would take the MFD
part.   Is that possible or are there dependencies?

Or, worse still, does the whole set need to be applied at once?

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema

[Heiko Stuebner]

Am Donnerstag, 24. Februar 2022, 11:02:48 CET schrieb Lee Jones:
> On Wed, 23 Feb 2022, Heiko Stuebner wrote:
> 
> > Hi Lee,
> > 
> > Am Mittwoch, 23. Februar 2022, 10:16:01 CET schrieb Lee Jones:
> > > On Mon, 14 Feb 2022, Krzysztof Kozlowski wrote:
> > > 
> > > > Include generic pwm.yaml schema, which enforces PWM node naming.  Keep
> > > > the old name in bindings as deprecated.
> > > > 
> > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++
> > > 
> > > Acked-by: Lee Jones <lee.jones@linaro.org>
> > 
> > what is your expectation regarding this patch?
> > 
> > Are you planning to merge it or are you expecting this to go through
> > some other tree?
> > 
> > The binding-change here is backward-comaptible in that the old
> > node-name is still in it, only marked as deprecated, so in theory
> > this patch should be able to be applied on its own without
> > causing defects.
> 
> In an ideal world, it would be broken up and I would take the MFD
> part.   Is that possible or are there dependencies?

That is also what Krzysztof had in mind - see his reply to patch4.
Binding going through the MFD tree and soc maintainers applying
the individual dts patches.

As written the binding change is backward compatible, so no harm.

I was just confused by the "Acked-by" and wanted to clarify how you
see it ;-)


Heiko

Re: [PATCH 1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema

[Krzysztof Kozlowski]

On 24/02/2022 11:06, Heiko Stuebner wrote:
> Am Donnerstag, 24. Februar 2022, 11:02:48 CET schrieb Lee Jones:
>> On Wed, 23 Feb 2022, Heiko Stuebner wrote:
>>
>>> Hi Lee,
>>>
>>> Am Mittwoch, 23. Februar 2022, 10:16:01 CET schrieb Lee Jones:
>>>> On Mon, 14 Feb 2022, Krzysztof Kozlowski wrote:
>>>>
>>>>> Include generic pwm.yaml schema, which enforces PWM node naming.  Keep
>>>>> the old name in bindings as deprecated.
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>>> ---
>>>>>  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++
>>>>
>>>> Acked-by: Lee Jones <lee.jones@linaro.org>
>>>
>>> what is your expectation regarding this patch?
>>>
>>> Are you planning to merge it or are you expecting this to go through
>>> some other tree?
>>>
>>> The binding-change here is backward-comaptible in that the old
>>> node-name is still in it, only marked as deprecated, so in theory
>>> this patch should be able to be applied on its own without
>>> causing defects.
>>
>> In an ideal world, it would be broken up and I would take the MFD
>> part.   Is that possible or are there dependencies?
> 
> That is also what Krzysztof had in mind - see his reply to patch4.
> Binding going through the MFD tree and soc maintainers applying
> the individual dts patches.
> 
> As written the binding change is backward compatible, so no harm.
> 
> I was just confused by the "Acked-by" and wanted to clarify how you
> see it ;-)
>

The bindings patch should not be split more, but itself can be taken
alone. DTS patches can go via SoC maintainer trees.


Best regards,
Krzysztof

Re: [PATCH 1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema

[Lee Jones]

On Thu, 24 Feb 2022, Krzysztof Kozlowski wrote:

> On 24/02/2022 11:06, Heiko Stuebner wrote:
> > Am Donnerstag, 24. Februar 2022, 11:02:48 CET schrieb Lee Jones:
> >> On Wed, 23 Feb 2022, Heiko Stuebner wrote:
> >>
> >>> Hi Lee,
> >>>
> >>> Am Mittwoch, 23. Februar 2022, 10:16:01 CET schrieb Lee Jones:
> >>>> On Mon, 14 Feb 2022, Krzysztof Kozlowski wrote:
> >>>>
> >>>>> Include generic pwm.yaml schema, which enforces PWM node naming.  Keep
> >>>>> the old name in bindings as deprecated.
> >>>>>
> >>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >>>>> ---
> >>>>>  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++
> >>>>
> >>>> Acked-by: Lee Jones <lee.jones@linaro.org>
> >>>
> >>> what is your expectation regarding this patch?
> >>>
> >>> Are you planning to merge it or are you expecting this to go through
> >>> some other tree?
> >>>
> >>> The binding-change here is backward-comaptible in that the old
> >>> node-name is still in it, only marked as deprecated, so in theory
> >>> this patch should be able to be applied on its own without
> >>> causing defects.
> >>
> >> In an ideal world, it would be broken up and I would take the MFD
> >> part.   Is that possible or are there dependencies?
> > 
> > That is also what Krzysztof had in mind - see his reply to patch4.
> > Binding going through the MFD tree and soc maintainers applying
> > the individual dts patches.
> > 
> > As written the binding change is backward compatible, so no harm.
> > 
> > I was just confused by the "Acked-by" and wanted to clarify how you
> > see it ;-)
> >
> 
> The bindings patch should not be split more, but itself can be taken
> alone. DTS patches can go via SoC maintainer trees.

So in answer to Heiko's question, either Thierry, Rob or I can take
the patch.  I'm not overly fussed which.  If I am to take it, I need
Thierry's go-ahead and info on whether he requires a PR or not.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

On Mon, Feb 14, 2022 at 09:19:13AM +0100, Krzysztof Kozlowski wrote:
> Include generic pwm.yaml schema, which enforces PWM node naming.  Keep
> the old name in bindings as deprecated.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++
>  .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml          | 5 ++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema

[Lee Jones]

On Thu, 24 Feb 2022, Thierry Reding wrote:

> On Mon, Feb 14, 2022 at 09:19:13AM +0100, Krzysztof Kozlowski wrote:
> > Include generic pwm.yaml schema, which enforces PWM node naming.  Keep
> > the old name in bindings as deprecated.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml    | 4 ++++
> >  .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml          | 5 ++++-
> >  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> Applied, thanks.

Super, thanks T.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: (subset) [PATCH 3/4] arm64: dts: qcom: align Google CROS EC PWM node name with dtschema

[Bjorn Andersson]

On Mon, 14 Feb 2022 09:19:15 +0100, Krzysztof Kozlowski wrote:
> dtschema expects PWM node name to be a generic "pwm".  This also matches
> Devicetree specification requirements about generic node names.
> 
> 

Applied, thanks!

[3/4] arm64: dts: qcom: align Google CROS EC PWM node name with dtschema
      commit: 1e49defb863638cde53e48805747271f80f9abec

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

Re: [PATCH 2/4] arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema

[Krzysztof Kozlowski]

On 14/02/2022 09:19, Krzysztof Kozlowski wrote:
> dtschema expects PWM node name to be a generic "pwm".  This also matches
> Devicetree specification requirements about generic node names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Hi Matthias,

Any comments on this patch?

Best regards,
Krzysztof

Re: [PATCH 0/4] mfd/pwm: dt-bindings: google,cros-ec: include generic pwm schema

[patchwork-bot+chrome-platform]

Hello:

This series was applied to chrome-platform/linux.git (for-kernelci)
by Heiko Stuebner <heiko@sntech.de>:

On Mon, 14 Feb 2022 09:19:12 +0100 you wrote:
> Hi,
> 
> DTS patches are independent. Not tested, but I really hope no downstream kernel
> depends on pwm node naming... If it does, please change it to compatible. :)
> 
> Best regards,
> Krzysztof
> 
> [...]

Here is the summary with links:
  - [1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema
    https://git.kernel.org/chrome-platform/c/6b94ee669e8a
  - [2/4] arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema
    (no matching commit)
  - [3/4] arm64: dts: qcom: align Google CROS EC PWM node name with dtschema
    https://git.kernel.org/chrome-platform/c/1e49defb8636
  - [4/4] arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema
    https://git.kernel.org/chrome-platform/c/a0024f55eb5b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH 0/4] mfd/pwm: dt-bindings: google,cros-ec: include generic pwm schema

[patchwork-bot+chrome-platform]

Hello:

This series was applied to chrome-platform/linux.git (for-next)
by Heiko Stuebner <heiko@sntech.de>:

On Mon, 14 Feb 2022 09:19:12 +0100 you wrote:
> Hi,
> 
> DTS patches are independent. Not tested, but I really hope no downstream kernel
> depends on pwm node naming... If it does, please change it to compatible. :)
> 
> Best regards,
> Krzysztof
> 
> [...]

Here is the summary with links:
  - [1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema
    https://git.kernel.org/chrome-platform/c/6b94ee669e8a
  - [2/4] arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema
    (no matching commit)
  - [3/4] arm64: dts: qcom: align Google CROS EC PWM node name with dtschema
    https://git.kernel.org/chrome-platform/c/1e49defb8636
  - [4/4] arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema
    https://git.kernel.org/chrome-platform/c/a0024f55eb5b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH 0/4] mfd/pwm: dt-bindings: google,cros-ec: include generic pwm schema

[Heiko Stübner]

Am Montag, 4. April 2022, 19:14:21 CEST schrieb patchwork-bot+chrome-platform@kernel.org:
> Hello:
> 
> This series was applied to chrome-platform/linux.git (for-next)
> by Heiko Stuebner <heiko@sntech.de>:

does someone know what goes on here?

I did apply only patch4 back in feburary and I definitly don't have any
access to a chrome-platform tree ;-)


Heiko

> On Mon, 14 Feb 2022 09:19:12 +0100 you wrote:
> > Hi,
> > 
> > DTS patches are independent. Not tested, but I really hope no downstream kernel
> > depends on pwm node naming... If it does, please change it to compatible. :)
> > 
> > Best regards,
> > Krzysztof
> > 
> > [...]
> 
> Here is the summary with links:
>   - [1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema
>     https://git.kernel.org/chrome-platform/c/6b94ee669e8a
>   - [2/4] arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema
>     (no matching commit)
>   - [3/4] arm64: dts: qcom: align Google CROS EC PWM node name with dtschema
>     https://git.kernel.org/chrome-platform/c/1e49defb8636
>   - [4/4] arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema
>     https://git.kernel.org/chrome-platform/c/a0024f55eb5b
> 
> You are awesome, thank you!
> 

Re: [PATCH 0/4] mfd/pwm: dt-bindings: google,cros-ec: include generic pwm schema

[Benson Leung]

[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]

Hi Heiko,

On Mon, Apr 04, 2022 at 07:16:03PM +0200, Heiko Stübner wrote:
> Am Montag, 4. April 2022, 19:14:21 CEST schrieb patchwork-bot+chrome-platform@kernel.org:
> > Hello:
> > 
> > This series was applied to chrome-platform/linux.git (for-next)
> > by Heiko Stuebner <heiko@sntech.de>:
> 
> does someone know what goes on here?
> 
> I did apply only patch4 back in feburary and I definitly don't have any
> access to a chrome-platform tree ;-)
> 

Sorry for the extra noise. It looks like patchwork-bot did this once I updated
chrome-platform's for-next branch to the newly created v5.18-rc1, which
contains this series now.

I'll look into quieting this in the future.

Benson

> 
> Heiko
> 
> > On Mon, 14 Feb 2022 09:19:12 +0100 you wrote:
> > > Hi,
> > > 
> > > DTS patches are independent. Not tested, but I really hope no downstream kernel
> > > depends on pwm node naming... If it does, please change it to compatible. :)
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> > > [...]
> > 
> > Here is the summary with links:
> >   - [1/4] dt-bindings: pwm: google,cros-ec: include generic pwm schema
> >     https://git.kernel.org/chrome-platform/c/6b94ee669e8a
> >   - [2/4] arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema
> >     (no matching commit)
> >   - [3/4] arm64: dts: qcom: align Google CROS EC PWM node name with dtschema
> >     https://git.kernel.org/chrome-platform/c/1e49defb8636
> >   - [4/4] arm64: dts: rk3399: align Google CROS EC PWM node name with dtschema
> >     https://git.kernel.org/chrome-platform/c/a0024f55eb5b
> > 
> > You are awesome, thank you!
> > 
> 
> 
> 
> 

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: (subset) [PATCH 2/4] arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema

[Krzysztof Kozlowski]

On Mon, 14 Feb 2022 09:19:14 +0100, Krzysztof Kozlowski wrote:
> dtschema expects PWM node name to be a generic "pwm".  This also matches
> Devicetree specification requirements about generic node names.
> 
> 

Applied, thanks!

[2/4] arm64: dts: mt8183: align Google CROS EC PWM node name with dtschema
      commit: 559d2104bff0c9a6379db652136d30836859252e

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>