* [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h
@ 2022-04-02 10:17 Christophe Leroy
2022-04-05 20:22 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Christophe Leroy @ 2022-04-02 10:17 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Paolo Abeni
Cc: Christophe Leroy, linux-kernel, netdev
powerpc's asm/prom.h brings some headers that it doesn't
need itself.
In order to clean it up, first add missing headers in
users of asm/prom.h
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
drivers/net/sungem_phy.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
index 4daac5fda073..ff22b6b1c686 100644
--- a/drivers/net/sungem_phy.c
+++ b/drivers/net/sungem_phy.c
@@ -29,11 +29,7 @@
#include <linux/mii.h>
#include <linux/ethtool.h>
#include <linux/delay.h>
-
-#ifdef CONFIG_PPC_PMAC
-#include <asm/prom.h>
-#endif
-
+#include <linux/of.h>
#include <linux/sungem_phy.h>
/* Link modes of the BCM5400 PHY */
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h
2022-04-02 10:17 [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h Christophe Leroy
@ 2022-04-05 20:22 ` Jakub Kicinski
2022-04-06 5:53 ` Christophe Leroy
2022-04-15 8:45 ` Christophe Leroy
0 siblings, 2 replies; 5+ messages in thread
From: Jakub Kicinski @ 2022-04-05 20:22 UTC (permalink / raw)
To: Christophe Leroy; +Cc: David S. Miller, Paolo Abeni, linux-kernel, netdev
On Sat, 2 Apr 2022 12:17:13 +0200 Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
>
> In order to clean it up, first add missing headers in
> users of asm/prom.h
Could you resend the net-next patches you had?
They got dropped from patchwork due to net-next being closed during
the merge window.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h
2022-04-05 20:22 ` Jakub Kicinski
@ 2022-04-06 5:53 ` Christophe Leroy
2022-04-06 16:39 ` Jakub Kicinski
2022-04-15 8:45 ` Christophe Leroy
1 sibling, 1 reply; 5+ messages in thread
From: Christophe Leroy @ 2022-04-06 5:53 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: David S. Miller, Paolo Abeni, linux-kernel, netdev
Le 05/04/2022 à 22:22, Jakub Kicinski a écrit :
> On Sat, 2 Apr 2022 12:17:13 +0200 Christophe Leroy wrote:
>> powerpc's asm/prom.h brings some headers that it doesn't
>> need itself.
>>
>> In order to clean it up, first add missing headers in
>> users of asm/prom.h
>
> Could you resend the net-next patches you had?
Sure I can but,
>
> They got dropped from patchwork due to net-next being closed during
> the merge window.
https://patchwork.kernel.org/project/netdevbpf/list/?series=&submitter=192363&state=*&q=&archive=&delegate=
As far as I can see they are in patchwork and two of them have been
accepted, and this one is tagged as 'deferred', so do I have to resend it ?
Thanks
Christophe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h
2022-04-06 5:53 ` Christophe Leroy
@ 2022-04-06 16:39 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2022-04-06 16:39 UTC (permalink / raw)
To: Christophe Leroy; +Cc: David S. Miller, Paolo Abeni, linux-kernel, netdev
On Wed, 6 Apr 2022 05:53:46 +0000 Christophe Leroy wrote:
> Le 05/04/2022 à 22:22, Jakub Kicinski a écrit :
> > On Sat, 2 Apr 2022 12:17:13 +0200 Christophe Leroy wrote:
> >> powerpc's asm/prom.h brings some headers that it doesn't
> >> need itself.
> >>
> >> In order to clean it up, first add missing headers in
> >> users of asm/prom.h
> >
> > Could you resend the net-next patches you had?
>
> Sure I can but,
>
> >
> > They got dropped from patchwork due to net-next being closed during
> > the merge window.
>
> https://patchwork.kernel.org/project/netdevbpf/list/?series=&submitter=192363&state=*&q=&archive=&delegate=
>
> As far as I can see they are in patchwork and two of them have been
> accepted, and this one is tagged as 'deferred', so do I have to resend it ?
Erm, perhaps a clerical error? I don't see them in the tree.
I'd resend both.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h
2022-04-05 20:22 ` Jakub Kicinski
2022-04-06 5:53 ` Christophe Leroy
@ 2022-04-15 8:45 ` Christophe Leroy
1 sibling, 0 replies; 5+ messages in thread
From: Christophe Leroy @ 2022-04-15 8:45 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: David S. Miller, Paolo Abeni, linux-kernel, netdev
Le 05/04/2022 à 22:22, Jakub Kicinski a écrit :
> On Sat, 2 Apr 2022 12:17:13 +0200 Christophe Leroy wrote:
>> powerpc's asm/prom.h brings some headers that it doesn't
>> need itself.
>>
>> In order to clean it up, first add missing headers in
>> users of asm/prom.h
>
> Could you resend the net-next patches you had?
>
> They got dropped from patchwork due to net-next being closed during
> the merge window.
Ok, I sent v2, with a bit more detailed description.
Thanks
Christophe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-15 8:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-02 10:17 [PATCH net-next] sungem: Prepare cleanup of powerpc's asm/prom.h Christophe Leroy
2022-04-05 20:22 ` Jakub Kicinski
2022-04-06 5:53 ` Christophe Leroy
2022-04-06 16:39 ` Jakub Kicinski
2022-04-15 8:45 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).