From: abhinavk@codeaurora.org
To: Bernard Zhao <bernard@vivo.com>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Kuogee Hsieh <khsieh@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Tanmay Shah <tanmay@codeaurora.org>,
Chandan Uddaraju <chandanu@codeaurora.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable ret
Date: Wed, 07 Apr 2021 10:55:14 -0700 [thread overview]
Message-ID: <5b49ba66511153f1ec092906c85b32a5@codeaurora.org> (raw)
In-Reply-To: <20210407130654.3387-1-bernard@vivo.com>
On 2021-04-07 06:06, Bernard Zhao wrote:
> This patch fix coccicheck warning:
> drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret".
> Return "0" on line 880
> Also remove unneeded function return value check.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/dp/dp_link.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_link.c
> b/drivers/gpu/drm/msm/dp/dp_link.c
> index be986da78c4a..3395b08155a6 100644
> --- a/drivers/gpu/drm/msm/dp/dp_link.c
> +++ b/drivers/gpu/drm/msm/dp/dp_link.c
> @@ -843,10 +843,8 @@ bool dp_link_send_edid_checksum(struct dp_link
> *dp_link, u8 checksum)
> return ret == 1;
> }
>
> -static int dp_link_parse_vx_px(struct dp_link_private *link)
> +static void dp_link_parse_vx_px(struct dp_link_private *link)
> {
> - int ret = 0;
> -
> DRM_DEBUG_DP("vx: 0=%d, 1=%d, 2=%d, 3=%d\n",
> drm_dp_get_adjust_request_voltage(link->link_status, 0),
> drm_dp_get_adjust_request_voltage(link->link_status, 1),
> @@ -876,8 +874,6 @@ static int dp_link_parse_vx_px(struct
> dp_link_private *link)
> DRM_DEBUG_DP("Requested: v_level = 0x%x, p_level = 0x%x\n",
> link->dp_link.phy_params.v_level,
> link->dp_link.phy_params.p_level);
> -
> - return ret;
> }
>
> /**
> @@ -891,8 +887,6 @@ static int dp_link_parse_vx_px(struct
> dp_link_private *link)
> static int dp_link_process_phy_test_pattern_request(
> struct dp_link_private *link)
> {
> - int ret = 0;
> -
> if (!(link->request.test_requested & DP_TEST_LINK_PHY_TEST_PATTERN))
> {
> DRM_DEBUG_DP("no phy test\n");
> return -EINVAL;
> @@ -918,12 +912,9 @@ static int
> dp_link_process_phy_test_pattern_request(
> link->dp_link.link_params.rate =
> drm_dp_bw_code_to_link_rate(link->request.test_link_rate);
>
> - ret = dp_link_parse_vx_px(link);
> -
> - if (ret)
> - DRM_ERROR("parse_vx_px failed. ret=%d\n", ret);
> + dp_link_parse_vx_px(link);
>
> - return ret;
> + return 0;
> }
>
> static u8 get_link_status(const u8 link_status[DP_LINK_STATUS_SIZE],
> int r)
next prev parent reply other threads:[~2021-04-07 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 13:06 [PATCH] drm/msm: remove unneeded variable ret Bernard Zhao
2021-04-07 17:55 ` abhinavk [this message]
2021-04-07 18:22 ` Stephen Boyd
2021-05-26 0:55 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b49ba66511153f1ec092906c85b32a5@codeaurora.org \
--to=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bernard@vivo.com \
--cc=chandanu@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=tanmay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).